From: kernel test robot <lkp@intel.com>
To: Markus Elfring <Markus.Elfring@web.de>,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"D. Wythe" <alibuda@linux.alibaba.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Jan Karcher <jaka@linux.ibm.com>, Paolo Abeni <pabeni@redhat.com>,
Tony Lu <tonylu@linux.alibaba.com>,
Wen Gu <guwen@linux.alibaba.com>,
Wenjia Zhang <wenjia@linux.ibm.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] net/smc: Improve exception handling in smc_llc_cli_add_link_invite()
Date: Mon, 1 Jan 2024 06:09:07 +0800 [thread overview]
Message-ID: <202401010536.XhzcWDPH-lkp@intel.com> (raw)
In-Reply-To: <5253e660-6b66-4775-ae2f-06f5a1d40be5@web.de>
Hi Markus,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net/main]
[also build test WARNING on net-next/main linus/master v6.7-rc7 next-20231222]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Markus-Elfring/net-smc-Return-directly-after-a-failed-kzalloc-in-smc_fill_gid_list/20231231-231406
base: net/main
patch link: https://lore.kernel.org/r/5253e660-6b66-4775-ae2f-06f5a1d40be5%40web.de
patch subject: [PATCH 2/2] net/smc: Improve exception handling in smc_llc_cli_add_link_invite()
config: x86_64-randconfig-002-20231231 (https://download.01.org/0day-ci/archive/20240101/202401010536.XhzcWDPH-lkp@intel.com/config)
compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240101/202401010536.XhzcWDPH-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401010536.XhzcWDPH-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> net/smc/smc_llc.c:1175:34: warning: '&&' within '||' [-Wlogical-op-parentheses]
1174 | lgr->type == SMC_LGR_ASYMMETRIC_PEER ||
| ~~
1175 | lgr->type == SMC_LGR_SINGLE && lgr->max_links <= 1)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
net/smc/smc_llc.c:1175:34: note: place parentheses around the '&&' expression to silence this warning
1175 | lgr->type == SMC_LGR_SINGLE && lgr->max_links <= 1)
| ^
| ( )
1 warning generated.
vim +1175 net/smc/smc_llc.c
1160
1161 /* as an SMC client, invite server to start the add_link processing */
1162 static void smc_llc_cli_add_link_invite(struct smc_link *link,
1163 struct smc_llc_qentry *qentry)
1164 {
1165 struct smc_link_group *lgr = smc_get_lgr(link);
1166 struct smc_init_info *ini;
1167
1168 if (lgr->smc_version == SMC_V2) {
1169 smc_llc_send_request_add_link(link);
1170 goto free_qentry;
1171 }
1172
1173 if (lgr->type == SMC_LGR_SYMMETRIC ||
1174 lgr->type == SMC_LGR_ASYMMETRIC_PEER ||
> 1175 lgr->type == SMC_LGR_SINGLE && lgr->max_links <= 1)
1176 goto free_qentry;
1177
1178 ini = kzalloc(sizeof(*ini), GFP_KERNEL);
1179 if (!ini)
1180 goto free_qentry;
1181
1182 ini->vlan_id = lgr->vlan_id;
1183 smc_pnet_find_alt_roce(lgr, ini, link->smcibdev);
1184 if (!ini->ib_dev)
1185 goto out;
1186
1187 smc_llc_send_add_link(link, ini->ib_dev->mac[ini->ib_port - 1],
1188 ini->ib_gid, NULL, SMC_LLC_REQ);
1189 out:
1190 kfree(ini);
1191 free_qentry:
1192 kfree(qentry);
1193 }
1194
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next parent reply other threads:[~2023-12-31 22:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5253e660-6b66-4775-ae2f-06f5a1d40be5@web.de>
2023-12-31 22:09 ` kernel test robot [this message]
2023-12-31 22:40 ` [PATCH 2/2] net/smc: Improve exception handling in smc_llc_cli_add_link_invite() kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202401010536.XhzcWDPH-lkp@intel.com \
--to=lkp@intel.com \
--cc=Markus.Elfring@web.de \
--cc=alibuda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=jaka@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).