From: kernel test robot <lkp@intel.com>
To: kernel@openeuler.org, Peng Zhang <zhangpeng362@huawei.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [openeuler:OLK-6.6 1646/2894] fs/userfaultfd.c:1809:23: sparse: sparse: invalid assignment: |=
Date: Thu, 1 Feb 2024 00:37:17 +0800 [thread overview]
Message-ID: <202402010014.yQVRXXr1-lkp@intel.com> (raw)
tree: https://gitee.com/openeuler/kernel.git OLK-6.6
head: f6f9abf1a5ef2fc559630c77b3570346dcd19d40
commit: 0214feb8f616acf62f9a6a2a131f0a1479b2b8af [1646/2894] mm/userswap: introduce UFFDIO_COPY_MODE_DIRECT_MAP
config: x86_64-randconfig-121-20240131 (https://download.01.org/0day-ci/archive/20240201/202402010014.yQVRXXr1-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240201/202402010014.yQVRXXr1-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402010014.yQVRXXr1-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> fs/userfaultfd.c:1809:23: sparse: sparse: invalid assignment: |=
fs/userfaultfd.c:1809:23: sparse: left side has type restricted uffd_flags_t
fs/userfaultfd.c:1809:23: sparse: right side has type int
fs/userfaultfd.c: note: in included file (through include/linux/rculist.h, include/linux/hashtable.h):
include/linux/rcupdate.h:780:9: sparse: sparse: context imbalance in 'handle_userfault' - unexpected unlock
--
mm/userfaultfd.c: note: in included file (through include/linux/rbtree.h, include/linux/mm_types.h, include/linux/mmzone.h, ...):
include/linux/rcupdate.h:780:9: sparse: sparse: context imbalance in 'mfill_atomic_install_pte' - unexpected unlock
include/linux/rcupdate.h:780:9: sparse: sparse: context imbalance in 'mfill_atomic_pte_zeropage' - unexpected unlock
include/linux/rcupdate.h:780:9: sparse: sparse: context imbalance in 'mfill_atomic_pte_poison' - unexpected unlock
mm/userfaultfd.c: note: in included file:
>> include/linux/userfaultfd_k.h:66:45: sparse: sparse: restricted uffd_flags_t degrades to integer
>> include/linux/userfaultfd_k.h:67:32: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted uffd_flags_t [usertype] flags @@ got unsigned int enum mfill_atomic_mode mode @@
include/linux/userfaultfd_k.h:67:32: sparse: expected restricted uffd_flags_t [usertype] flags
include/linux/userfaultfd_k.h:67:32: sparse: got unsigned int enum mfill_atomic_mode mode
>> include/linux/userfaultfd_k.h:66:45: sparse: sparse: restricted uffd_flags_t degrades to integer
>> include/linux/userfaultfd_k.h:67:32: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted uffd_flags_t [usertype] flags @@ got unsigned int enum mfill_atomic_mode mode @@
include/linux/userfaultfd_k.h:67:32: sparse: expected restricted uffd_flags_t [usertype] flags
include/linux/userfaultfd_k.h:67:32: sparse: got unsigned int enum mfill_atomic_mode mode
>> include/linux/userfaultfd_k.h:66:45: sparse: sparse: restricted uffd_flags_t degrades to integer
>> include/linux/userfaultfd_k.h:67:32: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted uffd_flags_t [usertype] flags @@ got unsigned int enum mfill_atomic_mode mode @@
include/linux/userfaultfd_k.h:67:32: sparse: expected restricted uffd_flags_t [usertype] flags
include/linux/userfaultfd_k.h:67:32: sparse: got unsigned int enum mfill_atomic_mode mode
>> include/linux/userfaultfd_k.h:66:45: sparse: sparse: restricted uffd_flags_t degrades to integer
>> include/linux/userfaultfd_k.h:67:32: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted uffd_flags_t [usertype] flags @@ got unsigned int enum mfill_atomic_mode mode @@
include/linux/userfaultfd_k.h:67:32: sparse: expected restricted uffd_flags_t [usertype] flags
include/linux/userfaultfd_k.h:67:32: sparse: got unsigned int enum mfill_atomic_mode mode
vim +1809 fs/userfaultfd.c
1769
1770 static int userfaultfd_copy(struct userfaultfd_ctx *ctx,
1771 unsigned long arg)
1772 {
1773 __s64 ret;
1774 struct uffdio_copy uffdio_copy;
1775 struct uffdio_copy __user *user_uffdio_copy;
1776 struct userfaultfd_wake_range range;
1777 uffd_flags_t flags = 0;
1778
1779 user_uffdio_copy = (struct uffdio_copy __user *) arg;
1780
1781 ret = -EAGAIN;
1782 if (atomic_read(&ctx->mmap_changing))
1783 goto out;
1784
1785 ret = -EFAULT;
1786 if (copy_from_user(&uffdio_copy, user_uffdio_copy,
1787 /* don't copy "copy" last field */
1788 sizeof(uffdio_copy)-sizeof(__s64)))
1789 goto out;
1790
1791 ret = validate_unaligned_range(ctx->mm, uffdio_copy.src,
1792 uffdio_copy.len);
1793 if (ret)
1794 goto out;
1795 ret = validate_range(ctx->mm, uffdio_copy.dst, uffdio_copy.len);
1796 if (ret)
1797 goto out;
1798
1799 ret = -EINVAL;
1800 if (uffdio_copy.mode & ~(UFFDIO_COPY_MODE_DONTWAKE |
1801 UFFDIO_COPY_MODE_WP |
1802 IS_ENABLED(CONFIG_USERSWAP) ?
1803 UFFDIO_COPY_MODE_DIRECT_MAP : 0))
1804 goto out;
1805 if (uffdio_copy.mode & UFFDIO_COPY_MODE_WP)
1806 flags |= MFILL_ATOMIC_WP;
1807 if (IS_ENABLED(CONFIG_USERSWAP) &&
1808 (uffdio_copy.mode & UFFDIO_COPY_MODE_DIRECT_MAP))
> 1809 flags |= MFILL_ATOMIC_DIRECT_MAP;
1810 if (mmget_not_zero(ctx->mm)) {
1811 ret = mfill_atomic_copy(ctx->mm, uffdio_copy.dst, uffdio_copy.src,
1812 uffdio_copy.len, &ctx->mmap_changing,
1813 flags);
1814 mmput(ctx->mm);
1815 } else {
1816 return -ESRCH;
1817 }
1818 if (unlikely(put_user(ret, &user_uffdio_copy->copy)))
1819 return -EFAULT;
1820 if (ret < 0)
1821 goto out;
1822 BUG_ON(!ret);
1823 /* len == 0 would wake all */
1824 range.len = ret;
1825 if (!(uffdio_copy.mode & UFFDIO_COPY_MODE_DONTWAKE)) {
1826 range.start = uffdio_copy.dst;
1827 wake_userfault(ctx, &range);
1828 }
1829 ret = range.len == uffdio_copy.len ? 0 : -EAGAIN;
1830 out:
1831 return ret;
1832 }
1833
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-01-31 16:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202402010014.yQVRXXr1-lkp@intel.com \
--to=lkp@intel.com \
--cc=kernel@openeuler.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=zhangpeng362@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).