oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kernel@openeuler.org, Yu Zhang <yu.c.zhang@linux.intel.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [openeuler:OLK-5.10 28292/30000] arch/x86/kvm/mmu/mmu.c:5812 kvm_mmu_slot_largepage_remove_write_access() error: uninitialized symbol 'flush'.
Date: Thu, 1 Feb 2024 07:33:16 +0800	[thread overview]
Message-ID: <202402010712.s76rk6os-lkp@intel.com> (raw)

tree:   https://gitee.com/openeuler/kernel.git OLK-5.10
head:   260c7a5874066269671cc826d6c9ccd70dd001e5
commit: 7eb46ab3d33ed664d9d4fe0e3cdf3232a9099e11 [28292/30000] KVM: x86/mmu: Skip rmap operations if rmaps not allocated
config: x86_64-randconfig-161-20240129 (https://download.01.org/0day-ci/archive/20240201/202402010712.s76rk6os-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402010712.s76rk6os-lkp@intel.com/

New smatch warnings:
arch/x86/kvm/mmu/mmu.c:5812 kvm_mmu_slot_largepage_remove_write_access() error: uninitialized symbol 'flush'.
arch/x86/kvm/mmu/mmu.c:5834 kvm_mmu_slot_set_dirty() error: uninitialized symbol 'flush'.

Old smatch warnings:
arch/x86/kvm/mmu/mmu.c:3788 direct_page_fault() warn: missing error code? 'r'
arch/x86/kvm/mmu/paging_tmpl.h:857 ept_page_fault() warn: missing error code? 'r'
arch/x86/kvm/mmu/paging_tmpl.h:857 paging64_page_fault() warn: missing error code? 'r'
arch/x86/kvm/mmu/paging_tmpl.h:857 paging32_page_fault() warn: missing error code? 'r'
arch/x86/kvm/mmu/mmu.c:5743 kvm_mmu_zap_collapsible_sptes() error: uninitialized symbol 'flush'.

vim +/flush +5812 arch/x86/kvm/mmu/mmu.c

f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5793  
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5794  void kvm_mmu_slot_largepage_remove_write_access(struct kvm *kvm,
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5795  					struct kvm_memory_slot *memslot)
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5796  {
d77aa73c7072c5 arch/x86/kvm/mmu.c     Xiao Guangrong      2015-05-13  5797  	bool flush;
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5798  
7eb46ab3d33ed6 arch/x86/kvm/mmu/mmu.c Ben Gardon          2021-05-18  5799  	if (kvm_memslots_have_rmaps(kvm)) {
91f65ea3582813 arch/x86/kvm/mmu/mmu.c Ben Gardon          2023-08-14  5800  		write_lock(&kvm->mmu_lock);
d77aa73c7072c5 arch/x86/kvm/mmu.c     Xiao Guangrong      2015-05-13  5801  		flush = slot_handle_large_level(kvm, memslot, slot_rmap_write_protect,
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5802  						false);
91f65ea3582813 arch/x86/kvm/mmu/mmu.c Ben Gardon          2023-08-14  5803  		write_unlock(&kvm->mmu_lock);
7eb46ab3d33ed6 arch/x86/kvm/mmu/mmu.c Ben Gardon          2021-05-18  5804  	}
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5805  
ac11ca5ab371f5 arch/x86/kvm/mmu/mmu.c Ben Gardon          2021-04-01  5806  	if (is_tdp_mmu_enabled(kvm)) {
ac11ca5ab371f5 arch/x86/kvm/mmu/mmu.c Ben Gardon          2021-04-01  5807  		read_lock(&kvm->mmu_lock);
ac11ca5ab371f5 arch/x86/kvm/mmu/mmu.c Ben Gardon          2021-04-01  5808  		flush |= kvm_tdp_mmu_wrprot_slot(kvm, memslot, PG_LEVEL_2M);
ac11ca5ab371f5 arch/x86/kvm/mmu/mmu.c Ben Gardon          2021-04-01  5809  		read_unlock(&kvm->mmu_lock);
ac11ca5ab371f5 arch/x86/kvm/mmu/mmu.c Ben Gardon          2021-04-01  5810  	}
ac11ca5ab371f5 arch/x86/kvm/mmu/mmu.c Ben Gardon          2021-04-01  5811  
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28 @5812  	if (flush)
7f42aa76d4a558 arch/x86/kvm/mmu/mmu.c Sean Christopherson 2020-02-18  5813  		kvm_arch_flush_remote_tlbs_memslot(kvm, memslot);
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5814  }
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5815  EXPORT_SYMBOL_GPL(kvm_mmu_slot_largepage_remove_write_access);
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5816  
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5817  void kvm_mmu_slot_set_dirty(struct kvm *kvm,
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5818  			    struct kvm_memory_slot *memslot)
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5819  {
d77aa73c7072c5 arch/x86/kvm/mmu.c     Xiao Guangrong      2015-05-13  5820  	bool flush;
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5821  
7eb46ab3d33ed6 arch/x86/kvm/mmu/mmu.c Ben Gardon          2021-05-18  5822  	if (kvm_memslots_have_rmaps(kvm)) {
91f65ea3582813 arch/x86/kvm/mmu/mmu.c Ben Gardon          2023-08-14  5823  		write_lock(&kvm->mmu_lock);
d77aa73c7072c5 arch/x86/kvm/mmu.c     Xiao Guangrong      2015-05-13  5824  		flush = slot_handle_all_level(kvm, memslot, __rmap_set_dirty, false);
91f65ea3582813 arch/x86/kvm/mmu/mmu.c Ben Gardon          2023-08-14  5825  		write_unlock(&kvm->mmu_lock);
7eb46ab3d33ed6 arch/x86/kvm/mmu/mmu.c Ben Gardon          2021-05-18  5826  	}
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5827  
ac11ca5ab371f5 arch/x86/kvm/mmu/mmu.c Ben Gardon          2021-04-01  5828  	if (is_tdp_mmu_enabled(kvm)) {
ac11ca5ab371f5 arch/x86/kvm/mmu/mmu.c Ben Gardon          2021-04-01  5829  		read_lock(&kvm->mmu_lock);
ac11ca5ab371f5 arch/x86/kvm/mmu/mmu.c Ben Gardon          2021-04-01  5830  		flush |= kvm_tdp_mmu_slot_set_dirty(kvm, memslot);
ac11ca5ab371f5 arch/x86/kvm/mmu/mmu.c Ben Gardon          2021-04-01  5831  		read_unlock(&kvm->mmu_lock);
ac11ca5ab371f5 arch/x86/kvm/mmu/mmu.c Ben Gardon          2021-04-01  5832  	}
ac11ca5ab371f5 arch/x86/kvm/mmu/mmu.c Ben Gardon          2021-04-01  5833  
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28 @5834  	if (flush)
7f42aa76d4a558 arch/x86/kvm/mmu/mmu.c Sean Christopherson 2020-02-18  5835  		kvm_arch_flush_remote_tlbs_memslot(kvm, memslot);
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5836  }
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5837  EXPORT_SYMBOL_GPL(kvm_mmu_slot_set_dirty);
f4b4b1808690c3 arch/x86/kvm/mmu.c     Kai Huang           2015-01-28  5838  

:::::: The code at line 5812 was first introduced by commit
:::::: f4b4b1808690c37c7c703d43789c1988c5e7fdeb KVM: MMU: Add mmu help functions to support PML

:::::: TO: Kai Huang <kai.huang@linux.intel.com>
:::::: CC: Paolo Bonzini <pbonzini@redhat.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-01-31 23:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202402010712.s76rk6os-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kernel@openeuler.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=yu.c.zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).