Re: [PATCH 01/28] [NOT FOR REVIEW] drm: color pipeline base work

[kernel test robot <lkp@intel.com>]

Hi Uma,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on drm/drm-next next-20240216]
[cannot apply to drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.8-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Uma-Shankar/drm-color-pipeline-base-work/20240213-144544
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20240213064835.139464-2-uma.shankar%40intel.com
patch subject: [PATCH 01/28] [NOT FOR REVIEW] drm: color pipeline base work
config: x86_64-randconfig-121-20240214 (https://download.01.org/0day-ci/archive/20240216/202402161931.6Z8xdViq-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240216/202402161931.6Z8xdViq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402161931.6Z8xdViq-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/vkms/vkms_colorop.c:11:11: sparse: sparse: symbol 'vkms_initialize_tf_pipeline' was not declared. Should it be static?
--
   drivers/gpu/drm/vkms/vkms_composer.c: note: in included file:
>> drivers/gpu/drm/vkms/tests/vkms_color_tests.c:29:29: sparse: sparse: symbol 'test_linear_lut' was not declared. Should it be static?
>> drivers/gpu/drm/vkms/tests/vkms_color_tests.c:87:32: sparse: sparse: symbol 'test_matrix_3x4_50_desat' was not declared. Should it be static?
>> drivers/gpu/drm/vkms/tests/vkms_color_tests.c:146:32: sparse: sparse: symbol 'test_matrix_3x4_bt709_enc' was not declared. Should it be static?

vim +/vkms_initialize_tf_pipeline +11 drivers/gpu/drm/vkms/vkms_colorop.c

    10	
  > 11	const int vkms_initialize_tf_pipeline(struct drm_plane *plane, struct drm_prop_enum_list *list)
    12	{
    13	
    14		struct drm_colorop *op, *prev_op;
    15		struct drm_device *dev = plane->dev;
    16		int ret;
    17	
    18		/* 1st op: 1d curve */
    19		op = kzalloc(sizeof(struct drm_colorop), GFP_KERNEL);
    20		if (!op) {
    21			DRM_ERROR("KMS: Failed to allocate colorop\n");
    22			return -ENOMEM;
    23		}
    24	
    25		ret = drm_colorop_init(dev, op, plane, DRM_COLOROP_1D_CURVE);
    26		if (ret)
    27			return ret;
    28	
    29		list->type = op->base.id;
    30		list->name = kasprintf(GFP_KERNEL, "Color Pipeline %d", op->base.id);
    31	
    32		prev_op = op;
    33	
    34		/* 2nd op: 3x4 matrix */
    35		op = kzalloc(sizeof(struct drm_colorop), GFP_KERNEL);
    36		if (!op) {
    37			DRM_ERROR("KMS: Failed to allocate colorop\n");
    38			return -ENOMEM;
    39		}
    40	
    41		ret = drm_colorop_init(dev, op, plane, DRM_COLOROP_CTM_3X4);
    42		if (ret)
    43			return ret;
    44	
    45		drm_colorop_set_next_property(prev_op, op);
    46	
    47		prev_op = op;
    48	
    49		/* 3rd op: 3x4 matrix */
    50		op = kzalloc(sizeof(struct drm_colorop), GFP_KERNEL);
    51		if (!op) {
    52			DRM_ERROR("KMS: Failed to allocate colorop\n");
    53			return -ENOMEM;
    54		}
    55	
    56		ret = drm_colorop_init(dev, op, plane, DRM_COLOROP_CTM_3X4);
    57		if (ret)
    58			return ret;
    59	
    60		drm_colorop_set_next_property(prev_op, op);
    61	
    62		prev_op = op;
    63	
    64		/* 4th op: 1d curve */
    65		op = kzalloc(sizeof(struct drm_colorop), GFP_KERNEL);
    66		if (!op) {
    67			DRM_ERROR("KMS: Failed to allocate colorop\n");
    68			return -ENOMEM;
    69		}
    70	
    71		ret = drm_colorop_init(dev, op, plane, DRM_COLOROP_1D_CURVE);
    72		if (ret)
    73			return ret;
    74	
    75		drm_colorop_set_next_property(prev_op, op);
    76	
    77		return 0;
    78	}
    79	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki