Re: [PATCH 3/5] media: imx335: Use V4L2 CCI for accessing sensor registers

[kernel test robot <lkp@intel.com>]

Hi Umang,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linuxtv-media-stage/master]
[cannot apply to media-tree/master sailus-media-tree/streams linus/master v6.8-rc7 next-20240308]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Umang-Jain/media-imx335-Support-2-or-4-lane-operation-modes/20240306-161903
base:   https://git.linuxtv.org/media_stage.git master
patch link:    https://lore.kernel.org/r/20240306081038.212412-4-umang.jain%40ideasonboard.com
patch subject: [PATCH 3/5] media: imx335: Use V4L2 CCI for accessing sensor registers
config: sh-allyesconfig (https://download.01.org/0day-ci/archive/20240309/202403090619.8LsTJtMf-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240309/202403090619.8LsTJtMf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403090619.8LsTJtMf-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/media/i2c/imx335.c:214: warning: Function parameter or struct member 'cci' not described in 'imx335'
   drivers/media/i2c/imx335.c:214: warning: Function parameter or struct member 'lane_mode' not described in 'imx335'


vim +214 drivers/media/i2c/imx335.c

45d19b5fb9aeab Martina Krasteva 2021-05-27  165  
45d19b5fb9aeab Martina Krasteva 2021-05-27  166  /**
45d19b5fb9aeab Martina Krasteva 2021-05-27  167   * struct imx335 - imx335 sensor device structure
45d19b5fb9aeab Martina Krasteva 2021-05-27  168   * @dev: Pointer to generic device
45d19b5fb9aeab Martina Krasteva 2021-05-27  169   * @client: Pointer to i2c client
45d19b5fb9aeab Martina Krasteva 2021-05-27  170   * @sd: V4L2 sub-device
45d19b5fb9aeab Martina Krasteva 2021-05-27  171   * @pad: Media pad. Only one pad supported
45d19b5fb9aeab Martina Krasteva 2021-05-27  172   * @reset_gpio: Sensor reset gpio
fea91ee73b7cd1 Kieran Bingham   2023-12-11  173   * @supplies: Regulator supplies to handle power control
45d19b5fb9aeab Martina Krasteva 2021-05-27  174   * @inclk: Sensor input clock
45d19b5fb9aeab Martina Krasteva 2021-05-27  175   * @ctrl_handler: V4L2 control handler
45d19b5fb9aeab Martina Krasteva 2021-05-27  176   * @link_freq_ctrl: Pointer to link frequency control
45d19b5fb9aeab Martina Krasteva 2021-05-27  177   * @pclk_ctrl: Pointer to pixel clock control
45d19b5fb9aeab Martina Krasteva 2021-05-27  178   * @hblank_ctrl: Pointer to horizontal blanking control
45d19b5fb9aeab Martina Krasteva 2021-05-27  179   * @vblank_ctrl: Pointer to vertical blanking control
45d19b5fb9aeab Martina Krasteva 2021-05-27  180   * @exp_ctrl: Pointer to exposure control
45d19b5fb9aeab Martina Krasteva 2021-05-27  181   * @again_ctrl: Pointer to analog gain control
45d19b5fb9aeab Martina Krasteva 2021-05-27  182   * @vblank: Vertical blanking in lines
8c48b2175e7d73 Kieran Bingham   2024-03-06  183   * @lane_mode Mode for number of connected data lanes
45d19b5fb9aeab Martina Krasteva 2021-05-27  184   * @cur_mode: Pointer to current selected sensor mode
45d19b5fb9aeab Martina Krasteva 2021-05-27  185   * @mutex: Mutex for serializing sensor controls
0862582b5239a6 Umang Jain       2024-02-20  186   * @link_freq_bitmap: Menu bitmap for link_freq_ctrl
cfa49ff0558a32 Umang Jain       2023-12-11  187   * @cur_mbus_code: Currently selected media bus format code
45d19b5fb9aeab Martina Krasteva 2021-05-27  188   */
45d19b5fb9aeab Martina Krasteva 2021-05-27  189  struct imx335 {
45d19b5fb9aeab Martina Krasteva 2021-05-27  190  	struct device *dev;
45d19b5fb9aeab Martina Krasteva 2021-05-27  191  	struct i2c_client *client;
45d19b5fb9aeab Martina Krasteva 2021-05-27  192  	struct v4l2_subdev sd;
45d19b5fb9aeab Martina Krasteva 2021-05-27  193  	struct media_pad pad;
45d19b5fb9aeab Martina Krasteva 2021-05-27  194  	struct gpio_desc *reset_gpio;
fea91ee73b7cd1 Kieran Bingham   2023-12-11  195  	struct regulator_bulk_data supplies[ARRAY_SIZE(imx335_supply_name)];
fa7ceacf9c0af6 Umang Jain       2024-03-06  196  	struct regmap *cci;
fea91ee73b7cd1 Kieran Bingham   2023-12-11  197  
45d19b5fb9aeab Martina Krasteva 2021-05-27  198  	struct clk *inclk;
45d19b5fb9aeab Martina Krasteva 2021-05-27  199  	struct v4l2_ctrl_handler ctrl_handler;
45d19b5fb9aeab Martina Krasteva 2021-05-27  200  	struct v4l2_ctrl *link_freq_ctrl;
45d19b5fb9aeab Martina Krasteva 2021-05-27  201  	struct v4l2_ctrl *pclk_ctrl;
45d19b5fb9aeab Martina Krasteva 2021-05-27  202  	struct v4l2_ctrl *hblank_ctrl;
45d19b5fb9aeab Martina Krasteva 2021-05-27  203  	struct v4l2_ctrl *vblank_ctrl;
45d19b5fb9aeab Martina Krasteva 2021-05-27  204  	struct {
45d19b5fb9aeab Martina Krasteva 2021-05-27  205  		struct v4l2_ctrl *exp_ctrl;
45d19b5fb9aeab Martina Krasteva 2021-05-27  206  		struct v4l2_ctrl *again_ctrl;
45d19b5fb9aeab Martina Krasteva 2021-05-27  207  	};
45d19b5fb9aeab Martina Krasteva 2021-05-27  208  	u32 vblank;
8c48b2175e7d73 Kieran Bingham   2024-03-06  209  	u32 lane_mode;
45d19b5fb9aeab Martina Krasteva 2021-05-27  210  	const struct imx335_mode *cur_mode;
45d19b5fb9aeab Martina Krasteva 2021-05-27  211  	struct mutex mutex;
0862582b5239a6 Umang Jain       2024-02-20  212  	unsigned long link_freq_bitmap;
cfa49ff0558a32 Umang Jain       2023-12-11  213  	u32 cur_mbus_code;
45d19b5fb9aeab Martina Krasteva 2021-05-27 @214  };
45d19b5fb9aeab Martina Krasteva 2021-05-27  215  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki