Re: [PATCH v1 4/4] virt: vmgenid: add support for devicetree bindings

From: kernel test robot <lkp@intel.com>
To: Sudan Landge <sudanl@amazon.com>,
	tytso@mit.edu, Jason@zx2c4.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	sathyanarayanan.kuppuswamy@linux.intel.com,
	thomas.lendacky@amd.com, dan.j.williams@intel.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, graf@amazon.de, dwmw@amazon.co.uk,
	bchalios@amazon.es, xmarcalx@amazon.co.uk
Subject: Re: [PATCH v1 4/4] virt: vmgenid: add support for devicetree bindings
Date: Wed, 20 Mar 2024 21:35:28 +0800	[thread overview]
Message-ID: <202403202139.GabdWRiZ-lkp@intel.com> (raw)
In-Reply-To: <20240319143253.22317-5-sudanl@amazon.com>

Hi Sudan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.8 next-20240320]
[cannot apply to crng-random/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sudan-Landge/virt-vmgenid-rearrange-code-to-make-review-easier/20240319-223642
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20240319143253.22317-5-sudanl%40amazon.com
patch subject: [PATCH v1 4/4] virt: vmgenid: add support for devicetree bindings
config: x86_64-randconfig-121-20240320 (https://download.01.org/0day-ci/archive/20240320/202403202139.GabdWRiZ-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240320/202403202139.GabdWRiZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403202139.GabdWRiZ-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/virt/vmgenid.c:133:50: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected unsigned char [usertype] *next_id @@     got void [noderef] __iomem * @@
   drivers/virt/vmgenid.c:133:50: sparse:     expected unsigned char [usertype] *next_id
   drivers/virt/vmgenid.c:133:50: sparse:     got void [noderef] __iomem *

vim +133 drivers/virt/vmgenid.c

   114	
   115	static int vmgenid_add_of(struct device *dev, struct vmgenid_state *state)
   116	{
   117		struct resource res;
   118		int ret = 0;
   119	
   120		if (of_address_to_resource(dev->of_node, 0, &res)) {
   121			dev_err(dev, "Failed to get resources from device tree");
   122			ret = -EINVAL;
   123			goto out;
   124		}
   125	
   126		if (!__request_mem_region(res.start, resource_size(&res),
   127					  "vmgenid", IORESOURCE_EXCLUSIVE)) {
   128			dev_err(dev, "Failed to request mem region");
   129			ret = -EINVAL;
   130			goto out;
   131		}
   132	
 > 133		ret = setup_vmgenid_state(state, of_iomap(dev->of_node, 0));
   134		if (ret)
   135			goto out;
   136	
   137		state->irq = irq_of_parse_and_map(dev->of_node, 0);
   138		dev->driver_data = state;
   139	
   140		if (request_irq(state->irq, vmgenid_of_irq_handler,
   141				IRQF_SHARED, "vmgenid", dev) < 0) {
   142			dev_err(dev, "request_irq failed");
   143			dev->driver_data = NULL;
   144			ret = -EINVAL;
   145			goto out;
   146		}
   147	
   148	out:
   149		return ret;
   150	}
   151	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki