* Re: [PATCH v3 4/4] virt: vmgenid: add support for devicetree bindings
[not found] <20240325195306.13133-5-sudanl@amazon.com>
@ 2024-03-26 12:48 ` kernel test robot
2024-03-26 12:53 ` Krzysztof Kozlowski
2024-03-26 15:24 ` kernel test robot
2024-03-26 16:46 ` kernel test robot
2 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2024-03-26 12:48 UTC (permalink / raw)
To: Sudan Landge, tytso, Jason, robh+dt, krzysztof.kozlowski+dt,
conor+dt, sathyanarayanan.kuppuswamy, thomas.lendacky,
dan.j.williams, devicetree, linux-kernel
Cc: oe-kbuild-all, graf, dwmw, bchalios, xmarcalx
Hi Sudan,
kernel test robot noticed the following build errors:
[auto build test ERROR on 8e938e39866920ddc266898e6ae1fffc5c8f51aa]
url: https://github.com/intel-lab-lkp/linux/commits/Sudan-Landge/virt-vmgenid-rearrange-code-to-make-review-easier/20240326-035657
base: 8e938e39866920ddc266898e6ae1fffc5c8f51aa
patch link: https://lore.kernel.org/r/20240325195306.13133-5-sudanl%40amazon.com
patch subject: [PATCH v3 4/4] virt: vmgenid: add support for devicetree bindings
config: x86_64-rhel-8.3-bpf (https://download.01.org/0day-ci/archive/20240326/202403262047.aZVjmDY5-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240326/202403262047.aZVjmDY5-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403262047.aZVjmDY5-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/virt/vmgenid.c: In function 'vmgenid_add_of':
>> drivers/virt/vmgenid.c:154:15: error: 'dev' undeclared (first use in this function); did you mean 'pdev'?
154 | (void)dev;
| ^~~
| pdev
drivers/virt/vmgenid.c:154:15: note: each undeclared identifier is reported only once for each function it appears in
vim +154 drivers/virt/vmgenid.c
121
122 static int vmgenid_add_of(struct platform_device *pdev, struct vmgenid_state *state)
123 {
124 #if IS_ENABLED(CONFIG_OF)
125 void __iomem *remapped_ptr;
126 int ret = 0;
127
128 remapped_ptr = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
129 if (IS_ERR(remapped_ptr)) {
130 ret = PTR_ERR(remapped_ptr);
131 goto out;
132 }
133
134 ret = setup_vmgenid_state(state, remapped_ptr);
135 if (ret)
136 goto out;
137
138 state->irq = platform_get_irq(pdev, 0);
139 if (state->irq < 0) {
140 ret = state->irq;
141 goto out;
142 }
143 pdev->dev.driver_data = state;
144
145 ret = devm_request_irq(&pdev->dev, state->irq,
146 vmgenid_of_irq_handler,
147 IRQF_SHARED, "vmgenid", &pdev->dev);
148 if (ret)
149 pdev->dev.driver_data = NULL;
150
151 out:
152 return ret;
153 #else
> 154 (void)dev;
155 (void)state;
156 return -EINVAL;
157 #endif
158 }
159
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3 4/4] virt: vmgenid: add support for devicetree bindings
2024-03-26 12:48 ` [PATCH v3 4/4] virt: vmgenid: add support for devicetree bindings kernel test robot
@ 2024-03-26 12:53 ` Krzysztof Kozlowski
2024-03-26 14:05 ` Landge, Sudan
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-26 12:53 UTC (permalink / raw)
To: kernel test robot, Sudan Landge, tytso, Jason, robh+dt,
krzysztof.kozlowski+dt, conor+dt, sathyanarayanan.kuppuswamy,
thomas.lendacky, dan.j.williams, devicetree, linux-kernel
Cc: oe-kbuild-all, graf, dwmw, bchalios, xmarcalx
On 26/03/2024 13:48, kernel test robot wrote:
> Hi Sudan,
>
> kernel test robot noticed the following build errors:
...
> 134 ret = setup_vmgenid_state(state, remapped_ptr);
> 135 if (ret)
> 136 goto out;
> 137
> 138 state->irq = platform_get_irq(pdev, 0);
> 139 if (state->irq < 0) {
> 140 ret = state->irq;
> 141 goto out;
> 142 }
> 143 pdev->dev.driver_data = state;
> 144
> 145 ret = devm_request_irq(&pdev->dev, state->irq,
> 146 vmgenid_of_irq_handler,
> 147 IRQF_SHARED, "vmgenid", &pdev->dev);
> 148 if (ret)
> 149 pdev->dev.driver_data = NULL;
> 150
> 151 out:
> 152 return ret;
> 153 #else
> > 154 (void)dev;
So this code was not even built...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3 4/4] virt: vmgenid: add support for devicetree bindings
2024-03-26 12:53 ` Krzysztof Kozlowski
@ 2024-03-26 14:05 ` Landge, Sudan
0 siblings, 0 replies; 5+ messages in thread
From: Landge, Sudan @ 2024-03-26 14:05 UTC (permalink / raw)
To: Krzysztof Kozlowski, kernel test robot, Sudan Landge, tytso,
Jason, robh+dt, krzysztof.kozlowski+dt, conor+dt,
sathyanarayanan.kuppuswamy, thomas.lendacky, dan.j.williams,
devicetree, linux-kernel
Cc: oe-kbuild-all, graf, dwmw, bchalios, xmarcalx
On 26/03/2024 12:53, Krzysztof Kozlowski wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
> On 26/03/2024 13:48, kernel test robot wrote:
>> Hi Sudan,
>>
>> kernel test robot noticed the following build errors:
>
> ...
>
>> 134 ret = setup_vmgenid_state(state, remapped_ptr);
>> 135 if (ret)
>> 136 goto out;
>> 137
>> 138 state->irq = platform_get_irq(pdev, 0);
>> 139 if (state->irq < 0) {
>> 140 ret = state->irq;
>> 141 goto out;
>> 142 }
>> 143 pdev->dev.driver_data = state;
>> 144
>> 145 ret = devm_request_irq(&pdev->dev, state->irq,
>> 146 vmgenid_of_irq_handler,
>> 147 IRQF_SHARED, "vmgenid", &pdev->dev);
>> 148 if (ret)
>> 149 pdev->dev.driver_data = NULL;
>> 150
>> 151 out:
>> 152 return ret;
>> 153 #else
>> > 154 (void)dev;
>
> So this code was not even built...
>
> Best regards,
> Krzysztof
>
I built it with CONFIG_ACPI and CONFIG_OF enabled but missed to build it
without the CONFIG_OF flag. As mentioned in the other mail I'll make
sure to run all required tools and check for all combinations before
posting future patches.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 4/4] virt: vmgenid: add support for devicetree bindings
[not found] <20240325195306.13133-5-sudanl@amazon.com>
2024-03-26 12:48 ` [PATCH v3 4/4] virt: vmgenid: add support for devicetree bindings kernel test robot
@ 2024-03-26 15:24 ` kernel test robot
2024-03-26 16:46 ` kernel test robot
2 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2024-03-26 15:24 UTC (permalink / raw)
To: Sudan Landge, tytso, Jason, robh+dt, krzysztof.kozlowski+dt,
conor+dt, sathyanarayanan.kuppuswamy, thomas.lendacky,
dan.j.williams, devicetree, linux-kernel
Cc: oe-kbuild-all, graf, dwmw, bchalios, xmarcalx
Hi Sudan,
kernel test robot noticed the following build errors:
[auto build test ERROR on 8e938e39866920ddc266898e6ae1fffc5c8f51aa]
url: https://github.com/intel-lab-lkp/linux/commits/Sudan-Landge/virt-vmgenid-rearrange-code-to-make-review-easier/20240326-035657
base: 8e938e39866920ddc266898e6ae1fffc5c8f51aa
patch link: https://lore.kernel.org/r/20240325195306.13133-5-sudanl%40amazon.com
patch subject: [PATCH v3 4/4] virt: vmgenid: add support for devicetree bindings
config: x86_64-randconfig-161-20240326 (https://download.01.org/0day-ci/archive/20240326/202403262327.ZwiqykRF-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240326/202403262327.ZwiqykRF-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403262327.ZwiqykRF-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/virt/vmgenid.c:154:8: error: use of undeclared identifier 'dev'
154 | (void)dev;
| ^
1 error generated.
vim +/dev +154 drivers/virt/vmgenid.c
121
122 static int vmgenid_add_of(struct platform_device *pdev, struct vmgenid_state *state)
123 {
124 #if IS_ENABLED(CONFIG_OF)
125 void __iomem *remapped_ptr;
126 int ret = 0;
127
128 remapped_ptr = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
129 if (IS_ERR(remapped_ptr)) {
130 ret = PTR_ERR(remapped_ptr);
131 goto out;
132 }
133
134 ret = setup_vmgenid_state(state, remapped_ptr);
135 if (ret)
136 goto out;
137
138 state->irq = platform_get_irq(pdev, 0);
139 if (state->irq < 0) {
140 ret = state->irq;
141 goto out;
142 }
143 pdev->dev.driver_data = state;
144
145 ret = devm_request_irq(&pdev->dev, state->irq,
146 vmgenid_of_irq_handler,
147 IRQF_SHARED, "vmgenid", &pdev->dev);
148 if (ret)
149 pdev->dev.driver_data = NULL;
150
151 out:
152 return ret;
153 #else
> 154 (void)dev;
155 (void)state;
156 return -EINVAL;
157 #endif
158 }
159
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3 4/4] virt: vmgenid: add support for devicetree bindings
[not found] <20240325195306.13133-5-sudanl@amazon.com>
2024-03-26 12:48 ` [PATCH v3 4/4] virt: vmgenid: add support for devicetree bindings kernel test robot
2024-03-26 15:24 ` kernel test robot
@ 2024-03-26 16:46 ` kernel test robot
2 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2024-03-26 16:46 UTC (permalink / raw)
To: Sudan Landge, tytso, Jason, robh+dt, krzysztof.kozlowski+dt,
conor+dt, sathyanarayanan.kuppuswamy, thomas.lendacky,
dan.j.williams, devicetree, linux-kernel
Cc: oe-kbuild-all, graf, dwmw, bchalios, xmarcalx
Hi Sudan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 8e938e39866920ddc266898e6ae1fffc5c8f51aa]
url: https://github.com/intel-lab-lkp/linux/commits/Sudan-Landge/virt-vmgenid-rearrange-code-to-make-review-easier/20240326-035657
base: 8e938e39866920ddc266898e6ae1fffc5c8f51aa
patch link: https://lore.kernel.org/r/20240325195306.13133-5-sudanl%40amazon.com
patch subject: [PATCH v3 4/4] virt: vmgenid: add support for devicetree bindings
config: x86_64-buildonly-randconfig-004-20240326 (https://download.01.org/0day-ci/archive/20240327/202403270050.wJ0Hd5aB-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240327/202403270050.wJ0Hd5aB-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403270050.wJ0Hd5aB-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/virt/vmgenid.c: In function 'vmgenid_add_of':
drivers/virt/vmgenid.c:154:15: error: 'dev' undeclared (first use in this function); did you mean 'pdev'?
154 | (void)dev;
| ^~~
| pdev
drivers/virt/vmgenid.c:154:15: note: each undeclared identifier is reported only once for each function it appears in
drivers/virt/vmgenid.c: At top level:
>> drivers/virt/vmgenid.c:60:12: warning: 'setup_vmgenid_state' defined but not used [-Wunused-function]
60 | static int setup_vmgenid_state(struct vmgenid_state *state, u8 *next_id)
| ^~~~~~~~~~~~~~~~~~~
>> drivers/virt/vmgenid.c:27:13: warning: 'vmgenid_notify' defined but not used [-Wunused-function]
27 | static void vmgenid_notify(struct device *device)
| ^~~~~~~~~~~~~~
vim +/setup_vmgenid_state +60 drivers/virt/vmgenid.c
af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 26
fba2c3554a30ca Sudan Landge 2024-03-25 @27 static void vmgenid_notify(struct device *device)
5eb78dfcd888d3 Sudan Landge 2024-03-25 28 {
fba2c3554a30ca Sudan Landge 2024-03-25 29 struct vmgenid_state *state = device->driver_data;
5eb78dfcd888d3 Sudan Landge 2024-03-25 30 char *envp[] = { "NEW_VMGENID=1", NULL };
5eb78dfcd888d3 Sudan Landge 2024-03-25 31 u8 old_id[VMGENID_SIZE];
5eb78dfcd888d3 Sudan Landge 2024-03-25 32
5eb78dfcd888d3 Sudan Landge 2024-03-25 33 memcpy(old_id, state->this_id, sizeof(old_id));
5eb78dfcd888d3 Sudan Landge 2024-03-25 34 memcpy(state->this_id, state->next_id, sizeof(state->this_id));
5eb78dfcd888d3 Sudan Landge 2024-03-25 35 if (!memcmp(old_id, state->this_id, sizeof(old_id)))
5eb78dfcd888d3 Sudan Landge 2024-03-25 36 return;
5eb78dfcd888d3 Sudan Landge 2024-03-25 37 add_vmfork_randomness(state->this_id, sizeof(state->this_id));
fba2c3554a30ca Sudan Landge 2024-03-25 38 kobject_uevent_env(&device->kobj, KOBJ_CHANGE, envp);
5eb78dfcd888d3 Sudan Landge 2024-03-25 39 }
5eb78dfcd888d3 Sudan Landge 2024-03-25 40
84d2b6732ae89f Sudan Landge 2024-03-25 41 #if IS_ENABLED(CONFIG_ACPI)
fba2c3554a30ca Sudan Landge 2024-03-25 42 static void vmgenid_acpi_handler(acpi_handle handle, u32 event, void *dev)
af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 43 {
84d2b6732ae89f Sudan Landge 2024-03-25 44 (void)handle;
84d2b6732ae89f Sudan Landge 2024-03-25 45 (void)event;
fba2c3554a30ca Sudan Landge 2024-03-25 46 vmgenid_notify(dev);
fba2c3554a30ca Sudan Landge 2024-03-25 47 }
84d2b6732ae89f Sudan Landge 2024-03-25 48 #endif
84d2b6732ae89f Sudan Landge 2024-03-25 49
84d2b6732ae89f Sudan Landge 2024-03-25 50 #if IS_ENABLED(CONFIG_OF)
84d2b6732ae89f Sudan Landge 2024-03-25 51 static irqreturn_t vmgenid_of_irq_handler(int irq, void *dev)
84d2b6732ae89f Sudan Landge 2024-03-25 52 {
84d2b6732ae89f Sudan Landge 2024-03-25 53 (void)irq;
84d2b6732ae89f Sudan Landge 2024-03-25 54 vmgenid_notify(dev);
84d2b6732ae89f Sudan Landge 2024-03-25 55
84d2b6732ae89f Sudan Landge 2024-03-25 56 return IRQ_HANDLED;
84d2b6732ae89f Sudan Landge 2024-03-25 57 }
84d2b6732ae89f Sudan Landge 2024-03-25 58 #endif
fba2c3554a30ca Sudan Landge 2024-03-25 59
fba2c3554a30ca Sudan Landge 2024-03-25 @60 static int setup_vmgenid_state(struct vmgenid_state *state, u8 *next_id)
fba2c3554a30ca Sudan Landge 2024-03-25 61 {
fba2c3554a30ca Sudan Landge 2024-03-25 62 if (IS_ERR(next_id))
fba2c3554a30ca Sudan Landge 2024-03-25 63 return PTR_ERR(next_id);
fba2c3554a30ca Sudan Landge 2024-03-25 64
fba2c3554a30ca Sudan Landge 2024-03-25 65 state->next_id = next_id;
fba2c3554a30ca Sudan Landge 2024-03-25 66 memcpy(state->this_id, state->next_id, sizeof(state->this_id));
fba2c3554a30ca Sudan Landge 2024-03-25 67 add_device_randomness(state->this_id, sizeof(state->this_id));
fba2c3554a30ca Sudan Landge 2024-03-25 68 return 0;
fba2c3554a30ca Sudan Landge 2024-03-25 69 }
fba2c3554a30ca Sudan Landge 2024-03-25 70
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread