From: kernel test robot <lkp@intel.com>
To: parker@finest.io, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH 2/2] serial: exar: adding CTI PCI/PCIe serial port support to 8250_exar
Date: Fri, 12 Apr 2024 12:53:22 +0800 [thread overview]
Message-ID: <202404121251.hu0SvXG8-lkp@intel.com> (raw)
In-Reply-To: <9ffdef053f455c87f705dff169346bc10d307787.1712846026.git.pnewman@connecttech.com>
Hi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tty/tty-testing]
[also build test WARNING on tty/tty-next tty/tty-linus usb/usb-testing usb/usb-next usb/usb-linus pci/next pci/for-linus linus/master v6.9-rc3 next-20240411]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/parker-finest-io/serial-exar-add-missing-CTI-Exar-PCI-IDs-to-include-linux-pci_ids-h/20240412-011902
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link: https://lore.kernel.org/r/9ffdef053f455c87f705dff169346bc10d307787.1712846026.git.pnewman%40connecttech.com
patch subject: [PATCH 2/2] serial: exar: adding CTI PCI/PCIe serial port support to 8250_exar
config: parisc-defconfig (https://download.01.org/0day-ci/archive/20240412/202404121251.hu0SvXG8-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240412/202404121251.hu0SvXG8-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404121251.hu0SvXG8-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/tty/serial/8250/8250_exar.c:672: warning: Function parameter or struct member 'eeprom_offset' not described in 'cti_read_osc_freq'
vim +672 drivers/tty/serial/8250/8250_exar.c
661
662 /**
663 * cti_read_osc_freq() - Read the UART oscillator frequency from EEPROM
664 * @priv: Device's private structure
665 *
666 * CTI XR17x15X and XR17V25X cards have the serial boards oscillator frequency
667 * stored in the EEPROM. FPGA and XR17V35X based cards use the PCI/PCIe clock.
668 *
669 * Return: frequency on success, negative error code on failure
670 */
671 static int cti_read_osc_freq(struct exar8250 *priv, uint8_t eeprom_offset)
> 672 {
673 int osc_freq;
674
675 if (!priv)
676 return -EINVAL;
677
678 osc_freq = (exar_ee_read(priv, eeprom_offset));
679 osc_freq |= (exar_ee_read(priv, (eeprom_offset + 1)) << 16);
680
681 //check if EEPROM word was blank
682 if ((osc_freq == 0xFFFF) || (osc_freq == 0x0000))
683 return -EIO;
684
685 pci_dbg(priv->pcidev, "osc_freq from EEPROM %d\n", osc_freq);
686
687 return osc_freq;
688 }
689
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next parent reply other threads:[~2024-04-12 4:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9ffdef053f455c87f705dff169346bc10d307787.1712846026.git.pnewman@connecttech.com>
2024-04-12 4:53 ` kernel test robot [this message]
2024-04-12 5:17 ` [PATCH 2/2] serial: exar: adding CTI PCI/PCIe serial port support to 8250_exar kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202404121251.hu0SvXG8-lkp@intel.com \
--to=lkp@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=parker@finest.io \
--cc=pnewman@connecttech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).