Re: [PATCH v5 2/3] i2c: designware: Use PCI PSP driver for communication

Re: [PATCH v5 2/3] i2c: designware: Use PCI PSP driver for communication

[kernel test robot]

Hi Mario,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on e6af5c0c4d32a27e04a56f29aad587e03ff427f1]

url:    https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/crypto-ccp-Bump-up-doorbell-debug-messages-to-error/20230322-053048
base:   e6af5c0c4d32a27e04a56f29aad587e03ff427f1
patch link:    https://lore.kernel.org/r/20230321212822.5714-3-mario.limonciello%40amd.com
patch subject: [PATCH v5 2/3] i2c: designware: Use PCI PSP driver for communication
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20230322/202303221157.58L3rUhr-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/0ddf14b7f34bfe410e49c800d855f4e0c59d6bef
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Mario-Limonciello/crypto-ccp-Bump-up-doorbell-debug-messages-to-error/20230322-053048
        git checkout 0ddf14b7f34bfe410e49c800d855f4e0c59d6bef
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash drivers/i2c/busses/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303221157.58L3rUhr-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/i2c/busses/i2c-designware-amdpsp.c:8:10: fatal error: asm/msr.h: No such file or directory
       8 | #include <asm/msr.h>
         |          ^~~~~~~~~~~
   compilation terminated.


vim +8 drivers/i2c/busses/i2c-designware-amdpsp.c

78d5e9e299e31b Jan Dabros 2022-02-08  7  
78d5e9e299e31b Jan Dabros 2022-02-08 @8  #include <asm/msr.h>
78d5e9e299e31b Jan Dabros 2022-02-08  9  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

Re: [PATCH v5 2/3] i2c: designware: Use PCI PSP driver for communication

[Andy Shevchenko]

On Wed, Mar 22, 2023 at 11:26:01AM +0800, kernel test robot wrote:

...

> All errors (new ones prefixed by >>):
> 
> >> drivers/i2c/busses/i2c-designware-amdpsp.c:8:10: fatal error: asm/msr.h: No such file or directory
>        8 | #include <asm/msr.h>
>          |          ^~~~~~~~~~~
>    compilation terminated.

Should be under "#ifdef CONFIG_X86" (IIRC).

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v5 2/3] i2c: designware: Use PCI PSP driver for communication

[Mario Limonciello]

On 3/22/23 04:45, Andy Shevchenko wrote:
> On Wed, Mar 22, 2023 at 11:26:01AM +0800, kernel test robot wrote:
>
> ...
>
>> All errors (new ones prefixed by >>):
>>
>>>> drivers/i2c/busses/i2c-designware-amdpsp.c:8:10: fatal error: asm/msr.h: No such file or directory
>>         8 | #include <asm/msr.h>
>>           |          ^~~~~~~~~~~
>>     compilation terminated.
> Should be under "#ifdef CONFIG_X86" (IIRC).
>
Actually the header isn't needed anymore with these changes.

I'll drop it in the next version of the series once I have some updated 
results from Grzegorz and Jan.