* Re: [PATCH v1 net-next 5/6] arp: Get dev after calling arp_req_(delete|set|get)().
[not found] <20240422194755.4221-6-kuniyu@amazon.com>
@ 2024-04-25 5:32 ` Dan Carpenter
2024-04-25 16:26 ` Kuniyuki Iwashima
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2024-04-25 5:32 UTC (permalink / raw)
To: oe-kbuild, Kuniyuki Iwashima, David S. Miller, David Ahern,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: lkp, oe-kbuild-all, netdev, Kuniyuki Iwashima
Hi Kuniyuki,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/arp-Move-ATF_COM-setting-in-arp_req_set/20240423-035458
base: net-next/main
patch link: https://lore.kernel.org/r/20240422194755.4221-6-kuniyu%40amazon.com
patch subject: [PATCH v1 net-next 5/6] arp: Get dev after calling arp_req_(delete|set|get)().
config: i386-randconfig-141-20240424 (https://download.01.org/0day-ci/archive/20240425/202404251215.QHgck00A-lkp@intel.com/config)
compiler: gcc-10 (Ubuntu 10.5.0-1ubuntu1) 10.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202404251215.QHgck00A-lkp@intel.com/
smatch warnings:
net/ipv4/arp.c:1242 arp_req_delete() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +1242 net/ipv4/arp.c
8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1235 static int arp_req_delete(struct net *net, struct arpreq *r)
46479b432989d6 Pavel Emelyanov 2007-12-05 1236 {
8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1237 struct net_device *dev;
46479b432989d6 Pavel Emelyanov 2007-12-05 1238 __be32 ip;
46479b432989d6 Pavel Emelyanov 2007-12-05 1239
8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1240 dev = arp_req_dev(net, r);
8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1241 if (!IS_ERR(dev))
The ! is not supposed to be there.
8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 @1242 return PTR_ERR(dev);
8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1243
46479b432989d6 Pavel Emelyanov 2007-12-05 1244 if (r->arp_flags & ATF_PUBL)
32e569b7277f13 Pavel Emelyanov 2007-12-16 1245 return arp_req_delete_public(net, r, dev);
46479b432989d6 Pavel Emelyanov 2007-12-05 1246
46479b432989d6 Pavel Emelyanov 2007-12-05 1247 ip = ((struct sockaddr_in *)&r->arp_pa)->sin_addr.s_addr;
8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1248
0c51e12e218f20 Ido Schimmel 2022-02-19 1249 return arp_invalidate(dev, ip, true);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1250 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 net-next 5/6] arp: Get dev after calling arp_req_(delete|set|get)().
2024-04-25 5:32 ` [PATCH v1 net-next 5/6] arp: Get dev after calling arp_req_(delete|set|get)() Dan Carpenter
@ 2024-04-25 16:26 ` Kuniyuki Iwashima
0 siblings, 0 replies; 3+ messages in thread
From: Kuniyuki Iwashima @ 2024-04-25 16:26 UTC (permalink / raw)
To: dan.carpenter
Cc: davem, dsahern, edumazet, kuba, kuniyu, lkp, netdev,
oe-kbuild-all, oe-kbuild, pabeni
From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Thu, 25 Apr 2024 08:32:22 +0300
> Hi Kuniyuki,
>
> kernel test robot noticed the following build warnings:
>
> url: https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/arp-Move-ATF_COM-setting-in-arp_req_set/20240423-035458
> base: net-next/main
> patch link: https://lore.kernel.org/r/20240422194755.4221-6-kuniyu%40amazon.com
> patch subject: [PATCH v1 net-next 5/6] arp: Get dev after calling arp_req_(delete|set|get)().
> config: i386-randconfig-141-20240424 (https://download.01.org/0day-ci/archive/20240425/202404251215.QHgck00A-lkp@intel.com/config)
> compiler: gcc-10 (Ubuntu 10.5.0-1ubuntu1) 10.5.0
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> | Closes: https://lore.kernel.org/r/202404251215.QHgck00A-lkp@intel.com/
>
> smatch warnings:
> net/ipv4/arp.c:1242 arp_req_delete() warn: passing zero to 'PTR_ERR'
>
> vim +/PTR_ERR +1242 net/ipv4/arp.c
>
> 8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1235 static int arp_req_delete(struct net *net, struct arpreq *r)
> 46479b432989d6 Pavel Emelyanov 2007-12-05 1236 {
> 8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1237 struct net_device *dev;
> 46479b432989d6 Pavel Emelyanov 2007-12-05 1238 __be32 ip;
> 46479b432989d6 Pavel Emelyanov 2007-12-05 1239
> 8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1240 dev = arp_req_dev(net, r);
> 8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1241 if (!IS_ERR(dev))
>
> The ! is not supposed to be there.
Oh, I don't know why I added it :S
Will fix it, thank you!
>
> 8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 @1242 return PTR_ERR(dev);
> 8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1243
> 46479b432989d6 Pavel Emelyanov 2007-12-05 1244 if (r->arp_flags & ATF_PUBL)
> 32e569b7277f13 Pavel Emelyanov 2007-12-16 1245 return arp_req_delete_public(net, r, dev);
> 46479b432989d6 Pavel Emelyanov 2007-12-05 1246
> 46479b432989d6 Pavel Emelyanov 2007-12-05 1247 ip = ((struct sockaddr_in *)&r->arp_pa)->sin_addr.s_addr;
> 8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1248
> 0c51e12e218f20 Ido Schimmel 2022-02-19 1249 return arp_invalidate(dev, ip, true);
> ^1da177e4c3f41 Linus Torvalds 2005-04-16 1250 }
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 net-next 5/6] arp: Get dev after calling arp_req_(delete|set|get)().
@ 2024-04-25 4:26 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2024-04-25 4:26 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240422194755.4221-6-kuniyu@amazon.com>
References: <20240422194755.4221-6-kuniyu@amazon.com>
TO: Kuniyuki Iwashima <kuniyu@amazon.com>
TO: "David S. Miller" <davem@davemloft.net>
CC: netdev@vger.kernel.org
TO: David Ahern <dsahern@kernel.org>
TO: Eric Dumazet <edumazet@google.com>
TO: Jakub Kicinski <kuba@kernel.org>
TO: Paolo Abeni <pabeni@redhat.com>
CC: Kuniyuki Iwashima <kuniyu@amazon.com>
Hi Kuniyuki,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/arp-Move-ATF_COM-setting-in-arp_req_set/20240423-035458
base: net-next/main
patch link: https://lore.kernel.org/r/20240422194755.4221-6-kuniyu%40amazon.com
patch subject: [PATCH v1 net-next 5/6] arp: Get dev after calling arp_req_(delete|set|get)().
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: i386-randconfig-141-20240424 (https://download.01.org/0day-ci/archive/20240425/202404251215.QHgck00A-lkp@intel.com/config)
compiler: gcc-10 (Ubuntu 10.5.0-1ubuntu1) 10.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202404251215.QHgck00A-lkp@intel.com/
smatch warnings:
net/ipv4/arp.c:1242 arp_req_delete() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +1242 net/ipv4/arp.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 1234
8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1235 static int arp_req_delete(struct net *net, struct arpreq *r)
46479b432989d6 Pavel Emelyanov 2007-12-05 1236 {
8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1237 struct net_device *dev;
46479b432989d6 Pavel Emelyanov 2007-12-05 1238 __be32 ip;
46479b432989d6 Pavel Emelyanov 2007-12-05 1239
8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1240 dev = arp_req_dev(net, r);
8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1241 if (!IS_ERR(dev))
8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 @1242 return PTR_ERR(dev);
8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1243
46479b432989d6 Pavel Emelyanov 2007-12-05 1244 if (r->arp_flags & ATF_PUBL)
32e569b7277f13 Pavel Emelyanov 2007-12-16 1245 return arp_req_delete_public(net, r, dev);
46479b432989d6 Pavel Emelyanov 2007-12-05 1246
46479b432989d6 Pavel Emelyanov 2007-12-05 1247 ip = ((struct sockaddr_in *)&r->arp_pa)->sin_addr.s_addr;
8f4429edb1b716 Kuniyuki Iwashima 2024-04-22 1248
0c51e12e218f20 Ido Schimmel 2022-02-19 1249 return arp_invalidate(dev, ip, true);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1250 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1251
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-25 16:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20240422194755.4221-6-kuniyu@amazon.com>
2024-04-25 5:32 ` [PATCH v1 net-next 5/6] arp: Get dev after calling arp_req_(delete|set|get)() Dan Carpenter
2024-04-25 16:26 ` Kuniyuki Iwashima
2024-04-25 4:26 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).