oe-kbuild.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [jirislaby:devel 33/40] drivers/tty/mxser.c:513 mxser_set_baud() error: uninitialized symbol 'baud'.
@ 2024-04-10 22:53 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-04-10 22:53 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git devel
head:   a56ff0cb0fd0fd59f4a9a12091951ae80f866abb
commit: fb7c4d96c47896d2d8db670f34bb961a66ea869a [33/40] mxser: use timeout from uart_port
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: x86_64-randconfig-161-20240411 (https://download.01.org/0day-ci/archive/20240411/202404110644.9Hya2zB1-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202404110644.9Hya2zB1-lkp@intel.com/

smatch warnings:
drivers/tty/mxser.c:513 mxser_set_baud() error: uninitialized symbol 'baud'.

vim +/baud +513 drivers/tty/mxser.c

5d951fb458f847 drivers/char/mxser.c Alan Cox          2009-01-02  489  
ded0799af88cdc drivers/tty/mxser.c  Jiri Slaby        2021-12-01  490  static int mxser_set_baud(struct mxser_port *info, struct ktermios *termios)
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  491  {
2a92b0c951630a drivers/tty/mxser.c  Jiri Slaby (SUSE  2023-04-24  492) 	struct uart_port *uport = &info->uport;
104583b504da8a drivers/tty/mxser.c  Jiri Slaby        2017-09-12  493  	unsigned int quot = 0, baud;
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  494  	unsigned char cval;
ded0799af88cdc drivers/tty/mxser.c  Jiri Slaby        2021-12-01  495  	speed_t newspd = tty_termios_baud_rate(termios);
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  496  
928f946426905d drivers/tty/mxser.c  Jiri Slaby        2021-06-18  497  	if (newspd > info->board->max_baud)
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  498  		return -1;
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  499  
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  500  	if (newspd == 134) {
a6970c39c311f3 drivers/tty/mxser.c  Jiri Slaby        2021-06-18  501  		quot = 2 * MXSER_BAUD_BASE / 269;
ded0799af88cdc drivers/tty/mxser.c  Jiri Slaby        2021-12-01  502  		tty_termios_encode_baud_rate(termios, 134, 134);
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  503  	} else if (newspd) {
a6970c39c311f3 drivers/tty/mxser.c  Jiri Slaby        2021-06-18  504  		quot = MXSER_BAUD_BASE / newspd;
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  505  		if (quot == 0)
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  506  			quot = 1;
a6970c39c311f3 drivers/tty/mxser.c  Jiri Slaby        2021-06-18  507  		baud = MXSER_BAUD_BASE / quot;
ded0799af88cdc drivers/tty/mxser.c  Jiri Slaby        2021-12-01  508  		tty_termios_encode_baud_rate(termios, baud, baud);
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  509  	} else {
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  510  		quot = 0;
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  511  	}
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  512  
fb7c4d96c47896 drivers/tty/mxser.c  Jiri Slaby (SUSE  2022-11-15 @513) 	uart_update_timeout(uport, termios->c_cflag, baud);
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  514  
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  515  	if (quot) {
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  516  		info->MCR |= UART_MCR_DTR;
2a92b0c951630a drivers/tty/mxser.c  Jiri Slaby (SUSE  2023-04-24  517) 		outb(info->MCR, uport->iobase + UART_MCR);
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  518  	} else {
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  519  		info->MCR &= ~UART_MCR_DTR;
2a92b0c951630a drivers/tty/mxser.c  Jiri Slaby (SUSE  2023-04-24  520) 		outb(info->MCR, uport->iobase + UART_MCR);
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  521  		return 0;
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  522  	}
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  523  
2a92b0c951630a drivers/tty/mxser.c  Jiri Slaby (SUSE  2023-04-24  524) 	cval = inb(uport->iobase + UART_LCR);
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  525  
2a92b0c951630a drivers/tty/mxser.c  Jiri Slaby (SUSE  2023-04-24  526) 	outb(cval | UART_LCR_DLAB, uport->iobase + UART_LCR);	/* set DLAB */
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  527  
2a92b0c951630a drivers/tty/mxser.c  Jiri Slaby (SUSE  2023-04-24  528) 	outb(quot & 0xff, uport->iobase + UART_DLL);	/* LS of divisor */
2a92b0c951630a drivers/tty/mxser.c  Jiri Slaby (SUSE  2023-04-24  529) 	outb(quot >> 8, uport->iobase + UART_DLM);	/* MS of divisor */
2a92b0c951630a drivers/tty/mxser.c  Jiri Slaby (SUSE  2023-04-24  530) 	outb(cval, uport->iobase + UART_LCR);	/* reset DLAB */
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  531  
ded0799af88cdc drivers/tty/mxser.c  Jiri Slaby        2021-12-01  532  	if ((termios->c_cflag & CBAUD) == BOTHER) {
a6970c39c311f3 drivers/tty/mxser.c  Jiri Slaby        2021-06-18  533  		quot = MXSER_BAUD_BASE % newspd;
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  534  		quot *= 8;
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  535  		if (quot % newspd > newspd / 2) {
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  536  			quot /= newspd;
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  537  			quot++;
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  538  		} else
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  539  			quot /= newspd;
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  540  
2a92b0c951630a drivers/tty/mxser.c  Jiri Slaby (SUSE  2023-04-24  541) 		mxser_set_must_enum_value(uport->iobase, quot);
69648d7bda8636 drivers/tty/mxser.c  Ilpo Järvinen     2022-05-13  542  	} else {
2a92b0c951630a drivers/tty/mxser.c  Jiri Slaby (SUSE  2023-04-24  543) 		mxser_set_must_enum_value(uport->iobase, 0);
69648d7bda8636 drivers/tty/mxser.c  Ilpo Järvinen     2022-05-13  544  	}
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  545  
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  546  	return 0;
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  547  }
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  548  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [jirislaby:devel 33/40] drivers/tty/mxser.c:513 mxser_set_baud() error: uninitialized symbol 'baud'.
@ 2024-04-11 10:13 Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2024-04-11 10:13 UTC (permalink / raw)
  To: oe-kbuild, Jiri Slaby (SUSE); +Cc: lkp, oe-kbuild-all

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git devel
head:   a56ff0cb0fd0fd59f4a9a12091951ae80f866abb
commit: fb7c4d96c47896d2d8db670f34bb961a66ea869a [33/40] mxser: use timeout from uart_port
config: x86_64-randconfig-161-20240411 (https://download.01.org/0day-ci/archive/20240411/202404110644.9Hya2zB1-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202404110644.9Hya2zB1-lkp@intel.com/

smatch warnings:
drivers/tty/mxser.c:513 mxser_set_baud() error: uninitialized symbol 'baud'.

vim +/baud +513 drivers/tty/mxser.c

ded0799af88cdc drivers/tty/mxser.c  Jiri Slaby        2021-12-01  490  static int mxser_set_baud(struct mxser_port *info, struct ktermios *termios)
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  491  {
2a92b0c951630a drivers/tty/mxser.c  Jiri Slaby (SUSE  2023-04-24  492) 	struct uart_port *uport = &info->uport;
104583b504da8a drivers/tty/mxser.c  Jiri Slaby        2017-09-12  493  	unsigned int quot = 0, baud;
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  494  	unsigned char cval;
ded0799af88cdc drivers/tty/mxser.c  Jiri Slaby        2021-12-01  495  	speed_t newspd = tty_termios_baud_rate(termios);
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  496  
928f946426905d drivers/tty/mxser.c  Jiri Slaby        2021-06-18  497  	if (newspd > info->board->max_baud)
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  498  		return -1;
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  499  
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  500  	if (newspd == 134) {
a6970c39c311f3 drivers/tty/mxser.c  Jiri Slaby        2021-06-18  501  		quot = 2 * MXSER_BAUD_BASE / 269;
ded0799af88cdc drivers/tty/mxser.c  Jiri Slaby        2021-12-01  502  		tty_termios_encode_baud_rate(termios, 134, 134);

baud is uninitialized here

1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  503  	} else if (newspd) {
a6970c39c311f3 drivers/tty/mxser.c  Jiri Slaby        2021-06-18  504  		quot = MXSER_BAUD_BASE / newspd;
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  505  		if (quot == 0)
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  506  			quot = 1;
a6970c39c311f3 drivers/tty/mxser.c  Jiri Slaby        2021-06-18  507  		baud = MXSER_BAUD_BASE / quot;
ded0799af88cdc drivers/tty/mxser.c  Jiri Slaby        2021-12-01  508  		tty_termios_encode_baud_rate(termios, baud, baud);
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  509  	} else {

baud not initialized here either

1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  510  		quot = 0;
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  511  	}
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  512  
fb7c4d96c47896 drivers/tty/mxser.c  Jiri Slaby (SUSE  2022-11-15 @513) 	uart_update_timeout(uport, termios->c_cflag, baud);
                                                                                                                     ^^^^
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds    2005-04-16  514  
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  515  	if (quot) {
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  516  		info->MCR |= UART_MCR_DTR;
2a92b0c951630a drivers/tty/mxser.c  Jiri Slaby (SUSE  2023-04-24  517) 		outb(info->MCR, uport->iobase + UART_MCR);
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  518  	} else {
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  519  		info->MCR &= ~UART_MCR_DTR;
2a92b0c951630a drivers/tty/mxser.c  Jiri Slaby (SUSE  2023-04-24  520) 		outb(info->MCR, uport->iobase + UART_MCR);
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  521  		return 0;
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby        2008-02-07  522  	}

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-11 10:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-10 22:53 [jirislaby:devel 33/40] drivers/tty/mxser.c:513 mxser_set_baud() error: uninitialized symbol 'baud' kernel test robot
2024-04-11 10:13 Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).