* [crng-random:vmgenid-of 3/3] drivers/virt/vmgenid.c:123 vmgenid_add_of() warn: platform_get_irq() does not return zero
@ 2024-04-19 21:58 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-04-19 21:58 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: zx2c4@kernel.org
TO: Sudan Landge <sudanl@amazon.com>
CC: "Jason A. Donenfeld" <zx2c4@kernel.org>
CC: Alexander Graf <graf@amazon.com>
tree: git://git.kernel.org/pub/scm/linux/kernel/git/crng/random.git vmgenid-of
head: c1fa2e76c9238c014249d5ccbff366db2642de09
commit: ad0cf87856421036825ba264456005cd79e510b8 [3/3] virt: vmgenid: add support for devicetree bindings
:::::: branch date: 8 hours ago
:::::: commit date: 27 hours ago
config: mips-randconfig-r071-20240420 (https://download.01.org/0day-ci/archive/20240420/202404200545.JllWEoPv-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 7089c359a3845323f6f30c44a47dd901f2edfe63)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202404200545.JllWEoPv-lkp@intel.com/
smatch warnings:
drivers/virt/vmgenid.c:123 vmgenid_add_of() warn: platform_get_irq() does not return zero
vim +123 drivers/virt/vmgenid.c
ad0cf878564210 Sudan Landge 2024-04-17 109
ad0cf878564210 Sudan Landge 2024-04-17 110 static int vmgenid_add_of(struct platform_device *pdev,
ad0cf878564210 Sudan Landge 2024-04-17 111 struct vmgenid_state *state)
ad0cf878564210 Sudan Landge 2024-04-17 112 {
ad0cf878564210 Sudan Landge 2024-04-17 113 void *virt_addr;
ad0cf878564210 Sudan Landge 2024-04-17 114 int ret;
ad0cf878564210 Sudan Landge 2024-04-17 115
ad0cf878564210 Sudan Landge 2024-04-17 116 virt_addr = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
ad0cf878564210 Sudan Landge 2024-04-17 117 if (IS_ERR(virt_addr))
ad0cf878564210 Sudan Landge 2024-04-17 118 return PTR_ERR(virt_addr);
ad0cf878564210 Sudan Landge 2024-04-17 119
ad0cf878564210 Sudan Landge 2024-04-17 120 setup_vmgenid_state(state, virt_addr);
ad0cf878564210 Sudan Landge 2024-04-17 121
ad0cf878564210 Sudan Landge 2024-04-17 122 ret = platform_get_irq(pdev, 0);
ad0cf878564210 Sudan Landge 2024-04-17 @123 if (ret)
ad0cf878564210 Sudan Landge 2024-04-17 124 return ret;
ad0cf878564210 Sudan Landge 2024-04-17 125
ad0cf878564210 Sudan Landge 2024-04-17 126 ret = devm_request_irq(&pdev->dev, ret, vmgenid_of_irq_handler,
ad0cf878564210 Sudan Landge 2024-04-17 127 IRQF_SHARED, "vmgenid", &pdev->dev);
ad0cf878564210 Sudan Landge 2024-04-17 128 if (ret)
ad0cf878564210 Sudan Landge 2024-04-17 129 return ret;
ad0cf878564210 Sudan Landge 2024-04-17 130
ad0cf878564210 Sudan Landge 2024-04-17 131 pdev->dev.driver_data = state;
ad0cf878564210 Sudan Landge 2024-04-17 132 return 0;
ad0cf878564210 Sudan Landge 2024-04-17 133 }
af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 134
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* [crng-random:vmgenid-of 3/3] drivers/virt/vmgenid.c:123 vmgenid_add_of() warn: platform_get_irq() does not return zero
@ 2024-04-22 13:28 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2024-04-22 13:28 UTC (permalink / raw)
To: oe-kbuild, Sudan Landge; +Cc: lkp, oe-kbuild-all, zx2c4, Alexander Graf
tree: git://git.kernel.org/pub/scm/linux/kernel/git/crng/random.git vmgenid-of
head: c1fa2e76c9238c014249d5ccbff366db2642de09
commit: ad0cf87856421036825ba264456005cd79e510b8 [3/3] virt: vmgenid: add support for devicetree bindings
config: mips-randconfig-r071-20240420 (https://download.01.org/0day-ci/archive/20240420/202404200545.JllWEoPv-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 7089c359a3845323f6f30c44a47dd901f2edfe63)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202404200545.JllWEoPv-lkp@intel.com/
smatch warnings:
drivers/virt/vmgenid.c:123 vmgenid_add_of() warn: platform_get_irq() does not return zero
vim +123 drivers/virt/vmgenid.c
ad0cf878564210 Sudan Landge 2024-04-17 110 static int vmgenid_add_of(struct platform_device *pdev,
ad0cf878564210 Sudan Landge 2024-04-17 111 struct vmgenid_state *state)
ad0cf878564210 Sudan Landge 2024-04-17 112 {
ad0cf878564210 Sudan Landge 2024-04-17 113 void *virt_addr;
ad0cf878564210 Sudan Landge 2024-04-17 114 int ret;
ad0cf878564210 Sudan Landge 2024-04-17 115
ad0cf878564210 Sudan Landge 2024-04-17 116 virt_addr = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
ad0cf878564210 Sudan Landge 2024-04-17 117 if (IS_ERR(virt_addr))
ad0cf878564210 Sudan Landge 2024-04-17 118 return PTR_ERR(virt_addr);
ad0cf878564210 Sudan Landge 2024-04-17 119
ad0cf878564210 Sudan Landge 2024-04-17 120 setup_vmgenid_state(state, virt_addr);
ad0cf878564210 Sudan Landge 2024-04-17 121
ad0cf878564210 Sudan Landge 2024-04-17 122 ret = platform_get_irq(pdev, 0);
ad0cf878564210 Sudan Landge 2024-04-17 @123 if (ret)
platform_get_irq() never returns zero. It returns negative error codes
or positive values on success. So this driver will never probe()
successfully now. It should be
if (ret < 0)
return ret;
ad0cf878564210 Sudan Landge 2024-04-17 124 return ret;
ad0cf878564210 Sudan Landge 2024-04-17 125
ad0cf878564210 Sudan Landge 2024-04-17 126 ret = devm_request_irq(&pdev->dev, ret, vmgenid_of_irq_handler,
ad0cf878564210 Sudan Landge 2024-04-17 127 IRQF_SHARED, "vmgenid", &pdev->dev);
ad0cf878564210 Sudan Landge 2024-04-17 128 if (ret)
ad0cf878564210 Sudan Landge 2024-04-17 129 return ret;
ad0cf878564210 Sudan Landge 2024-04-17 130
ad0cf878564210 Sudan Landge 2024-04-17 131 pdev->dev.driver_data = state;
ad0cf878564210 Sudan Landge 2024-04-17 132 return 0;
ad0cf878564210 Sudan Landge 2024-04-17 133 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-22 13:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-19 21:58 [crng-random:vmgenid-of 3/3] drivers/virt/vmgenid.c:123 vmgenid_add_of() warn: platform_get_irq() does not return zero kernel test robot
2024-04-22 13:28 Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).