openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [RESEND][meta-python][PATCH 1/3] meta-python: Add python-pyflame recipe
@ 2018-05-04  7:09 Andrew Jeffery
  2018-05-04  7:09 ` [RESEND][meta-python][PATCH 2/3] meta-python: Port python-pyflame to 32-bit ARM Andrew Jeffery
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Andrew Jeffery @ 2018-05-04  7:09 UTC (permalink / raw)
  To: openembedded-devel; +Cc: openbmc, Andrew Jeffery

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
 meta-python/recipes-devtools/python/python-pyflame.inc      | 9 +++++++++
 meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb | 5 +++++
 2 files changed, 14 insertions(+)
 create mode 100644 meta-python/recipes-devtools/python/python-pyflame.inc
 create mode 100644 meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb

diff --git a/meta-python/recipes-devtools/python/python-pyflame.inc b/meta-python/recipes-devtools/python/python-pyflame.inc
new file mode 100644
index 000000000000..37ceab888533
--- /dev/null
+++ b/meta-python/recipes-devtools/python/python-pyflame.inc
@@ -0,0 +1,9 @@
+S = "${WORKDIR}/pyflame-${PV}"
+
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=2ee41112a44fe7014dce33e26468ba93"
+
+DEPENDS = "python"
+
+inherit pkgconfig autotools
+
diff --git a/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb b/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
new file mode 100644
index 000000000000..c902e121231b
--- /dev/null
+++ b/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
@@ -0,0 +1,5 @@
+require python-pyflame.inc
+
+SRC_URI = "https://github.com/uber/pyflame/archive/v${PV}.tar.gz"
+SRC_URI[md5sum] = "53d5822e5be371303e217a68ea9ea3e5"
+SRC_URI[sha256sum] = "03723509c037a994585e81e4a9c6d8e4fed87b486e23edd8d355a7bcc009bf79"
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [RESEND][meta-python][PATCH 2/3] meta-python: Port python-pyflame to 32-bit ARM
  2018-05-04  7:09 [RESEND][meta-python][PATCH 1/3] meta-python: Add python-pyflame recipe Andrew Jeffery
@ 2018-05-04  7:09 ` Andrew Jeffery
  2018-05-04  7:09 ` [RESEND][meta-python][PATCH 3/3] meta-python: Make python-pyflame cope with prelinked ELFs Andrew Jeffery
  2018-05-04  7:50 ` [oe] [RESEND][meta-python][PATCH 1/3] meta-python: Add python-pyflame recipe Anuj Mittal
  2 siblings, 0 replies; 6+ messages in thread
From: Andrew Jeffery @ 2018-05-04  7:09 UTC (permalink / raw)
  To: openembedded-devel; +Cc: openbmc, Andrew Jeffery

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
 ...ract-over-user_regs_struct-name-which-dif.patch | 69 ++++++++++++++++++++++
 .../python/python-pyflame_1.6.6.bb                 |  2 +
 2 files changed, 71 insertions(+)
 create mode 100644 meta-python/recipes-devtools/python/python-pyflame/0001-ptrace-Abstract-over-user_regs_struct-name-which-dif.patch

diff --git a/meta-python/recipes-devtools/python/python-pyflame/0001-ptrace-Abstract-over-user_regs_struct-name-which-dif.patch b/meta-python/recipes-devtools/python/python-pyflame/0001-ptrace-Abstract-over-user_regs_struct-name-which-dif.patch
new file mode 100644
index 000000000000..09c4394c2a4b
--- /dev/null
+++ b/meta-python/recipes-devtools/python/python-pyflame/0001-ptrace-Abstract-over-user_regs_struct-name-which-dif.patch
@@ -0,0 +1,69 @@
+From 2ef124e235a47dd4742813cf80e11a89cf4f02f8 Mon Sep 17 00:00:00 2001
+From: Andrew Jeffery <andrew@aj.id.au>
+Date: Thu, 3 May 2018 12:35:31 +0930
+Subject: [PATCH] ptrace: Abstract over user_regs_struct name, which differs on
+ ARM32
+
+Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
+---
+ src/ptrace.cc |  6 +++---
+ src/ptrace.h  | 10 ++++++++--
+ 2 files changed, 11 insertions(+), 5 deletions(-)
+
+diff --git a/src/ptrace.cc b/src/ptrace.cc
+index 485f58e4d82e..610fabb3b8e8 100644
+--- a/src/ptrace.cc
++++ b/src/ptrace.cc
+@@ -122,8 +122,8 @@ void PtraceInterrupt(pid_t pid) {
+   DoWait(pid);
+ }
+ 
+-struct user_regs_struct PtraceGetRegs(pid_t pid) {
+-  struct user_regs_struct regs;
++user_regs_struct PtraceGetRegs(pid_t pid) {
++  user_regs_struct regs;
+   if (ptrace(PTRACE_GETREGS, pid, 0, &regs)) {
+     std::ostringstream ss;
+     ss << "Failed to PTRACE_GETREGS: " << strerror(errno);
+@@ -132,7 +132,7 @@ struct user_regs_struct PtraceGetRegs(pid_t pid) {
+   return regs;
+ }
+ 
+-void PtraceSetRegs(pid_t pid, struct user_regs_struct regs) {
++void PtraceSetRegs(pid_t pid, user_regs_struct regs) {
+   if (ptrace(PTRACE_SETREGS, pid, 0, &regs)) {
+     std::ostringstream ss;
+     ss << "Failed to PTRACE_SETREGS: " << strerror(errno);
+diff --git a/src/ptrace.h b/src/ptrace.h
+index 7083be1c4dfd..d6af8bf9f83a 100644
+--- a/src/ptrace.h
++++ b/src/ptrace.h
+@@ -23,6 +23,12 @@
+ 
+ #include "./config.h"
+ 
++#if defined(__arm__)
++typedef struct user_regs user_regs_struct;
++#else
++typedef struct user_regs_struct user_regs_struct;
++#endif
++
+ namespace pyflame {
+ 
+ int DoWait(pid_t pid, int options = 0);
+@@ -39,10 +45,10 @@ void PtraceSeize(pid_t pid);
+ void PtraceInterrupt(pid_t pid);
+ 
+ // get regs from a process
+-struct user_regs_struct PtraceGetRegs(pid_t pid);
++user_regs_struct PtraceGetRegs(pid_t pid);
+ 
+ // set regs in a process
+-void PtraceSetRegs(pid_t pid, struct user_regs_struct regs);
++void PtraceSetRegs(pid_t pid, user_regs_struct regs);
+ 
+ // poke a long word into an address
+ void PtracePoke(pid_t pid, unsigned long addr, long data);
+-- 
+2.14.1
+
diff --git a/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb b/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
index c902e121231b..2edd708506e3 100644
--- a/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
+++ b/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
@@ -3,3 +3,5 @@ require python-pyflame.inc
 SRC_URI = "https://github.com/uber/pyflame/archive/v${PV}.tar.gz"
 SRC_URI[md5sum] = "53d5822e5be371303e217a68ea9ea3e5"
 SRC_URI[sha256sum] = "03723509c037a994585e81e4a9c6d8e4fed87b486e23edd8d355a7bcc009bf79"
+
+SRC_URI += "file://0001-ptrace-Abstract-over-user_regs_struct-name-which-dif.patch"
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [RESEND][meta-python][PATCH 3/3] meta-python: Make python-pyflame cope with prelinked ELFs
  2018-05-04  7:09 [RESEND][meta-python][PATCH 1/3] meta-python: Add python-pyflame recipe Andrew Jeffery
  2018-05-04  7:09 ` [RESEND][meta-python][PATCH 2/3] meta-python: Port python-pyflame to 32-bit ARM Andrew Jeffery
@ 2018-05-04  7:09 ` Andrew Jeffery
  2018-05-04  7:50 ` [oe] [RESEND][meta-python][PATCH 1/3] meta-python: Add python-pyflame recipe Anuj Mittal
  2 siblings, 0 replies; 6+ messages in thread
From: Andrew Jeffery @ 2018-05-04  7:09 UTC (permalink / raw)
  To: openembedded-devel; +Cc: openbmc, Andrew Jeffery

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
 ...mbol-Account-for-prelinked-shared-objects.patch | 134 +++++++++++++++++++++
 .../python/python-pyflame_1.6.6.bb                 |   1 +
 2 files changed, 135 insertions(+)
 create mode 100644 meta-python/recipes-devtools/python/python-pyflame/0001-symbol-Account-for-prelinked-shared-objects.patch

diff --git a/meta-python/recipes-devtools/python/python-pyflame/0001-symbol-Account-for-prelinked-shared-objects.patch b/meta-python/recipes-devtools/python/python-pyflame/0001-symbol-Account-for-prelinked-shared-objects.patch
new file mode 100644
index 000000000000..3eefc9cb9830
--- /dev/null
+++ b/meta-python/recipes-devtools/python/python-pyflame/0001-symbol-Account-for-prelinked-shared-objects.patch
@@ -0,0 +1,134 @@
+From 007965d341349679607699d005c4af811b2c419a Mon Sep 17 00:00:00 2001
+From: Andrew Jeffery <andrew@aj.id.au>
+Date: Fri, 4 May 2018 11:23:53 +0930
+Subject: [PATCH] symbol: Account for prelinked shared objects
+
+Some projects, such as those derived from Yocto, tend to prelink their
+binaries and libraries to reduce runtime overhead. Currently this trips
+up pyflame in its symbol address calculations, and leads to ptrace
+failures due to spurious addresses:
+
+   $ pyflame -t python -c "print 'foo'"
+   Unexpected ptrace(2) exception: Failed to PTRACE_PEEKDATA (pid 1482, addr 0x9f9b1d70): Input/output error
+   Unexpected ptrace(2) exception: Failed to PTRACE_PEEKDATA (pid 1482, addr 0x9f9b1d70): Input/output error
+   Unexpected ptrace(2) exception: Failed to PTRACE_PEEKDATA (pid 1482, addr 0x9f9b1d70): Input/output error
+   Unexpected ptrace(2) exception: Failed to PTRACE_PEEKDATA (pid 1482, addr 0x9f9b1d70): Input/output error
+   Unexpected ptrace(2) exception: Failed to PTRACE_PEEKDATA (pid 1482, addr 0x9f9b1d70): Input/output error
+   ...
+
+Add support for reading a prelinked base p_vaddr out of the ELF and
+adjust the PyAddresses values accordingly.
+
+Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
+---
+ src/symbol.cc | 15 +++++++++++++++
+ src/symbol.h  | 29 ++++++++++++++++++++++++++++-
+ 2 files changed, 43 insertions(+), 1 deletion(-)
+
+diff --git a/src/symbol.cc b/src/symbol.cc
+index 125174efeeb5..39c3e8132dd1 100644
+--- a/src/symbol.cc
++++ b/src/symbol.cc
+@@ -166,6 +166,17 @@ PyABI ELF::WalkTable(int sym, int str, PyAddresses *addrs) {
+   return abi;
+ }
+ 
++addr_t ELF::GetBaseAddress() {
++  int32_t phnum = hdr()->e_phnum;
++  int32_t i;
++  for (i = 0; i < phnum && phdr(i)->p_type != PT_LOAD; i++) {
++  }
++  if (i == phnum) {
++    throw FatalException("Failed to find PT_LOAD entry in program headers");
++  }
++  return phdr(i)->p_vaddr;
++}
++
+ PyAddresses ELF::GetAddresses(PyABI *abi) {
+   PyAddresses addrs;
+   PyABI detected_abi = WalkTable(dynsym_, dynstr_, &addrs);
+@@ -176,6 +187,10 @@ PyAddresses ELF::GetAddresses(PyABI *abi) {
+   if (abi != nullptr) {
+     *abi = detected_abi;
+   }
++  // Handle prelinked shared objects
++  if (hdr()->e_type == ET_DYN) {
++    return addrs - GetBaseAddress();
++  }
+   return addrs;
+ }
+ }  // namespace pyflame
+diff --git a/src/symbol.h b/src/symbol.h
+index 124853bcc1c1..bb92b9a2604b 100644
+--- a/src/symbol.h
++++ b/src/symbol.h
+@@ -28,15 +28,19 @@
+ 
+ #if USE_ELF64
+ #define ehdr_t Elf64_Ehdr
++#define phdr_t Elf64_Phdr
+ #define shdr_t Elf64_Shdr
+ #define dyn_t Elf64_Dyn
+ #define sym_t Elf64_Sym
++#define addr_t Elf64_Addr
+ #define ARCH_ELFCLASS ELFCLASS64
+ #else
+ #define ehdr_t Elf32_Ehdr
++#define phdr_t Elf32_Phdr
+ #define shdr_t Elf32_Shdr
+ #define dyn_t Elf32_Dyn
+ #define sym_t Elf32_Sym
++#define addr_t Elf32_Addr
+ #define ARCH_ELFCLASS ELFCLASS32
+ #endif
+ 
+@@ -67,8 +71,18 @@ struct PyAddresses {
+         interp_head_hint(0),
+         pie(false) {}
+ 
++  PyAddresses operator-(const unsigned long base) const {
++    PyAddresses res(*this);
++    res.tstate_addr = this->tstate_addr == 0 ? 0 : this->tstate_addr - base;
++    res.interp_head_addr =
++        this->interp_head_addr == 0 ? 0 : this->interp_head_addr - base;
++    res.interp_head_fn_addr =
++        this->interp_head_fn_addr == 0 ? 0 : this->interp_head_fn_addr - base;
++    return res;
++  }
++
+   PyAddresses operator+(const unsigned long base) const {
+-    PyAddresses res;
++    PyAddresses res(*this);
+     res.tstate_addr = this->tstate_addr == 0 ? 0 : this->tstate_addr + base;
+     res.interp_head_addr =
+         this->interp_head_addr == 0 ? 0 : this->interp_head_addr + base;
+@@ -113,6 +127,9 @@ class ELF {
+   // ABI.
+   PyAddresses GetAddresses(PyABI *abi);
+ 
++  // Extract the base load address from the Program Header table
++  addr_t GetBaseAddress();
++
+  private:
+   void *addr_;
+   size_t length_;
+@@ -122,6 +139,16 @@ class ELF {
+     return reinterpret_cast<const ehdr_t *>(addr_);
+   }
+ 
++  inline const phdr_t *phdr(int idx) const {
++    if (idx < 0) {
++      std::ostringstream ss;
++      ss << "Illegal phdr index: " << idx;
++      throw FatalException(ss.str());
++    }
++    return reinterpret_cast<const phdr_t *>(p() + hdr()->e_phoff +
++                                            idx * hdr()->e_phentsize);
++  }
++
+   inline const shdr_t *shdr(int idx) const {
+     if (idx < 0) {
+       std::ostringstream ss;
+-- 
+2.14.1
+
diff --git a/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb b/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
index 2edd708506e3..93c8ddc6d483 100644
--- a/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
+++ b/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
@@ -5,3 +5,4 @@ SRC_URI[md5sum] = "53d5822e5be371303e217a68ea9ea3e5"
 SRC_URI[sha256sum] = "03723509c037a994585e81e4a9c6d8e4fed87b486e23edd8d355a7bcc009bf79"
 
 SRC_URI += "file://0001-ptrace-Abstract-over-user_regs_struct-name-which-dif.patch"
+SRC_URI += "file://0001-symbol-Account-for-prelinked-shared-objects.patch"
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [oe] [RESEND][meta-python][PATCH 1/3] meta-python: Add python-pyflame recipe
  2018-05-04  7:09 [RESEND][meta-python][PATCH 1/3] meta-python: Add python-pyflame recipe Andrew Jeffery
  2018-05-04  7:09 ` [RESEND][meta-python][PATCH 2/3] meta-python: Port python-pyflame to 32-bit ARM Andrew Jeffery
  2018-05-04  7:09 ` [RESEND][meta-python][PATCH 3/3] meta-python: Make python-pyflame cope with prelinked ELFs Andrew Jeffery
@ 2018-05-04  7:50 ` Anuj Mittal
  2018-05-04  7:55   ` Andrew Jeffery
  2 siblings, 1 reply; 6+ messages in thread
From: Anuj Mittal @ 2018-05-04  7:50 UTC (permalink / raw)
  To: Andrew Jeffery, openembedded-devel; +Cc: openbmc

On 05/04/2018 03:09 PM, Andrew Jeffery wrote:
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
>  meta-python/recipes-devtools/python/python-pyflame.inc      | 9 +++++++++
>  meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb | 5 +++++
>  2 files changed, 14 insertions(+)
>  create mode 100644 meta-python/recipes-devtools/python/python-pyflame.inc
>  create mode 100644 meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
> 
> diff --git a/meta-python/recipes-devtools/python/python-pyflame.inc b/meta-python/recipes-devtools/python/python-pyflame.inc
> new file mode 100644
> index 000000000000..37ceab888533
> --- /dev/null
> +++ b/meta-python/recipes-devtools/python/python-pyflame.inc
> @@ -0,0 +1,9 @@
> +S = "${WORKDIR}/pyflame-${PV}"
> +
> +LICENSE = "Apache-2.0"
> +LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=2ee41112a44fe7014dce33e26468ba93"
> +
> +DEPENDS = "python"
> +
> +inherit pkgconfig autotools
> +
> diff --git a/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb b/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
> new file mode 100644
> index 000000000000..c902e121231b
> --- /dev/null
> +++ b/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
> @@ -0,0 +1,5 @@
> +require python-pyflame.inc
> +
> +SRC_URI = "https://github.com/uber/pyflame/archive/v${PV}.tar.gz"

Archive tarball checksums are known to change. Perhaps you can consider
using the release tarball instead?

https://github.com/uber/pyflame/releases

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [oe] [RESEND][meta-python][PATCH 1/3] meta-python: Add python-pyflame recipe
  2018-05-04  7:50 ` [oe] [RESEND][meta-python][PATCH 1/3] meta-python: Add python-pyflame recipe Anuj Mittal
@ 2018-05-04  7:55   ` Andrew Jeffery
  2018-06-22 21:16     ` Khem Raj
  0 siblings, 1 reply; 6+ messages in thread
From: Andrew Jeffery @ 2018-05-04  7:55 UTC (permalink / raw)
  To: Anuj Mittal, openembedded-devel; +Cc: openbmc

Hi Anuj,

Thanks for the quick review!

On Fri, 4 May 2018, at 17:20, Anuj Mittal wrote:
> On 05/04/2018 03:09 PM, Andrew Jeffery wrote:
> > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > ---
> >  meta-python/recipes-devtools/python/python-pyflame.inc      | 9 +++++++++
> >  meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb | 5 +++++
> >  2 files changed, 14 insertions(+)
> >  create mode 100644 meta-python/recipes-devtools/python/python-pyflame.inc
> >  create mode 100644 meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
> > 
> > diff --git a/meta-python/recipes-devtools/python/python-pyflame.inc b/meta-python/recipes-devtools/python/python-pyflame.inc
> > new file mode 100644
> > index 000000000000..37ceab888533
> > --- /dev/null
> > +++ b/meta-python/recipes-devtools/python/python-pyflame.inc
> > @@ -0,0 +1,9 @@
> > +S = "${WORKDIR}/pyflame-${PV}"
> > +
> > +LICENSE = "Apache-2.0"
> > +LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=2ee41112a44fe7014dce33e26468ba93"
> > +
> > +DEPENDS = "python"
> > +
> > +inherit pkgconfig autotools
> > +
> > diff --git a/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb b/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
> > new file mode 100644
> > index 000000000000..c902e121231b
> > --- /dev/null
> > +++ b/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
> > @@ -0,0 +1,5 @@
> > +require python-pyflame.inc
> > +
> > +SRC_URI = "https://github.com/uber/pyflame/archive/v${PV}.tar.gz"
> 
> Archive tarball checksums are known to change. Perhaps you can consider
> using the release tarball instead?
> 
> https://github.com/uber/pyflame/releases

What exact URL should I use? I got the URL used in the recipe through the releases page by copying the tar.gz link.

Cheers,

Andrew

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [oe] [RESEND][meta-python][PATCH 1/3] meta-python: Add python-pyflame recipe
  2018-05-04  7:55   ` Andrew Jeffery
@ 2018-06-22 21:16     ` Khem Raj
  0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2018-06-22 21:16 UTC (permalink / raw)
  To: Andrew Jeffery; +Cc: Anuj Mittal, openembeded-devel, openbmc

On Fri, May 4, 2018 at 12:55 AM Andrew Jeffery <andrew@aj.id.au> wrote:
>
> Hi Anuj,
>
> Thanks for the quick review!
>
> On Fri, 4 May 2018, at 17:20, Anuj Mittal wrote:
> > On 05/04/2018 03:09 PM, Andrew Jeffery wrote:
> > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > > ---
> > >  meta-python/recipes-devtools/python/python-pyflame.inc      | 9 +++++++++
> > >  meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb | 5 +++++
> > >  2 files changed, 14 insertions(+)
> > >  create mode 100644 meta-python/recipes-devtools/python/python-pyflame.inc
> > >  create mode 100644 meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
> > >
> > > diff --git a/meta-python/recipes-devtools/python/python-pyflame.inc b/meta-python/recipes-devtools/python/python-pyflame.inc
> > > new file mode 100644
> > > index 000000000000..37ceab888533
> > > --- /dev/null
> > > +++ b/meta-python/recipes-devtools/python/python-pyflame.inc
> > > @@ -0,0 +1,9 @@
> > > +S = "${WORKDIR}/pyflame-${PV}"
> > > +
> > > +LICENSE = "Apache-2.0"
> > > +LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=2ee41112a44fe7014dce33e26468ba93"
> > > +
> > > +DEPENDS = "python"
> > > +
> > > +inherit pkgconfig autotools
> > > +
> > > diff --git a/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb b/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
> > > new file mode 100644
> > > index 000000000000..c902e121231b
> > > --- /dev/null
> > > +++ b/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
> > > @@ -0,0 +1,5 @@
> > > +require python-pyflame.inc
> > > +
> > > +SRC_URI = "https://github.com/uber/pyflame/archive/v${PV}.tar.gz"
> >
> > Archive tarball checksums are known to change. Perhaps you can consider
> > using the release tarball instead?
> >
> > https://github.com/uber/pyflame/releases
>
> What exact URL should I use? I got the URL used in the recipe through the releases page by copying the tar.gz link.

here I think you need to use git fetcher instead of wget fetcher and
point SRCREV = "sha of tag" something like below

SRC_URI = "git://github.com/uber/pyflame"
# v1.6.6
SRCREV = "8a9d8c2acc3b3bb027475b738134f1e6fff14e6c"
S = "${WORKDIR}/git"
UPSTREAM_CHECK_URI = "https://github.com/uber/pyflame/releases"

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-06-22 21:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-04  7:09 [RESEND][meta-python][PATCH 1/3] meta-python: Add python-pyflame recipe Andrew Jeffery
2018-05-04  7:09 ` [RESEND][meta-python][PATCH 2/3] meta-python: Port python-pyflame to 32-bit ARM Andrew Jeffery
2018-05-04  7:09 ` [RESEND][meta-python][PATCH 3/3] meta-python: Make python-pyflame cope with prelinked ELFs Andrew Jeffery
2018-05-04  7:50 ` [oe] [RESEND][meta-python][PATCH 1/3] meta-python: Add python-pyflame recipe Anuj Mittal
2018-05-04  7:55   ` Andrew Jeffery
2018-06-22 21:16     ` Khem Raj

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).