* xyz.openbmc_project.Sensor.Value units
@ 2020-09-21 17:33 Patrick Williams
2020-09-21 17:33 ` Patrick Williams
2020-09-30 5:22 ` Andrew Jeffery
0 siblings, 2 replies; 3+ messages in thread
From: Patrick Williams @ 2020-09-21 17:33 UTC (permalink / raw)
To: OpenBMC List
[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]
Hello,
Currently all xyz.openbmc_project.Sensor.Value's have metric units.
There is a proposed commit [1] to add a non-metric unit. Are there any
opinions on this subject?
In this case the proposal is to add an "airflow" unit, in CFMs (cubit
feet per minute). An equivalent metric unit would be L/s (liters per
second). CFM tends to be the standard unit to measure airflow from a
fan, but L/s is used for liquid cooling.
Options:
* Allow CFM for airflow.
- CFM is the "industry standard" measurement for fans.
* Require Sensors.Value to use L/s instead.
- All units will continue to be metric. Any external interface
which is expecting a non-metric unit can do the conversion at
that point.
- We won't have duplicate Units defined for similar concepts
(air vs liquid flow in this case).
Thus, it seems like there are two underlying questions to resolve:
* Do we require only metric unit or do we allow non-metric?
* Do we allow duplicate unit definitions for the same concept (ex. flow)?
1. https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/36573
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* xyz.openbmc_project.Sensor.Value units
2020-09-21 17:33 xyz.openbmc_project.Sensor.Value units Patrick Williams
@ 2020-09-21 17:33 ` Patrick Williams
2020-09-30 5:22 ` Andrew Jeffery
1 sibling, 0 replies; 3+ messages in thread
From: Patrick Williams @ 2020-09-21 17:33 UTC (permalink / raw)
To: OpenBMC List
[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]
Hello,
Currently all xyz.openbmc_project.Sensor.Value's have metric units.
There is a proposed commit [1] to add a non-metric unit. Are there any
opinions on this subject?
In this case the proposal is to add an "airflow" unit, in CFMs (cubit
feet per minute). An equivalent metric unit would be L/s (liters per
second). CFM tends to be the standard unit to measure airflow from a
fan, but L/s is used for liquid cooling.
Options:
* Allow CFM for airflow.
- CFM is the "industry standard" measurement for fans.
* Require Sensors.Value to use L/s instead.
- All units will continue to be metric. Any external interface
which is expecting a non-metric unit can do the conversion at
that point.
- We won't have duplicate Units defined for similar concepts
(air vs liquid flow in this case).
Thus, it seems like there are two underlying questions to resolve:
* Do we require only metric unit or do we allow non-metric?
* Do we allow duplicate unit definitions for the same concept (ex. flow)?
1. https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/36573
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: xyz.openbmc_project.Sensor.Value units
2020-09-21 17:33 xyz.openbmc_project.Sensor.Value units Patrick Williams
2020-09-21 17:33 ` Patrick Williams
@ 2020-09-30 5:22 ` Andrew Jeffery
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Jeffery @ 2020-09-30 5:22 UTC (permalink / raw)
To: Patrick Williams, OpenBMC List
On Tue, 22 Sep 2020, at 03:03, Patrick Williams wrote:
> Hello,
>
> Currently all xyz.openbmc_project.Sensor.Value's have metric units.
> There is a proposed commit [1] to add a non-metric unit. Are there any
> opinions on this subject?
My opinion is we should convert values to presentation units at the
edges, and use metric everywhere internally.
>
> In this case the proposal is to add an "airflow" unit, in CFMs (cubit
> feet per minute). An equivalent metric unit would be L/s (liters per
> second). CFM tends to be the standard unit to measure airflow from a
> fan, but L/s is used for liquid cooling.
>
> Options:
>
> * Allow CFM for airflow.
> - CFM is the "industry standard" measurement for fans.
>
> * Require Sensors.Value to use L/s instead.
> - All units will continue to be metric. Any external interface
> which is expecting a non-metric unit can do the conversion at
> that point.
Right, so this is how it should be IMO.
>
> - We won't have duplicate Units defined for similar concepts
> (air vs liquid flow in this case).
>
> Thus, it seems like there are two underlying questions to resolve:
>
> * Do we require only metric unit or do we allow non-metric?
> * Do we allow duplicate unit definitions for the same concept (ex. flow)?
Lets avoid making life more confusing for ourselves and stick to a single
unit definition.
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-30 5:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 17:33 xyz.openbmc_project.Sensor.Value units Patrick Williams
2020-09-21 17:33 ` Patrick Williams
2020-09-30 5:22 ` Andrew Jeffery
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).