* [PATCH linux dev-5.10] net: npcm: Remove superfluous logging
@ 2021-03-31 22:38 William A. Kennington III
2021-03-31 22:56 ` Joel Stanley
0 siblings, 1 reply; 2+ messages in thread
From: William A. Kennington III @ 2021-03-31 22:38 UTC (permalink / raw)
To: openbmc; +Cc: William A. Kennington III
Any queries of the ethernet interface will enter the settings functions.
This causes dmesg to fill up with unnecessary log entries every time the
phy information is queried.
Signed-off-by: William A. Kennington III <wak@google.com>
---
drivers/net/ethernet/nuvoton/npcm7xx_emc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/nuvoton/npcm7xx_emc.c b/drivers/net/ethernet/nuvoton/npcm7xx_emc.c
index 3e9b8b68fc55..28aaee3e80ff 100644
--- a/drivers/net/ethernet/nuvoton/npcm7xx_emc.c
+++ b/drivers/net/ethernet/nuvoton/npcm7xx_emc.c
@@ -1773,7 +1773,6 @@ static int npcm7xx_get_settings(struct net_device *netdev,
if (!phydev)
return -ENODEV;
- dev_info(ðer->pdev->dev, "\n\nnpcm7xx_get_settings\n");
phy_ethtool_ksettings_get(phydev, cmd);
return 0;
@@ -1789,7 +1788,6 @@ static int npcm7xx_set_settings(struct net_device *netdev,
if (!phydev)
return -ENODEV;
- dev_info(ðer->pdev->dev, "\n\nnpcm7xx_set_settings\n");
ret = phy_ethtool_ksettings_set(phydev, cmd);
return ret;
--
2.31.0.291.g576ba9dcdaf-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux dev-5.10] net: npcm: Remove superfluous logging
2021-03-31 22:38 [PATCH linux dev-5.10] net: npcm: Remove superfluous logging William A. Kennington III
@ 2021-03-31 22:56 ` Joel Stanley
0 siblings, 0 replies; 2+ messages in thread
From: Joel Stanley @ 2021-03-31 22:56 UTC (permalink / raw)
To: William A. Kennington III; +Cc: OpenBMC Maillist
On Wed, 31 Mar 2021 at 22:38, William A. Kennington III <wak@google.com> wrote:
>
> Any queries of the ethernet interface will enter the settings functions.
> This causes dmesg to fill up with unnecessary log entries every time the
> phy information is queried.
>
> Signed-off-by: William A. Kennington III <wak@google.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
I've applied this and the other emc patch to dev-5.10.
Cheers,
Joel
> ---
> drivers/net/ethernet/nuvoton/npcm7xx_emc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/nuvoton/npcm7xx_emc.c b/drivers/net/ethernet/nuvoton/npcm7xx_emc.c
> index 3e9b8b68fc55..28aaee3e80ff 100644
> --- a/drivers/net/ethernet/nuvoton/npcm7xx_emc.c
> +++ b/drivers/net/ethernet/nuvoton/npcm7xx_emc.c
> @@ -1773,7 +1773,6 @@ static int npcm7xx_get_settings(struct net_device *netdev,
> if (!phydev)
> return -ENODEV;
>
> - dev_info(ðer->pdev->dev, "\n\nnpcm7xx_get_settings\n");
> phy_ethtool_ksettings_get(phydev, cmd);
>
> return 0;
> @@ -1789,7 +1788,6 @@ static int npcm7xx_set_settings(struct net_device *netdev,
> if (!phydev)
> return -ENODEV;
>
> - dev_info(ðer->pdev->dev, "\n\nnpcm7xx_set_settings\n");
> ret = phy_ethtool_ksettings_set(phydev, cmd);
>
> return ret;
> --
> 2.31.0.291.g576ba9dcdaf-goog
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-31 22:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 22:38 [PATCH linux dev-5.10] net: npcm: Remove superfluous logging William A. Kennington III
2021-03-31 22:56 ` Joel Stanley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).