Add firmware implementation in pldm

Add firmware implementation in pldm

[Kumar Thangavel]

[-- Attachment #1: Type: text/plain, Size: 1730 bytes --]

Classification: Internal
Hi All,

         We planning to do NIC firmware update for our system pldm base.

         So, We would like to add implementation support for pldm base firmware update. This should be generic for all to use firmware update for any devices.

         Do we need to create files "firmwareupdate.cpp/.hpp files" under pldm deamon as generic to handle firmware base pldm commands?

         Also, please suggest to repo add the BMC applications to send and recv the command handling.

         Could Please provide your comments/suggestions on this implementation.

Thanks,
Kumar.
::DISCLAIMER::
________________________________
The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.
________________________________

[-- Attachment #2: Type: text/html, Size: 4324 bytes --]

Re: Add firmware implementation in pldm

[Deepak Kodihalli]

Hi Kumar,


On Wed, Dec 9, 2020 at 9:20 PM Kumar Thangavel <thangavel.k@hcl.com> wrote:
>
> Classification: Internal
>
> Hi All,
>
>
>
>          We planning to do NIC firmware update for our system pldm base.

Great!

>
>          So, We would like to add implementation support for pldm base firmware update. This should be generic for all to use firmware update for any devices.
>          Do we need to create files “firmwareupdate.cpp/.hpp files” under pldm deamon as generic to handle firmware base pldm commands?

Since there is a PLDM firmware update specification, a generic design
and implementation is a definite possibility.

>          Also, please suggest to repo add the BMC applications to send and recv the command handling.
>
>          Could Please provide your comments/suggestions on this implementation.

Will you be able to update
https://github.com/openbmc/docs/blob/master/designs/pldm-stack.md with
a design section on firmware update? Some of the things I would like
to review via this doc update:
- How does this integrate with the current OpenBMC firmware update
architecture, and also with Redfish update service?
- What will PLDM run on? RBT or MCTP? MCTP over what binding?
- Do you anticipate changes to libmctp?
- How does this fit into the existing https://github.com/openbmc/pldm
design? What new components will you be adding? Will libpldm and pldmd
be impacted, and how?
- The 5.9 Linux Kernel has some APIs for PLDM based firmware update.
Can we use those?
- How do we plan to test this? Is hardware a must? Or are you planning
on mocking a PLDM responder?

I think a quick review of such a design doc will be beneficial before
delving into code. Also, please note - Richard and Sumanth (copied
them) are working on similar stuff as well. So there could be scope
for collaboration and to avoid likely duplicate effort. We do talk
about ongoing PLDM activities in OpenBMC in this meet -
https://github.com/openbmc/openbmc/wiki/OpenBMC-PMCI-WG.

Thanks,
Deepak

>
> Thanks,
>
> Kumar.
>
> ::DISCLAIMER::
> ________________________________
> The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.
> ________________________________

RE: Add firmware implementation in pldm

[Kumar Thangavel]

Classification: Internal

Hi Deepak,

           Thanks for your response.  Please find below my response inline.

Thanks,
Kumar.

-----Original Message-----
From: Deepak Kodihalli <deepak.kodihalli.83@gmail.com> 
Sent: Wednesday, December 9, 2020 9:47 PM
To: Kumar Thangavel <thangavel.k@hcl.com>; richard.marian.thomaiyar@linux.intel.com; sumanth.bhat@intel.com
Cc: openbmc@lists.ozlabs.org; Velumani T-ERS,HCLTech <velumanit@hcl.com>; sdasari@fb.com; Patrick Williams <patrickw3@fb.com>; tomjose@linux.vnet.ibm.com
Subject: Re: Add firmware implementation in pldm

[CAUTION: This Email is from outside the Organization. Unless you trust the sender, Don’t click links or open attachments as it may be a Phishing email, which can steal your Information and compromise your Computer.]

Hi Kumar,


On Wed, Dec 9, 2020 at 9:20 PM Kumar Thangavel <thangavel.k@hcl.com> wrote:
>
> Classification: Internal
>
> Hi All,
>
>
>
>          We planning to do NIC firmware update for our system pldm base.

Great!

>
>          So, We would like to add implementation support for pldm base firmware update. This should be generic for all to use firmware update for any devices.
>          Do we need to create files “firmwareupdate.cpp/.hpp files” under pldm deamon as generic to handle firmware base pldm commands?

Since there is a PLDM firmware update specification, a generic design and implementation is a definite possibility.

>          Also, please suggest to repo add the BMC applications to send and recv the command handling.
>
>          Could Please provide your comments/suggestions on this implementation.

Will you be able to update
https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Fdocs%2Fblob%2Fmaster%2Fdesigns%2Fpldm-stack.md&amp;data=04%7C01%7Cthangavel.k%40hcl.com%7C8b7f49e176b941c2de4008d89c5de97f%7C189de737c93a4f5a8b686f4ca9941912%7C0%7C0%7C637431274447773327%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=XPh1Atf8nMzEFjL1lhqT4KnCdVSDabYtpak3909vZ8w%3D&amp;reserved=0 with a design section on firmware update? Some of the things I would like to review via this doc update:

   Kumar : Sure. I will update the document. 

- How does this integrate with the current OpenBMC firmware update architecture, and also with Redfish update service?

    Kumar :     Need to explore. Please provide your suggestions on this.

- What will PLDM run on? RBT or MCTP? MCTP over what binding?

    Kumar : PLDM run on NIC-SI transport.  

- Do you anticipate changes to libmctp?

   Kumar : No. This is based on NIC-SI transport

- How does this fit into the existing https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Fpldm&amp;data=04%7C01%7Cthangavel.k%40hcl.com%7C8b7f49e176b941c2de4008d89c5de97f%7C189de737c93a4f5a8b686f4ca9941912%7C0%7C0%7C637431274447773327%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=dM8fJwGr5lz9DWZYCXmquHfHpBQGEviOpJBCP4OdxSo%3D&amp;reserved=0
design? What new components will you be adding? Will libpldm and pldmd be impacted, and how?
    
   Kumar: pldmd will be impacted to handle firmware update commands request/response. Will investigate in detail and update you on this. 

- The 5.9 Linux Kernel has some APIs for PLDM based firmware update.
Can we use those?
 
  Kumar : Yes. We can use that also. 

- How do we plan to test this? Is hardware a must? Or are you planning on mocking a PLDM responder?

 Kumar : We have hardware. So planning to test in the hardware. 

I think a quick review of such a design doc will be beneficial before delving into code. Also, please note - Richard and Sumanth (copied
them) are working on similar stuff as well. So there could be scope for collaboration and to avoid likely duplicate effort. We do talk about ongoing PLDM activities in OpenBMC in this meet - https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Fopenbmc%2Fwiki%2FOpenBMC-PMCI-WG&amp;data=04%7C01%7Cthangavel.k%40hcl.com%7C8b7f49e176b941c2de4008d89c5de97f%7C189de737c93a4f5a8b686f4ca9941912%7C0%7C0%7C637431274447773327%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=rDTsCy7Jza%2F6g8jl7a2CzKwzvoT0XHHnD9Gdb1197AY%3D&amp;reserved=0.

Kumar :  Sure.  Will join the discussion. 

Thanks,
Deepak

>
> Thanks,
>
> Kumar.
>
> ::DISCLAIMER::
> ________________________________
> The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.
> ________________________________

Re: Add firmware implementation in pldm

[Deepak Kodihalli]

Hi,

I've pushed a design proposal for PLDM firmware update:
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/40289.

Thanks,
Deepak

On Thu, Dec 10, 2020 at 5:47 PM Kumar Thangavel <thangavel.k@hcl.com> wrote:
>
> Classification: Internal
>
> Hi Deepak,
>
>            Thanks for your response.  Please find below my response inline.
>
> Thanks,
> Kumar.
>
> -----Original Message-----
> From: Deepak Kodihalli <deepak.kodihalli.83@gmail.com>
> Sent: Wednesday, December 9, 2020 9:47 PM
> To: Kumar Thangavel <thangavel.k@hcl.com>; richard.marian.thomaiyar@linux.intel.com; sumanth.bhat@intel.com
> Cc: openbmc@lists.ozlabs.org; Velumani T-ERS,HCLTech <velumanit@hcl.com>; sdasari@fb.com; Patrick Williams <patrickw3@fb.com>; tomjose@linux.vnet.ibm.com
> Subject: Re: Add firmware implementation in pldm
>
> [CAUTION: This Email is from outside the Organization. Unless you trust the sender, Don’t click links or open attachments as it may be a Phishing email, which can steal your Information and compromise your Computer.]
>
> Hi Kumar,
>
>
> On Wed, Dec 9, 2020 at 9:20 PM Kumar Thangavel <thangavel.k@hcl.com> wrote:
> >
> > Classification: Internal
> >
> > Hi All,
> >
> >
> >
> >          We planning to do NIC firmware update for our system pldm base.
>
> Great!
>
> >
> >          So, We would like to add implementation support for pldm base firmware update. This should be generic for all to use firmware update for any devices.
> >          Do we need to create files “firmwareupdate.cpp/.hpp files” under pldm deamon as generic to handle firmware base pldm commands?
>
> Since there is a PLDM firmware update specification, a generic design and implementation is a definite possibility.
>
> >          Also, please suggest to repo add the BMC applications to send and recv the command handling.
> >
> >          Could Please provide your comments/suggestions on this implementation.
>
> Will you be able to update
> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Fdocs%2Fblob%2Fmaster%2Fdesigns%2Fpldm-stack.md&amp;data=04%7C01%7Cthangavel.k%40hcl.com%7C8b7f49e176b941c2de4008d89c5de97f%7C189de737c93a4f5a8b686f4ca9941912%7C0%7C0%7C637431274447773327%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=XPh1Atf8nMzEFjL1lhqT4KnCdVSDabYtpak3909vZ8w%3D&amp;reserved=0 with a design section on firmware update? Some of the things I would like to review via this doc update:
>
>    Kumar : Sure. I will update the document.
>
> - How does this integrate with the current OpenBMC firmware update architecture, and also with Redfish update service?
>
>     Kumar :     Need to explore. Please provide your suggestions on this.
>
> - What will PLDM run on? RBT or MCTP? MCTP over what binding?
>
>     Kumar : PLDM run on NIC-SI transport.
>
> - Do you anticipate changes to libmctp?
>
>    Kumar : No. This is based on NIC-SI transport
>
> - How does this fit into the existing https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Fpldm&amp;data=04%7C01%7Cthangavel.k%40hcl.com%7C8b7f49e176b941c2de4008d89c5de97f%7C189de737c93a4f5a8b686f4ca9941912%7C0%7C0%7C637431274447773327%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=dM8fJwGr5lz9DWZYCXmquHfHpBQGEviOpJBCP4OdxSo%3D&amp;reserved=0
> design? What new components will you be adding? Will libpldm and pldmd be impacted, and how?
>
>    Kumar: pldmd will be impacted to handle firmware update commands request/response. Will investigate in detail and update you on this.
>
> - The 5.9 Linux Kernel has some APIs for PLDM based firmware update.
> Can we use those?
>
>   Kumar : Yes. We can use that also.
>
> - How do we plan to test this? Is hardware a must? Or are you planning on mocking a PLDM responder?
>
>  Kumar : We have hardware. So planning to test in the hardware.
>
> I think a quick review of such a design doc will be beneficial before delving into code. Also, please note - Richard and Sumanth (copied
> them) are working on similar stuff as well. So there could be scope for collaboration and to avoid likely duplicate effort. We do talk about ongoing PLDM activities in OpenBMC in this meet - https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Fopenbmc%2Fwiki%2FOpenBMC-PMCI-WG&amp;data=04%7C01%7Cthangavel.k%40hcl.com%7C8b7f49e176b941c2de4008d89c5de97f%7C189de737c93a4f5a8b686f4ca9941912%7C0%7C0%7C637431274447773327%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=rDTsCy7Jza%2F6g8jl7a2CzKwzvoT0XHHnD9Gdb1197AY%3D&amp;reserved=0.
>
> Kumar :  Sure.  Will join the discussion.
>
> Thanks,
> Deepak
>
> >
> > Thanks,
> >
> > Kumar.
> >
> > ::DISCLAIMER::
> > ________________________________
> > The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.
> > ________________________________