push code to gatesgarth branch

push code to gatesgarth branch

[Mohammed.Habeeb ISV]

[-- Attachment #1.1: Type: text/plain, Size: 240 bytes --]

Hi

We have added a new platform in openbmc 2.9 version. I tried to push the code for review however below error
Occur. Can we still push the code to non-master old branches?
Please let me know.

[cid:image003.jpg@01D74D76.21053CB0]

[-- Attachment #1.2: Type: text/html, Size: 2193 bytes --]

[-- Attachment #2: image003.jpg --]
[-- Type: image/jpeg, Size: 73393 bytes --]

Re: push code to gatesgarth branch

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

On Thu, May 20, 2021 at 07:46:22PM +0000, Mohammed.Habeeb ISV wrote:
> We have added a new platform in openbmc 2.9 version. I tried to push the code for review however below error
> Occur. Can we still push the code to non-master old branches?
> Please let me know.

Hello Mohammed.

Two comments:

1. You tried to push directly into the gatesgarth branch rather than
`refs/for/gatesgarth`.  We don't allow anyone to push directly into
branches without review.

2. We have not been allowing development on old branches.  Is there any
reason why this code cannot go into the master branch, even if you are
using an older branch internally?  (Most open source projects have a
similar policy; development should happen on master and bug fixes can be
backported).

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

RE: push code to gatesgarth branch

[Mohammed.Habeeb ISV]

[-- Attachment #1.1: Type: text/plain, Size: 459 bytes --]

Do we need to push the new code only on master branch? Any inputs?

Thanks

From: Mohammed.Habeeb ISV
Sent: Thursday, May 20, 2021 12:46 PM
To: openbmc@lists.ozlabs.org
Subject: push code to gatesgarth branch

Hi

We have added a new platform in openbmc 2.9 version. I tried to push the code for review however below error
Occur. Can we still push the code to non-master old branches?
Please let me know.

[cid:image002.jpg@01D75083.BC99C190]

[-- Attachment #1.2: Type: text/html, Size: 2667 bytes --]

[-- Attachment #2: image002.jpg --]
[-- Type: image/jpeg, Size: 70971 bytes --]

Re: push code to gatesgarth branch

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

On Mon, May 24, 2021 at 05:01:19PM +0000, Mohammed.Habeeb ISV wrote:
> Do we need to push the new code only on master branch? Any inputs?
> 

I already replied to this question:

https://lore.kernel.org/openbmc/YKbGE2s7ta47YuAH@patrickw3-mbp.dhcp.thefacebook.com/

We have only been allowing development on the master branch.  Is there
some reason you want to add your code to gatesgarth, which is now 2
Yocto releases old?

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: push code to gatesgarth branch

[krtaylor]

On 5/24/21 12:01 PM, Mohammed.Habeeb ISV wrote:
> Do we need to push the new code only on master branch? Any inputs?

As Patrick said, yes. New code, meaning a new feature I'm assuming, can 
only be committed to the master branch. A critical fix *can* be 
backported to a previously branched release, but it is very rare. It 
must be a serious issue.

If instead you are trying to add a feature to a older release in some 
way to support a product, that is handled differently - you are 
encouraged to figure out how to make it work in the master branch, 
failing that (and only as a last resort) you will need to fork a product 
support branch for your product. Often this is done behind a company 
firewall in order for a company to add "special" features that 
differentiate their platform to a particular customer.

More info on why you need to do what you are asking may help the 
community get you the info you need.

Kurt Taylor (krtaylor)

> 
> Thanks
> 
> *From:* Mohammed.Habeeb ISV
> *Sent:* Thursday, May 20, 2021 12:46 PM
> *To:* openbmc@lists.ozlabs.org
> *Subject:* push code to gatesgarth branch
> 
> Hi
> 
> We have added a new platform in openbmc 2.9 version. I tried to push the 
> code for review however below error
> 
> Occur. Can we still push the code to non-master old branches?
> 
> Please let me know.
>