[PATCH] mbuto: quote variable assignments

[PATCH] mbuto: quote variable assignments

[Sevinj Aghayeva]

Add missing quotes around variable assignments.

Signed-off-by: Sevinj Aghayeva <sevinj.aghayeva@gmail.com>
---
 mbuto | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/mbuto b/mbuto
index 03a4547..88755c5 100755
--- a/mbuto
+++ b/mbuto
@@ -226,10 +226,10 @@ profile_kselftests() {
 	done
 	__colls="$(echo ${__colls} | ${TR} ' ' '\n' | ${SORT} -u)"
 
-	__pattern=$(list_join "${__colls}" '^' '$' '|')
+	__pattern="$(list_join "${__colls}" '^' '$' '|')"
 
-	__skip_targets=$(${AWK} '/^TARGETS/ { print $3}' ${__makefile} | \
-		${EGREP} -v "${__pattern}" | ${TR} '\n' ' ')
+	__skip_targets="$(${AWK} '/^TARGETS/ { print $3}' ${__makefile} | \
+		${EGREP} -v "${__pattern}" | ${TR} '\n' ' ')"
 
 	${MAKE} SKIP_TARGETS="${__skip_targets}" -C ${__testpath} install \
 								 >/dev/null 2>&1
@@ -240,26 +240,26 @@ profile_kselftests() {
 	INSTALL_MOD_PATH="${MODDIR}" ${MAKE} modules_install -j ${THREADS} \
 								>/dev/null
 
-	__files=$(list_join "${__colls}" "${__testpath}" '/config' ' ')
+	__files="$(list_join "${__colls}" "${__testpath}" '/config' ' ')"
 	__mods="$(${CAT} ${__files} 2>/dev/null | \
 			${AWK} -F'=' '/=m/ {print $1}' | ${SORT} -u)"
 
 	KMODS=
 	if [ ! -z "${__mods}" ]; then
-		__pattern=$(list_join "${__mods}" '^obj-\$\(' '\).*.o$' '|')
-		__result=$(${BASENAME} -a -s .o \
+		__pattern="$(list_join "${__mods}" '^obj-\$\(' '\).*.o$' '|')"
+		__result="$(${BASENAME} -a -s .o \
 			   $(${EGREP} -rn --include "*Makefile" ${__pattern} | \
-			     ${AWK} -F'+=' '/+=/ {print $2}'))
-		__find_pattern=$(list_join "${__result}" '-name ' '.ko ' '-o ')
+			     ${AWK} -F'+=' '/+=/ {print $2}'))"
+		__find_pattern="$(list_join "${__result}" '-name ' '.ko ' '-o ')"
 
-		KMODS=$(${FIND} "${MODDIR}" ${__find_pattern} | ${TR} '\n' ' ')
+		KMODS="$(${FIND} "${MODDIR}" ${__find_pattern} | ${TR} '\n' ' ')"
 
 		workers kmod_strip_worker
 
 		KMODS="$(${BASENAME} -a -s .ko ${KMODS})"
 
-		__kmods_needed=$(list_join "${__result}" '' '' ' ')
-		__kmods_missing=$(list_diff "${__kmods_needed}" "${KMODS}")
+		__kmods_needed="$(list_join "${__result}" '' '' ' ')"
+		__kmods_missing="$(list_diff "${__kmods_needed}" "${KMODS}")"
 
 		if [ ! -z "${__kmods_missing}" ]; then
 			notice "WARNING: missing modules: ${__kmods_missing}"
-- 
2.25.1

Re: [PATCH] mbuto: quote variable assignments

[Stefano Brivio]

On Fri, 22 Apr 2022 11:55:59 -0400
Sevinj Aghayeva <sevinj.aghayeva@gmail.com> wrote:

> Add missing quotes around variable assignments.

Applied and pushed together with your previous series, thanks!

-- 
Stefano