From: Michal Hocko <mhocko@kernel.org>
To: <linux-mm@kvack.org>
Cc: Pingfan Liu <kernelfans@gmail.com>,
Dave Hansen <dave.hansen@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Tony Luck <tony.luck@intel.com>,
linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Michal Hocko <mhocko@suse.com>
Subject: [PATCH v3 2/2] mm: be more verbose about zonelist initialization
Date: Wed, 13 Feb 2019 10:43:15 +0100 [thread overview]
Message-ID: <20190213094315.3504-1-mhocko@kernel.org> (raw)
In-Reply-To: <20190212095343.23315-3-mhocko@kernel.org>
From: Michal Hocko <mhocko@suse.com>
We have seen several bugs where zonelists have not been initialized
properly and it is not really straightforward to track those bugs down.
One way to help a bit at least is to dump zonelists of each node when
they are (re)initialized.
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
Sorry for spamming. I have screwed up ammending the previous version.
mm/page_alloc.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 2e097f336126..52e54d16662a 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5234,6 +5234,8 @@ static void build_zonelists(pg_data_t *pgdat)
int node, load, nr_nodes = 0;
nodemask_t used_mask;
int local_node, prev_node;
+ struct zone *zone;
+ struct zoneref *z;
/* NUMA-aware ordering of nodes */
local_node = pgdat->node_id;
@@ -5259,6 +5261,11 @@ static void build_zonelists(pg_data_t *pgdat)
build_zonelists_in_node_order(pgdat, node_order, nr_nodes);
build_thisnode_zonelists(pgdat);
+
+ pr_info("node[%d] zonelist: ", pgdat->node_id);
+ for_each_zone_zonelist(zone, z, &pgdat->node_zonelists[ZONELIST_FALLBACK], MAX_NR_ZONES-1)
+ pr_cont("%d:%s ", zone_to_nid(zone), zone->name);
+ pr_cont("\n");
}
#ifdef CONFIG_HAVE_MEMORYLESS_NODES
--
2.20.1
next prev parent reply other threads:[~2019-02-13 9:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 9:53 [PATCH 0/2] x86, numa: always initialize all possible nodes Michal Hocko
2019-02-12 9:53 ` [PATCH 1/2] " Michal Hocko
2019-05-01 19:12 ` Barret Rhoden
2019-05-02 13:00 ` Michal Hocko
2019-06-26 13:54 ` Michal Hocko
2019-02-12 9:53 ` [PATCH 2/2] mm: be more verbose about zonelist initialization Michal Hocko
2019-02-13 0:12 ` kbuild test robot
2019-02-13 2:13 ` kbuild test robot
2019-02-13 9:40 ` [PATCH v2 " Michal Hocko
2019-02-13 9:43 ` Michal Hocko [this message]
2019-02-13 10:32 ` [PATCH v3 " Peter Zijlstra
2019-02-13 11:50 ` Michal Hocko
2019-02-13 13:11 ` Peter Zijlstra
2019-02-13 13:41 ` Michal Hocko
2019-02-13 16:14 ` Dave Hansen
2019-02-13 16:18 ` Michal Hocko
2019-02-12 10:19 ` [PATCH 0/2] x86, numa: always initialize all possible nodes Mike Rapoport
2019-02-26 13:12 ` Michal Hocko
2019-04-15 11:42 ` Michal Hocko
2019-04-15 15:43 ` Dave Hansen
2019-04-16 6:54 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213094315.3504-1-mhocko@kernel.org \
--to=mhocko@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=dave.hansen@intel.com \
--cc=kernelfans@gmail.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@suse.com \
--cc=mingo@elte.hu \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).