Phone-Devel Archive on
 help / color / Atom feed
* [PATCH] drm/msm/adreno: a5xx_power: Don't apply A540 lm_setup to other GPUs
@ 2021-02-28 12:36 Konrad Dybcio
  0 siblings, 0 replies; only message in thread
From: Konrad Dybcio @ 2021-02-28 12:36 UTC (permalink / raw)
  To: phone-devel
  Cc: ~postmarketos/upstreaming, martin.botka,
	angelogioacchino.delregno, marijn.suijten, Konrad Dybcio,
	Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Jordan Crouse,
	linux-arm-msm, dri-devel, freedreno, linux-kernel

While passing the A530-specific lm_setup func to A530 and A540
to !A530 was fine back when only these two were supported, it
certainly is not a good idea to send A540 specifics to smaller
GPUs like A508 and friends.

Signed-off-by: Konrad Dybcio <>
 drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/adreno/a5xx_power.c b/drivers/gpu/drm/msm/adreno/a5xx_power.c
index f176a6f3eff6..e58670a61df4 100644
--- a/drivers/gpu/drm/msm/adreno/a5xx_power.c
+++ b/drivers/gpu/drm/msm/adreno/a5xx_power.c
@@ -304,7 +304,7 @@ int a5xx_power_init(struct msm_gpu *gpu)
 	/* Set up the limits management */
 	if (adreno_is_a530(adreno_gpu))
-	else
+	else if (adreno_is_a540(adreno_gpu))
 	/* Set up SP/TP power collpase */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-28 12:36 [PATCH] drm/msm/adreno: a5xx_power: Don't apply A540 lm_setup to other GPUs Konrad Dybcio

Phone-Devel Archive on

Archives are clonable:
	git clone --mirror phone-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 phone-devel phone-devel/ \
	public-inbox-index phone-devel

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone