Phone-Devel Archive on
 help / color / Atom feed
* [PATCH] drm/msm/dsi: Uncomment core_mmss clock for MSM8996
@ 2021-02-28 12:43 Konrad Dybcio
  0 siblings, 0 replies; only message in thread
From: Konrad Dybcio @ 2021-02-28 12:43 UTC (permalink / raw)
  To: phone-devel
  Cc: ~postmarketos/upstreaming, martin.botka,
	angelogioacchino.delregno, marijn.suijten, Konrad Dybcio,
	Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Konrad Dybcio,
	Jonathan Marek, linux-arm-msm, dri-devel, freedreno,

From: AngeloGioacchino Del Regno <>

The MSM8996 core_mmss clock was commented out due to some
strange issues that others were experiencing.

At least SONY Tone family is working perfectly fine with this clock
declared and gets it up and running without any error.

Signed-off-by: AngeloGioacchino Del Regno <>
Signed-off-by: Konrad Dybcio <>
 drivers/gpu/drm/msm/dsi/dsi_cfg.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
index b2ff68a15791..f3f1c03c7db9 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
@@ -106,12 +106,8 @@ static const struct msm_dsi_config msm8994_dsi_cfg = {
 	.num_dsi = 2,
- * TODO: core_mmss_clk fails to enable for some reason, but things work fine
- * without it too. Figure out why it doesn't enable and uncomment below
- */
 static const char * const dsi_8996_bus_clk_names[] = {
-	"mdp_core", "iface", "bus", /* "core_mmss", */
+	"mdp_core", "iface", "bus", "core_mmss",
 static const struct msm_dsi_config msm8996_dsi_cfg = {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-28 12:43 [PATCH] drm/msm/dsi: Uncomment core_mmss clock for MSM8996 Konrad Dybcio

Phone-Devel Archive on

Archives are clonable:
	git clone --mirror phone-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 phone-devel phone-devel/ \
	public-inbox-index phone-devel

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone