* [RESEND PATCH] leds: ledtrig-pattern: Use last_repeat when applying hw pattern
@ 2021-09-15 8:02 Marijn Suijten
0 siblings, 0 replies; 3+ messages in thread
From: Marijn Suijten @ 2021-09-15 8:02 UTC (permalink / raw)
To: phone-devel, Pavel Machek
Cc: ~postmarketos/upstreaming, AngeloGioacchino Del Regno,
Konrad Dybcio, Martin Botka, Jami Kettunen, Marijn Suijten,
Bjorn Andersson, Tian Tao, linux-leds, linux-kernel
`last_repeat` holds the actual value requested by the user whereas
`repeat` is a software iteration variable that is unused in hardware
patterns.
Furthermore `last_repeat` is the field returned to the user when reading
the `repeat` sysfs property. This field is initialized to `-1` which
is (together with `1`) the only valid value in the upcoming Qualcomm LPG
driver. It is thus unexpected when `repeat` with an initialization
value of `0` is passed into the the driver, when the sysfs property
clearly presents a value of `-1`.
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
Resending to pick up Bjorn's s-o-b/r-b and address Pavel in the To:
field directly.
drivers/leds/trigger/ledtrig-pattern.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/trigger/ledtrig-pattern.c b/drivers/leds/trigger/ledtrig-pattern.c
index 43a265dc4696..a11d68143757 100644
--- a/drivers/leds/trigger/ledtrig-pattern.c
+++ b/drivers/leds/trigger/ledtrig-pattern.c
@@ -126,7 +126,8 @@ static int pattern_trig_start_pattern(struct led_classdev *led_cdev)
if (data->is_hw_pattern) {
return led_cdev->pattern_set(led_cdev, data->patterns,
- data->npatterns, data->repeat);
+ data->npatterns,
+ data->last_repeat);
}
/* At least 2 tuples for software pattern. */
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] leds: ledtrig-pattern: Use last_repeat when applying hw pattern
2022-07-19 21:30 Marijn Suijten
@ 2023-12-20 8:12 ` Johan Hovold
0 siblings, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2023-12-20 8:12 UTC (permalink / raw)
To: Marijn Suijten
Cc: phone-devel, Pavel Machek, Bjorn Andersson,
~postmarketos/upstreaming, AngeloGioacchino Del Regno,
Konrad Dybcio, Martin Botka, Jami Kettunen, linux-arm-msm,
linux-leds, linux-kernel
On Tue, Jul 19, 2022 at 11:30:33PM +0200, Marijn Suijten wrote:
> `last_repeat` holds the actual value requested by the user whereas
> `repeat` is a software iteration variable that is unused in hardware
> patterns.
>
> Furthermore `last_repeat` is the field returned to the user when reading
> the `repeat` sysfs property. This field is initialized to `-1` which is
> - together with `1` - the only valid value in the upcoming Qualcomm LPG
> driver. It is thus unexpected when `repeat` with an initialization
> value of `0` is passed into the the driver, when the sysfs property
> clearly presents a value of `-1`.
>
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Looks correct to me:
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RESEND PATCH] leds: ledtrig-pattern: Use last_repeat when applying hw pattern
@ 2022-07-19 21:30 Marijn Suijten
2023-12-20 8:12 ` Johan Hovold
0 siblings, 1 reply; 3+ messages in thread
From: Marijn Suijten @ 2022-07-19 21:30 UTC (permalink / raw)
To: phone-devel, Pavel Machek, Bjorn Andersson
Cc: ~postmarketos/upstreaming, AngeloGioacchino Del Regno,
Konrad Dybcio, Martin Botka, Jami Kettunen, Marijn Suijten,
linux-arm-msm, linux-leds, linux-kernel
`last_repeat` holds the actual value requested by the user whereas
`repeat` is a software iteration variable that is unused in hardware
patterns.
Furthermore `last_repeat` is the field returned to the user when reading
the `repeat` sysfs property. This field is initialized to `-1` which is
- together with `1` - the only valid value in the upcoming Qualcomm LPG
driver. It is thus unexpected when `repeat` with an initialization
value of `0` is passed into the the driver, when the sysfs property
clearly presents a value of `-1`.
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/leds/trigger/ledtrig-pattern.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/trigger/ledtrig-pattern.c b/drivers/leds/trigger/ledtrig-pattern.c
index 43a265dc4696..a11d68143757 100644
--- a/drivers/leds/trigger/ledtrig-pattern.c
+++ b/drivers/leds/trigger/ledtrig-pattern.c
@@ -126,7 +126,8 @@ static int pattern_trig_start_pattern(struct led_classdev *led_cdev)
if (data->is_hw_pattern) {
return led_cdev->pattern_set(led_cdev, data->patterns,
- data->npatterns, data->repeat);
+ data->npatterns,
+ data->last_repeat);
}
/* At least 2 tuples for software pattern. */
base-commit: 3b87ed7ea4d598c81a03317a92dfbd59102224fd
--
2.37.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-20 8:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15 8:02 [RESEND PATCH] leds: ledtrig-pattern: Use last_repeat when applying hw pattern Marijn Suijten
2022-07-19 21:30 Marijn Suijten
2023-12-20 8:12 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).