* [PATCH 1/2] clk: qcom: mmcc-sdm660: Add necessary CXCs to venus_gdsc
@ 2021-10-08 10:20 AngeloGioacchino Del Regno
2021-10-08 10:20 ` [PATCH 2/2] clk: qcom: mmcc-sdm660: Add hw_ctrl flag to venus_core0_gdsc AngeloGioacchino Del Regno
2021-10-13 22:09 ` [PATCH 1/2] clk: qcom: mmcc-sdm660: Add necessary CXCs to venus_gdsc Stephen Boyd
0 siblings, 2 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2021-10-08 10:20 UTC (permalink / raw)
To: bjorn.andersson
Cc: agross, mturquette, sboyd, linux-arm-msm, linux-clk,
linux-kernel, konrad.dybcio, marijn.suijten, martin.botka,
~postmarketos/upstreaming, phone-devel,
AngeloGioacchino Del Regno
As also shown on downstream dts[1], for a correct operation of the
Venus block, we have to retain MEM/PERIPH when halting the video_core,
video_axi and video_subcore0 branches: add these CXCs to the main
Venus GDSC.
[1]: https://github.com/sonyxperiadev/kernel/blob/aosp/LA.UM.6.4.r1/arch/arm/boot/dts/qcom/sdm660-vidc.dtsi#L80
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/clk/qcom/mmcc-sdm660.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/qcom/mmcc-sdm660.c b/drivers/clk/qcom/mmcc-sdm660.c
index 9bfce9c31ca7..c5fdc36e3c34 100644
--- a/drivers/clk/qcom/mmcc-sdm660.c
+++ b/drivers/clk/qcom/mmcc-sdm660.c
@@ -2560,6 +2560,8 @@ static struct clk_branch video_subcore0_clk = {
static struct gdsc venus_gdsc = {
.gdscr = 0x1024,
+ .cxcs = (unsigned int[]){ 0x1028, 0x1034, 0x1048 },
+ .cxc_count = 3,
.pd = {
.name = "venus",
},
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] clk: qcom: mmcc-sdm660: Add hw_ctrl flag to venus_core0_gdsc
2021-10-08 10:20 [PATCH 1/2] clk: qcom: mmcc-sdm660: Add necessary CXCs to venus_gdsc AngeloGioacchino Del Regno
@ 2021-10-08 10:20 ` AngeloGioacchino Del Regno
2021-10-13 22:09 ` Stephen Boyd
2021-10-13 22:09 ` [PATCH 1/2] clk: qcom: mmcc-sdm660: Add necessary CXCs to venus_gdsc Stephen Boyd
1 sibling, 1 reply; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2021-10-08 10:20 UTC (permalink / raw)
To: bjorn.andersson
Cc: agross, mturquette, sboyd, linux-arm-msm, linux-clk,
linux-kernel, konrad.dybcio, marijn.suijten, martin.botka,
~postmarketos/upstreaming, phone-devel,
AngeloGioacchino Del Regno
As shown downstream[1], this GDSC supports HW trigger mode and
we're supposed to enable it in order to ensure correct operation.
[1]: https://github.com/sonyxperiadev/kernel/blob/aosp/LA.UM.6.4.r1/arch/arm/boot/dts/qcom/sdm630.dtsi#L2181
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/clk/qcom/mmcc-sdm660.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/qcom/mmcc-sdm660.c b/drivers/clk/qcom/mmcc-sdm660.c
index c5fdc36e3c34..bc19a23e13f8 100644
--- a/drivers/clk/qcom/mmcc-sdm660.c
+++ b/drivers/clk/qcom/mmcc-sdm660.c
@@ -2575,6 +2575,7 @@ static struct gdsc venus_core0_gdsc = {
},
.parent = &venus_gdsc.pd,
.pwrsts = PWRSTS_OFF_ON,
+ .flags = HW_CTRL,
};
static struct gdsc mdss_gdsc = {
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] clk: qcom: mmcc-sdm660: Add necessary CXCs to venus_gdsc
2021-10-08 10:20 [PATCH 1/2] clk: qcom: mmcc-sdm660: Add necessary CXCs to venus_gdsc AngeloGioacchino Del Regno
2021-10-08 10:20 ` [PATCH 2/2] clk: qcom: mmcc-sdm660: Add hw_ctrl flag to venus_core0_gdsc AngeloGioacchino Del Regno
@ 2021-10-13 22:09 ` Stephen Boyd
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2021-10-13 22:09 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, bjorn.andersson
Cc: agross, mturquette, linux-arm-msm, linux-clk, linux-kernel,
konrad.dybcio, marijn.suijten, martin.botka,
~postmarketos/upstreaming, phone-devel,
AngeloGioacchino Del Regno
Quoting AngeloGioacchino Del Regno (2021-10-08 03:20:40)
> As also shown on downstream dts[1], for a correct operation of the
> Venus block, we have to retain MEM/PERIPH when halting the video_core,
> video_axi and video_subcore0 branches: add these CXCs to the main
> Venus GDSC.
>
> [1]: https://github.com/sonyxperiadev/kernel/blob/aosp/LA.UM.6.4.r1/arch/arm/boot/dts/qcom/sdm660-vidc.dtsi#L80
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] clk: qcom: mmcc-sdm660: Add hw_ctrl flag to venus_core0_gdsc
2021-10-08 10:20 ` [PATCH 2/2] clk: qcom: mmcc-sdm660: Add hw_ctrl flag to venus_core0_gdsc AngeloGioacchino Del Regno
@ 2021-10-13 22:09 ` Stephen Boyd
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2021-10-13 22:09 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, bjorn.andersson
Cc: agross, mturquette, linux-arm-msm, linux-clk, linux-kernel,
konrad.dybcio, marijn.suijten, martin.botka,
~postmarketos/upstreaming, phone-devel,
AngeloGioacchino Del Regno
Quoting AngeloGioacchino Del Regno (2021-10-08 03:20:41)
> As shown downstream[1], this GDSC supports HW trigger mode and
> we're supposed to enable it in order to ensure correct operation.
>
> [1]: https://github.com/sonyxperiadev/kernel/blob/aosp/LA.UM.6.4.r1/arch/arm/boot/dts/qcom/sdm630.dtsi#L2181
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-13 22:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-08 10:20 [PATCH 1/2] clk: qcom: mmcc-sdm660: Add necessary CXCs to venus_gdsc AngeloGioacchino Del Regno
2021-10-08 10:20 ` [PATCH 2/2] clk: qcom: mmcc-sdm660: Add hw_ctrl flag to venus_core0_gdsc AngeloGioacchino Del Regno
2021-10-13 22:09 ` Stephen Boyd
2021-10-13 22:09 ` [PATCH 1/2] clk: qcom: mmcc-sdm660: Add necessary CXCs to venus_gdsc Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).