platform-driver-x86.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] platform/mellanox: mlxreg-hotplug: move to use request_irq by IRQF_NO_AUTOEN flag
@ 2021-04-07  8:59 Tian Tao
  2021-04-07  9:02 ` Vadim Pasternak
  2021-04-07 18:05 ` Hans de Goede
  0 siblings, 2 replies; 3+ messages in thread
From: Tian Tao @ 2021-04-07  8:59 UTC (permalink / raw)
  To: hdegoede, mgross, vadimp; +Cc: platform-driver-x86, Tian Tao

disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable because of requesting.

this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
is being merged: https://lore.kernel.org/patchwork/patch/1388765/

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/platform/mellanox/mlxreg-hotplug.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c
index b013445..a9db2f3 100644
--- a/drivers/platform/mellanox/mlxreg-hotplug.c
+++ b/drivers/platform/mellanox/mlxreg-hotplug.c
@@ -683,13 +683,13 @@ static int mlxreg_hotplug_probe(struct platform_device *pdev)
 
 	err = devm_request_irq(&pdev->dev, priv->irq,
 			       mlxreg_hotplug_irq_handler, IRQF_TRIGGER_FALLING
-			       | IRQF_SHARED, "mlxreg-hotplug", priv);
+			       | IRQF_SHARED | IRQF_NO_AUTOEN,
+			       "mlxreg-hotplug", priv);
 	if (err) {
 		dev_err(&pdev->dev, "Failed to request irq: %d\n", err);
 		return err;
 	}
 
-	disable_irq(priv->irq);
 	spin_lock_init(&priv->lock);
 	INIT_DELAYED_WORK(&priv->dwork_irq, mlxreg_hotplug_work_handler);
 	dev_set_drvdata(&pdev->dev, priv);
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] platform/mellanox: mlxreg-hotplug: move to use request_irq by IRQF_NO_AUTOEN flag
  2021-04-07  8:59 [PATCH] platform/mellanox: mlxreg-hotplug: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
@ 2021-04-07  9:02 ` Vadim Pasternak
  2021-04-07 18:05 ` Hans de Goede
  1 sibling, 0 replies; 3+ messages in thread
From: Vadim Pasternak @ 2021-04-07  9:02 UTC (permalink / raw)
  To: Tian Tao, hdegoede, mgross; +Cc: platform-driver-x86



-----Original Message-----
From: Tian Tao <tiantao6@hisilicon.com> 
Sent: Wednesday, April 7, 2021 12:00 PM
To: hdegoede@redhat.com; mgross@linux.intel.com; Vadim Pasternak <vadimp@nvidia.com>
Cc: platform-driver-x86@vger.kernel.org; Tian Tao <tiantao6@hisilicon.com>
Subject: [PATCH] platform/mellanox: mlxreg-hotplug: move to use request_irq by IRQF_NO_AUTOEN flag

disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable because of requesting.

this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which is being merged: https://lore.kernel.org/patchwork/patch/1388765/

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

Acked-by: Vadim Pasternak <vadimp@nvidia.com>

---
 drivers/platform/mellanox/mlxreg-hotplug.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c
index b013445..a9db2f3 100644
--- a/drivers/platform/mellanox/mlxreg-hotplug.c
+++ b/drivers/platform/mellanox/mlxreg-hotplug.c
@@ -683,13 +683,13 @@ static int mlxreg_hotplug_probe(struct platform_device *pdev)
 
 	err = devm_request_irq(&pdev->dev, priv->irq,
 			       mlxreg_hotplug_irq_handler, IRQF_TRIGGER_FALLING
-			       | IRQF_SHARED, "mlxreg-hotplug", priv);
+			       | IRQF_SHARED | IRQF_NO_AUTOEN,
+			       "mlxreg-hotplug", priv);
 	if (err) {
 		dev_err(&pdev->dev, "Failed to request irq: %d\n", err);
 		return err;
 	}
 
-	disable_irq(priv->irq);
 	spin_lock_init(&priv->lock);
 	INIT_DELAYED_WORK(&priv->dwork_irq, mlxreg_hotplug_work_handler);
 	dev_set_drvdata(&pdev->dev, priv);
--
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] platform/mellanox: mlxreg-hotplug: move to use request_irq by IRQF_NO_AUTOEN flag
  2021-04-07  8:59 [PATCH] platform/mellanox: mlxreg-hotplug: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
  2021-04-07  9:02 ` Vadim Pasternak
@ 2021-04-07 18:05 ` Hans de Goede
  1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2021-04-07 18:05 UTC (permalink / raw)
  To: Tian Tao, mgross, vadimp; +Cc: platform-driver-x86

Hi,

On 4/7/21 10:59 AM, Tian Tao wrote:
> disable_irq() after request_irq() still has a time gap in which
> interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> disable IRQ auto-enable because of requesting.
> 
> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
> is being merged: https://lore.kernel.org/patchwork/patch/1388765/
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/mellanox/mlxreg-hotplug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c
> index b013445..a9db2f3 100644
> --- a/drivers/platform/mellanox/mlxreg-hotplug.c
> +++ b/drivers/platform/mellanox/mlxreg-hotplug.c
> @@ -683,13 +683,13 @@ static int mlxreg_hotplug_probe(struct platform_device *pdev)
>  
>  	err = devm_request_irq(&pdev->dev, priv->irq,
>  			       mlxreg_hotplug_irq_handler, IRQF_TRIGGER_FALLING
> -			       | IRQF_SHARED, "mlxreg-hotplug", priv);
> +			       | IRQF_SHARED | IRQF_NO_AUTOEN,
> +			       "mlxreg-hotplug", priv);
>  	if (err) {
>  		dev_err(&pdev->dev, "Failed to request irq: %d\n", err);
>  		return err;
>  	}
>  
> -	disable_irq(priv->irq);
>  	spin_lock_init(&priv->lock);
>  	INIT_DELAYED_WORK(&priv->dwork_irq, mlxreg_hotplug_work_handler);
>  	dev_set_drvdata(&pdev->dev, priv);
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-07 18:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07  8:59 [PATCH] platform/mellanox: mlxreg-hotplug: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-04-07  9:02 ` Vadim Pasternak
2021-04-07 18:05 ` Hans de Goede

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).