* [PATCH v1 1/1 RESEND] platform/mellanox: add firmware reset support
@ 2023-04-05 13:16 Khalil Blaiech
2023-04-05 14:33 ` Hans de Goede
2023-04-06 12:28 ` Hans de Goede
0 siblings, 2 replies; 6+ messages in thread
From: Khalil Blaiech @ 2023-04-05 13:16 UTC (permalink / raw)
To: hdegoede, markgross, vadimp
Cc: platform-driver-x86, davthompson, kblaiech, linux-kernel
Add a new sysfs to initiate firmware reset in isolation mode.
Reviewed-by: David Thompson <davthompson@nvidia.com>
Signed-off-by: Khalil Blaiech <kblaiech@nvidia.com>
---
drivers/platform/mellanox/mlxbf-bootctl.c | 19 +++++++++++++++++++
drivers/platform/mellanox/mlxbf-bootctl.h | 6 ++++++
2 files changed, 25 insertions(+)
diff --git a/drivers/platform/mellanox/mlxbf-bootctl.c b/drivers/platform/mellanox/mlxbf-bootctl.c
index 1c7a288b59a5..5e41c270195c 100644
--- a/drivers/platform/mellanox/mlxbf-bootctl.c
+++ b/drivers/platform/mellanox/mlxbf-bootctl.c
@@ -244,11 +244,29 @@ static ssize_t secure_boot_fuse_state_show(struct device *dev,
return buf_len;
}
+static ssize_t fw_reset_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t count)
+{
+ unsigned long key;
+ int err;
+
+ err = kstrtoul(buf, 16, &key);
+ if (err)
+ return err;
+
+ if (mlxbf_bootctl_smc(MLXBF_BOOTCTL_FW_RESET, key) < 0)
+ return -EINVAL;
+
+ return count;
+}
+
static DEVICE_ATTR_RW(post_reset_wdog);
static DEVICE_ATTR_RW(reset_action);
static DEVICE_ATTR_RW(second_reset_action);
static DEVICE_ATTR_RO(lifecycle_state);
static DEVICE_ATTR_RO(secure_boot_fuse_state);
+static DEVICE_ATTR_WO(fw_reset);
static struct attribute *mlxbf_bootctl_attrs[] = {
&dev_attr_post_reset_wdog.attr,
@@ -256,6 +274,7 @@ static struct attribute *mlxbf_bootctl_attrs[] = {
&dev_attr_second_reset_action.attr,
&dev_attr_lifecycle_state.attr,
&dev_attr_secure_boot_fuse_state.attr,
+ &dev_attr_fw_reset.attr,
NULL
};
diff --git a/drivers/platform/mellanox/mlxbf-bootctl.h b/drivers/platform/mellanox/mlxbf-bootctl.h
index 148fdb43b435..b48243f60a59 100644
--- a/drivers/platform/mellanox/mlxbf-bootctl.h
+++ b/drivers/platform/mellanox/mlxbf-bootctl.h
@@ -75,6 +75,12 @@
#define MLXBF_BOOTCTL_GET_DIMM_INFO 0x82000008
+/*
+ * Initiate Firmware Reset via TYU. This might be invoked during the reset
+ * flow in isolation mode.
+ */
+#define MLXBF_BOOTCTL_FW_RESET 0x8200000D
+
/* SMC function IDs for SiP Service queries */
#define MLXBF_BOOTCTL_SIP_SVC_CALL_COUNT 0x8200ff00
#define MLXBF_BOOTCTL_SIP_SVC_UID 0x8200ff01
--
2.30.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1 1/1 RESEND] platform/mellanox: add firmware reset support
2023-04-05 13:16 [PATCH v1 1/1 RESEND] platform/mellanox: add firmware reset support Khalil Blaiech
@ 2023-04-05 14:33 ` Hans de Goede
2023-04-05 14:34 ` Hans de Goede
2023-04-05 14:39 ` Khalil Blaiech
2023-04-06 12:28 ` Hans de Goede
1 sibling, 2 replies; 6+ messages in thread
From: Hans de Goede @ 2023-04-05 14:33 UTC (permalink / raw)
To: Khalil Blaiech, markgross, vadimp
Cc: platform-driver-x86, davthompson, linux-kernel
Hi Khalil,
On 4/5/23 15:16, Khalil Blaiech wrote:
> Add a new sysfs to initiate firmware reset in isolation mode.
>
> Reviewed-by: David Thompson <davthompson@nvidia.com>
> Signed-off-by: Khalil Blaiech <kblaiech@nvidia.com>
Why are you resending this less then 24 hours after the initial submission ?
Regards,
Hans
> ---
> drivers/platform/mellanox/mlxbf-bootctl.c | 19 +++++++++++++++++++
> drivers/platform/mellanox/mlxbf-bootctl.h | 6 ++++++
> 2 files changed, 25 insertions(+)
>
> diff --git a/drivers/platform/mellanox/mlxbf-bootctl.c b/drivers/platform/mellanox/mlxbf-bootctl.c
> index 1c7a288b59a5..5e41c270195c 100644
> --- a/drivers/platform/mellanox/mlxbf-bootctl.c
> +++ b/drivers/platform/mellanox/mlxbf-bootctl.c
> @@ -244,11 +244,29 @@ static ssize_t secure_boot_fuse_state_show(struct device *dev,
> return buf_len;
> }
>
> +static ssize_t fw_reset_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t count)
> +{
> + unsigned long key;
> + int err;
> +
> + err = kstrtoul(buf, 16, &key);
> + if (err)
> + return err;
> +
> + if (mlxbf_bootctl_smc(MLXBF_BOOTCTL_FW_RESET, key) < 0)
> + return -EINVAL;
> +
> + return count;
> +}
> +
> static DEVICE_ATTR_RW(post_reset_wdog);
> static DEVICE_ATTR_RW(reset_action);
> static DEVICE_ATTR_RW(second_reset_action);
> static DEVICE_ATTR_RO(lifecycle_state);
> static DEVICE_ATTR_RO(secure_boot_fuse_state);
> +static DEVICE_ATTR_WO(fw_reset);
>
> static struct attribute *mlxbf_bootctl_attrs[] = {
> &dev_attr_post_reset_wdog.attr,
> @@ -256,6 +274,7 @@ static struct attribute *mlxbf_bootctl_attrs[] = {
> &dev_attr_second_reset_action.attr,
> &dev_attr_lifecycle_state.attr,
> &dev_attr_secure_boot_fuse_state.attr,
> + &dev_attr_fw_reset.attr,
> NULL
> };
>
> diff --git a/drivers/platform/mellanox/mlxbf-bootctl.h b/drivers/platform/mellanox/mlxbf-bootctl.h
> index 148fdb43b435..b48243f60a59 100644
> --- a/drivers/platform/mellanox/mlxbf-bootctl.h
> +++ b/drivers/platform/mellanox/mlxbf-bootctl.h
> @@ -75,6 +75,12 @@
>
> #define MLXBF_BOOTCTL_GET_DIMM_INFO 0x82000008
>
> +/*
> + * Initiate Firmware Reset via TYU. This might be invoked during the reset
> + * flow in isolation mode.
> + */
> +#define MLXBF_BOOTCTL_FW_RESET 0x8200000D
> +
> /* SMC function IDs for SiP Service queries */
> #define MLXBF_BOOTCTL_SIP_SVC_CALL_COUNT 0x8200ff00
> #define MLXBF_BOOTCTL_SIP_SVC_UID 0x8200ff01
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1 1/1 RESEND] platform/mellanox: add firmware reset support
2023-04-05 14:33 ` Hans de Goede
@ 2023-04-05 14:34 ` Hans de Goede
2023-04-05 14:40 ` Khalil Blaiech
2023-04-05 14:39 ` Khalil Blaiech
1 sibling, 1 reply; 6+ messages in thread
From: Hans de Goede @ 2023-04-05 14:34 UTC (permalink / raw)
To: Khalil Blaiech, markgross, vadimp
Cc: platform-driver-x86, davthompson, linux-kernel
Hi,
On 4/5/23 16:33, Hans de Goede wrote:
> Hi Khalil,
>
> On 4/5/23 15:16, Khalil Blaiech wrote:
>> Add a new sysfs to initiate firmware reset in isolation mode.
>>
>> Reviewed-by: David Thompson <davthompson@nvidia.com>
>> Signed-off-by: Khalil Blaiech <kblaiech@nvidia.com>
>
> Why are you resending this less then 24 hours after the initial submission ?
Never mind, I see you added a missing Cc: platform-driver-x86@vger.kernel.org
which is good.
Next time please add a little note to the resend explaining why you
are resending it though.
Regards,
Hans
>> ---
>> drivers/platform/mellanox/mlxbf-bootctl.c | 19 +++++++++++++++++++
>> drivers/platform/mellanox/mlxbf-bootctl.h | 6 ++++++
>> 2 files changed, 25 insertions(+)
>>
>> diff --git a/drivers/platform/mellanox/mlxbf-bootctl.c b/drivers/platform/mellanox/mlxbf-bootctl.c
>> index 1c7a288b59a5..5e41c270195c 100644
>> --- a/drivers/platform/mellanox/mlxbf-bootctl.c
>> +++ b/drivers/platform/mellanox/mlxbf-bootctl.c
>> @@ -244,11 +244,29 @@ static ssize_t secure_boot_fuse_state_show(struct device *dev,
>> return buf_len;
>> }
>>
>> +static ssize_t fw_reset_store(struct device *dev,
>> + struct device_attribute *attr,
>> + const char *buf, size_t count)
>> +{
>> + unsigned long key;
>> + int err;
>> +
>> + err = kstrtoul(buf, 16, &key);
>> + if (err)
>> + return err;
>> +
>> + if (mlxbf_bootctl_smc(MLXBF_BOOTCTL_FW_RESET, key) < 0)
>> + return -EINVAL;
>> +
>> + return count;
>> +}
>> +
>> static DEVICE_ATTR_RW(post_reset_wdog);
>> static DEVICE_ATTR_RW(reset_action);
>> static DEVICE_ATTR_RW(second_reset_action);
>> static DEVICE_ATTR_RO(lifecycle_state);
>> static DEVICE_ATTR_RO(secure_boot_fuse_state);
>> +static DEVICE_ATTR_WO(fw_reset);
>>
>> static struct attribute *mlxbf_bootctl_attrs[] = {
>> &dev_attr_post_reset_wdog.attr,
>> @@ -256,6 +274,7 @@ static struct attribute *mlxbf_bootctl_attrs[] = {
>> &dev_attr_second_reset_action.attr,
>> &dev_attr_lifecycle_state.attr,
>> &dev_attr_secure_boot_fuse_state.attr,
>> + &dev_attr_fw_reset.attr,
>> NULL
>> };
>>
>> diff --git a/drivers/platform/mellanox/mlxbf-bootctl.h b/drivers/platform/mellanox/mlxbf-bootctl.h
>> index 148fdb43b435..b48243f60a59 100644
>> --- a/drivers/platform/mellanox/mlxbf-bootctl.h
>> +++ b/drivers/platform/mellanox/mlxbf-bootctl.h
>> @@ -75,6 +75,12 @@
>>
>> #define MLXBF_BOOTCTL_GET_DIMM_INFO 0x82000008
>>
>> +/*
>> + * Initiate Firmware Reset via TYU. This might be invoked during the reset
>> + * flow in isolation mode.
>> + */
>> +#define MLXBF_BOOTCTL_FW_RESET 0x8200000D
>> +
>> /* SMC function IDs for SiP Service queries */
>> #define MLXBF_BOOTCTL_SIP_SVC_CALL_COUNT 0x8200ff00
>> #define MLXBF_BOOTCTL_SIP_SVC_UID 0x8200ff01
>
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH v1 1/1 RESEND] platform/mellanox: add firmware reset support
2023-04-05 14:34 ` Hans de Goede
@ 2023-04-05 14:40 ` Khalil Blaiech
0 siblings, 0 replies; 6+ messages in thread
From: Khalil Blaiech @ 2023-04-05 14:40 UTC (permalink / raw)
To: Hans de Goede, markgross, Vadim Pasternak
Cc: platform-driver-x86, David Thompson, linux-kernel
Understood. And sorry about that.
Thanks Hans
-----Original Message-----
From: Hans de Goede <hdegoede@redhat.com>
Sent: Wednesday, April 5, 2023 10:34 AM
To: Khalil Blaiech <kblaiech@nvidia.com>; markgross@kernel.org; Vadim Pasternak <vadimp@nvidia.com>
Cc: platform-driver-x86@vger.kernel.org; David Thompson <davthompson@nvidia.com>; linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1 RESEND] platform/mellanox: add firmware reset support
Hi,
On 4/5/23 16:33, Hans de Goede wrote:
> Hi Khalil,
>
> On 4/5/23 15:16, Khalil Blaiech wrote:
>> Add a new sysfs to initiate firmware reset in isolation mode.
>>
>> Reviewed-by: David Thompson <davthompson@nvidia.com>
>> Signed-off-by: Khalil Blaiech <kblaiech@nvidia.com>
>
> Why are you resending this less then 24 hours after the initial submission ?
Never mind, I see you added a missing Cc: platform-driver-x86@vger.kernel.org
which is good.
Next time please add a little note to the resend explaining why you are resending it though.
Regards,
Hans
>> ---
>> drivers/platform/mellanox/mlxbf-bootctl.c | 19 +++++++++++++++++++
>> drivers/platform/mellanox/mlxbf-bootctl.h | 6 ++++++
>> 2 files changed, 25 insertions(+)
>>
>> diff --git a/drivers/platform/mellanox/mlxbf-bootctl.c
>> b/drivers/platform/mellanox/mlxbf-bootctl.c
>> index 1c7a288b59a5..5e41c270195c 100644
>> --- a/drivers/platform/mellanox/mlxbf-bootctl.c
>> +++ b/drivers/platform/mellanox/mlxbf-bootctl.c
>> @@ -244,11 +244,29 @@ static ssize_t secure_boot_fuse_state_show(struct device *dev,
>> return buf_len;
>> }
>>
>> +static ssize_t fw_reset_store(struct device *dev,
>> + struct device_attribute *attr,
>> + const char *buf, size_t count) {
>> + unsigned long key;
>> + int err;
>> +
>> + err = kstrtoul(buf, 16, &key);
>> + if (err)
>> + return err;
>> +
>> + if (mlxbf_bootctl_smc(MLXBF_BOOTCTL_FW_RESET, key) < 0)
>> + return -EINVAL;
>> +
>> + return count;
>> +}
>> +
>> static DEVICE_ATTR_RW(post_reset_wdog); static
>> DEVICE_ATTR_RW(reset_action); static
>> DEVICE_ATTR_RW(second_reset_action);
>> static DEVICE_ATTR_RO(lifecycle_state); static
>> DEVICE_ATTR_RO(secure_boot_fuse_state);
>> +static DEVICE_ATTR_WO(fw_reset);
>>
>> static struct attribute *mlxbf_bootctl_attrs[] = {
>> &dev_attr_post_reset_wdog.attr,
>> @@ -256,6 +274,7 @@ static struct attribute *mlxbf_bootctl_attrs[] = {
>> &dev_attr_second_reset_action.attr,
>> &dev_attr_lifecycle_state.attr,
>> &dev_attr_secure_boot_fuse_state.attr,
>> + &dev_attr_fw_reset.attr,
>> NULL
>> };
>>
>> diff --git a/drivers/platform/mellanox/mlxbf-bootctl.h
>> b/drivers/platform/mellanox/mlxbf-bootctl.h
>> index 148fdb43b435..b48243f60a59 100644
>> --- a/drivers/platform/mellanox/mlxbf-bootctl.h
>> +++ b/drivers/platform/mellanox/mlxbf-bootctl.h
>> @@ -75,6 +75,12 @@
>>
>> #define MLXBF_BOOTCTL_GET_DIMM_INFO 0x82000008
>>
>> +/*
>> + * Initiate Firmware Reset via TYU. This might be invoked during the
>> +reset
>> + * flow in isolation mode.
>> + */
>> +#define MLXBF_BOOTCTL_FW_RESET 0x8200000D
>> +
>> /* SMC function IDs for SiP Service queries */
>> #define MLXBF_BOOTCTL_SIP_SVC_CALL_COUNT 0x8200ff00
>> #define MLXBF_BOOTCTL_SIP_SVC_UID 0x8200ff01
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v1 1/1 RESEND] platform/mellanox: add firmware reset support
2023-04-05 14:33 ` Hans de Goede
2023-04-05 14:34 ` Hans de Goede
@ 2023-04-05 14:39 ` Khalil Blaiech
1 sibling, 0 replies; 6+ messages in thread
From: Khalil Blaiech @ 2023-04-05 14:39 UTC (permalink / raw)
To: Hans de Goede, markgross, Vadim Pasternak
Cc: platform-driver-x86, David Thompson, linux-kernel
Hi Hans,
Actually, my first patch was posted back on Feb 8, 2023.
On April 4, I resent the patch without RESEND tag, thus the new patch in less than 24h.
Apologies if I did something wrong.
Thanks,
-Khalil
-----Original Message-----
From: Hans de Goede <hdegoede@redhat.com>
Sent: Wednesday, April 5, 2023 10:33 AM
To: Khalil Blaiech <kblaiech@nvidia.com>; markgross@kernel.org; Vadim Pasternak <vadimp@nvidia.com>
Cc: platform-driver-x86@vger.kernel.org; David Thompson <davthompson@nvidia.com>; linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1 RESEND] platform/mellanox: add firmware reset support
Hi Khalil,
On 4/5/23 15:16, Khalil Blaiech wrote:
> Add a new sysfs to initiate firmware reset in isolation mode.
>
> Reviewed-by: David Thompson <davthompson@nvidia.com>
> Signed-off-by: Khalil Blaiech <kblaiech@nvidia.com>
Why are you resending this less then 24 hours after the initial submission ?
Regards,
Hans
> ---
> drivers/platform/mellanox/mlxbf-bootctl.c | 19 +++++++++++++++++++
> drivers/platform/mellanox/mlxbf-bootctl.h | 6 ++++++
> 2 files changed, 25 insertions(+)
>
> diff --git a/drivers/platform/mellanox/mlxbf-bootctl.c
> b/drivers/platform/mellanox/mlxbf-bootctl.c
> index 1c7a288b59a5..5e41c270195c 100644
> --- a/drivers/platform/mellanox/mlxbf-bootctl.c
> +++ b/drivers/platform/mellanox/mlxbf-bootctl.c
> @@ -244,11 +244,29 @@ static ssize_t secure_boot_fuse_state_show(struct device *dev,
> return buf_len;
> }
>
> +static ssize_t fw_reset_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t count) {
> + unsigned long key;
> + int err;
> +
> + err = kstrtoul(buf, 16, &key);
> + if (err)
> + return err;
> +
> + if (mlxbf_bootctl_smc(MLXBF_BOOTCTL_FW_RESET, key) < 0)
> + return -EINVAL;
> +
> + return count;
> +}
> +
> static DEVICE_ATTR_RW(post_reset_wdog); static
> DEVICE_ATTR_RW(reset_action); static
> DEVICE_ATTR_RW(second_reset_action);
> static DEVICE_ATTR_RO(lifecycle_state); static
> DEVICE_ATTR_RO(secure_boot_fuse_state);
> +static DEVICE_ATTR_WO(fw_reset);
>
> static struct attribute *mlxbf_bootctl_attrs[] = {
> &dev_attr_post_reset_wdog.attr,
> @@ -256,6 +274,7 @@ static struct attribute *mlxbf_bootctl_attrs[] = {
> &dev_attr_second_reset_action.attr,
> &dev_attr_lifecycle_state.attr,
> &dev_attr_secure_boot_fuse_state.attr,
> + &dev_attr_fw_reset.attr,
> NULL
> };
>
> diff --git a/drivers/platform/mellanox/mlxbf-bootctl.h
> b/drivers/platform/mellanox/mlxbf-bootctl.h
> index 148fdb43b435..b48243f60a59 100644
> --- a/drivers/platform/mellanox/mlxbf-bootctl.h
> +++ b/drivers/platform/mellanox/mlxbf-bootctl.h
> @@ -75,6 +75,12 @@
>
> #define MLXBF_BOOTCTL_GET_DIMM_INFO 0x82000008
>
> +/*
> + * Initiate Firmware Reset via TYU. This might be invoked during the
> +reset
> + * flow in isolation mode.
> + */
> +#define MLXBF_BOOTCTL_FW_RESET 0x8200000D
> +
> /* SMC function IDs for SiP Service queries */
> #define MLXBF_BOOTCTL_SIP_SVC_CALL_COUNT 0x8200ff00
> #define MLXBF_BOOTCTL_SIP_SVC_UID 0x8200ff01
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1 RESEND] platform/mellanox: add firmware reset support
2023-04-05 13:16 [PATCH v1 1/1 RESEND] platform/mellanox: add firmware reset support Khalil Blaiech
2023-04-05 14:33 ` Hans de Goede
@ 2023-04-06 12:28 ` Hans de Goede
1 sibling, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2023-04-06 12:28 UTC (permalink / raw)
To: Khalil Blaiech, markgross, vadimp
Cc: platform-driver-x86, davthompson, linux-kernel
Hi,
On 4/5/23 15:16, Khalil Blaiech wrote:
> Add a new sysfs to initiate firmware reset in isolation mode.
>
> Reviewed-by: David Thompson <davthompson@nvidia.com>
> Signed-off-by: Khalil Blaiech <kblaiech@nvidia.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/mellanox/mlxbf-bootctl.c | 19 +++++++++++++++++++
> drivers/platform/mellanox/mlxbf-bootctl.h | 6 ++++++
> 2 files changed, 25 insertions(+)
>
> diff --git a/drivers/platform/mellanox/mlxbf-bootctl.c b/drivers/platform/mellanox/mlxbf-bootctl.c
> index 1c7a288b59a5..5e41c270195c 100644
> --- a/drivers/platform/mellanox/mlxbf-bootctl.c
> +++ b/drivers/platform/mellanox/mlxbf-bootctl.c
> @@ -244,11 +244,29 @@ static ssize_t secure_boot_fuse_state_show(struct device *dev,
> return buf_len;
> }
>
> +static ssize_t fw_reset_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t count)
> +{
> + unsigned long key;
> + int err;
> +
> + err = kstrtoul(buf, 16, &key);
> + if (err)
> + return err;
> +
> + if (mlxbf_bootctl_smc(MLXBF_BOOTCTL_FW_RESET, key) < 0)
> + return -EINVAL;
> +
> + return count;
> +}
> +
> static DEVICE_ATTR_RW(post_reset_wdog);
> static DEVICE_ATTR_RW(reset_action);
> static DEVICE_ATTR_RW(second_reset_action);
> static DEVICE_ATTR_RO(lifecycle_state);
> static DEVICE_ATTR_RO(secure_boot_fuse_state);
> +static DEVICE_ATTR_WO(fw_reset);
>
> static struct attribute *mlxbf_bootctl_attrs[] = {
> &dev_attr_post_reset_wdog.attr,
> @@ -256,6 +274,7 @@ static struct attribute *mlxbf_bootctl_attrs[] = {
> &dev_attr_second_reset_action.attr,
> &dev_attr_lifecycle_state.attr,
> &dev_attr_secure_boot_fuse_state.attr,
> + &dev_attr_fw_reset.attr,
> NULL
> };
>
> diff --git a/drivers/platform/mellanox/mlxbf-bootctl.h b/drivers/platform/mellanox/mlxbf-bootctl.h
> index 148fdb43b435..b48243f60a59 100644
> --- a/drivers/platform/mellanox/mlxbf-bootctl.h
> +++ b/drivers/platform/mellanox/mlxbf-bootctl.h
> @@ -75,6 +75,12 @@
>
> #define MLXBF_BOOTCTL_GET_DIMM_INFO 0x82000008
>
> +/*
> + * Initiate Firmware Reset via TYU. This might be invoked during the reset
> + * flow in isolation mode.
> + */
> +#define MLXBF_BOOTCTL_FW_RESET 0x8200000D
> +
> /* SMC function IDs for SiP Service queries */
> #define MLXBF_BOOTCTL_SIP_SVC_CALL_COUNT 0x8200ff00
> #define MLXBF_BOOTCTL_SIP_SVC_UID 0x8200ff01
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-06 12:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-05 13:16 [PATCH v1 1/1 RESEND] platform/mellanox: add firmware reset support Khalil Blaiech
2023-04-05 14:33 ` Hans de Goede
2023-04-05 14:34 ` Hans de Goede
2023-04-05 14:40 ` Khalil Blaiech
2023-04-05 14:39 ` Khalil Blaiech
2023-04-06 12:28 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).