qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: luoyonggang@gmail.com, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P . Berrang茅" <berrange@redhat.com>
Subject: Re: [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja
Date: Tue, 25 Aug 2020 16:42:48 -0500	[thread overview]
Message-ID: <05e2badc-19b5-6f47-73f8-de30732fa236@redhat.com> (raw)
In-Reply-To: <20200825165341.520-1-luoyonggang@gmail.com>

On 8/25/20 11:53 AM, luoyonggang@gmail.com wrote:
> From: Yonggang Luo <luoyonggang@gmail.com>
> 
> SIMPLE_PATH_RE should match the full path token.
> Or the $ and : contained in path would not matched if the path are start with C:/ and E:/
> ---

Missing a Signed-off-by tag.  Without that, we cannot apply it.

Also missing a 0/4 cover letter; less essential, but useful for 
continuous integration tools and for replying to the series as a whole.

More patch submission hints can be found at 
https://wiki.qemu.org/Contribute/SubmitAPatch

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



  parent reply	other threads:[~2020-08-25 21:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 16:53 [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja luoyonggang
2020-08-25 16:53 ` [PATCH 2/4] meson: fixes relpath may fail on win32 luoyonggang
2020-08-25 21:31   ` Mark Cave-Ayland
2020-08-26  6:46     ` Paolo Bonzini
2020-08-25 16:53 ` [PATCH 3/4] meson: Mingw64 gcc doesn't recognize system include_type for sdl2 luoyonggang
2020-08-25 21:38   ` Mark Cave-Ayland
2020-08-26  6:48     ` Paolo Bonzini
2020-08-26  8:22       ` Daniel P. Berrangé
2020-08-25 16:53 ` [PATCH 4/4] configure: Fix include and linkage issue on msys2 luoyonggang
2020-08-25 21:55   ` Mark Cave-Ayland
2020-08-25 21:26 ` [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja Mark Cave-Ayland
2020-08-26  6:45   ` Paolo Bonzini
2020-08-27 16:05     ` Mark Cave-Ayland
2020-08-27 16:43       ` Paolo Bonzini
2020-08-25 21:42 ` Eric Blake [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-08-25 14:51 luoyonggang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05e2badc-19b5-6f47-73f8-de30732fa236@redhat.com \
    --to=eblake@redhat.com \
    --cc=berrange@redhat.com \
    --cc=luoyonggang@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).