qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: luoyonggang@gmail.com,
	"Daniel P . Berrang茅" <berrange@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH 2/4] meson: fixes relpath may fail on win32.
Date: Wed, 26 Aug 2020 08:46:46 +0200	[thread overview]
Message-ID: <CABgObfZUkzym4-SbuAtzh-Hkhg9=ZVq==UEFutmcrpKP5x1r_w@mail.gmail.com> (raw)
In-Reply-To: <acdc6a3d-5188-e906-bc86-b0090ffe5a42@ilande.co.uk>

On Tue, Aug 25, 2020 at 11:31 PM Mark Cave-Ayland
<mark.cave-ayland@ilande.co.uk> wrote:
> On 25/08/2020 17:53, luoyonggang@gmail.com wrote:
>
> > From: Yonggang Luo <luoyonggang@gmail.com>
> >
> > On win32, os.path.relpath would raise exception when do the following relpath:
> > C:/msys64/mingw64/x.exe relative to E:/path/qemu-build would fail.
> > So we try catch it for stopping it from raise exception on msys2
> I don't think this is relevant in my particular environment, however it didn't seem
> to break the build. I'm curious as to why os.path.relpath throws an exception in this
> particular case on Windows though - can you give us a bit more information about the
> Exception that is being thrown?

I think it's because it's impossible to make a relative path between
two different drives.

The patch is correct but is missing the Signed-off-by line.

Paolo



  reply	other threads:[~2020-08-26  6:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 16:53 [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja luoyonggang
2020-08-25 16:53 ` [PATCH 2/4] meson: fixes relpath may fail on win32 luoyonggang
2020-08-25 21:31   ` Mark Cave-Ayland
2020-08-26  6:46     ` Paolo Bonzini [this message]
2020-08-25 16:53 ` [PATCH 3/4] meson: Mingw64 gcc doesn't recognize system include_type for sdl2 luoyonggang
2020-08-25 21:38   ` Mark Cave-Ayland
2020-08-26  6:48     ` Paolo Bonzini
2020-08-26  8:22       ` Daniel P. Berrangé
2020-08-25 16:53 ` [PATCH 4/4] configure: Fix include and linkage issue on msys2 luoyonggang
2020-08-25 21:55   ` Mark Cave-Ayland
2020-08-25 21:26 ` [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja Mark Cave-Ayland
2020-08-26  6:45   ` Paolo Bonzini
2020-08-27 16:05     ` Mark Cave-Ayland
2020-08-27 16:43       ` Paolo Bonzini
2020-08-25 21:42 ` Eric Blake
  -- strict thread matches above, loose matches on Subject: below --
2020-08-25 14:51 luoyonggang
2020-08-25 14:51 ` [PATCH 2/4] meson: fixes relpath may fail on win32 luoyonggang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABgObfZUkzym4-SbuAtzh-Hkhg9=ZVq==UEFutmcrpKP5x1r_w@mail.gmail.com' \
    --to=pbonzini@redhat.com \
    --cc=berrange@redhat.com \
    --cc=luoyonggang@gmail.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).