From: Paolo Bonzini <pbonzini@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
luoyonggang@gmail.com,
"Daniel P . Berrang茅" <berrange@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH 3/4] meson: Mingw64 gcc doesn't recognize system include_type for sdl2
Date: Wed, 26 Aug 2020 08:48:22 +0200 [thread overview]
Message-ID: <CABgObfZ49Y2nJCx9jOdUsDe1SPGd5NBcSVOdxf5fpnWxSU15sA@mail.gmail.com> (raw)
In-Reply-To: <b4d17b13-2a11-58b4-0e5d-8ca95ec3068b@ilande.co.uk>
On Tue, Aug 25, 2020 at 11:38 PM Mark Cave-Ayland
<mark.cave-ayland@ilande.co.uk> wrote:
> Marc-André had a query about why this is marked as a system include, however I can
> confirm that it fixes the missing "SDL.h" issue during build.
It was marked as a system include in an attempt to work around the SDL
2.0.8 bug that requires -Wno-undef. In general we enable lots of
warnings and sometimes they trip dependencies, so using include_type:
'system' in principle makes sense. But if it doesn't work with
Windows, it's not a regression to remove it.
Paolo
next prev parent reply other threads:[~2020-08-26 6:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 16:53 [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja luoyonggang
2020-08-25 16:53 ` [PATCH 2/4] meson: fixes relpath may fail on win32 luoyonggang
2020-08-25 21:31 ` Mark Cave-Ayland
2020-08-26 6:46 ` Paolo Bonzini
2020-08-25 16:53 ` [PATCH 3/4] meson: Mingw64 gcc doesn't recognize system include_type for sdl2 luoyonggang
2020-08-25 21:38 ` Mark Cave-Ayland
2020-08-26 6:48 ` Paolo Bonzini [this message]
2020-08-26 8:22 ` Daniel P. Berrangé
2020-08-25 16:53 ` [PATCH 4/4] configure: Fix include and linkage issue on msys2 luoyonggang
2020-08-25 21:55 ` Mark Cave-Ayland
2020-08-25 21:26 ` [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja Mark Cave-Ayland
2020-08-26 6:45 ` Paolo Bonzini
2020-08-27 16:05 ` Mark Cave-Ayland
2020-08-27 16:43 ` Paolo Bonzini
2020-08-25 21:42 ` Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2020-08-25 14:51 luoyonggang
2020-08-25 14:51 ` [PATCH 3/4] meson: Mingw64 gcc doesn't recognize system include_type for sdl2 luoyonggang
2020-08-25 14:49 [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja SIMPLE_PATH_RE should match the full path token. Or the $ and : contained in path would not matched if the path are start with C:/ and E:/ luoyonggang
2020-08-25 14:49 ` [PATCH 3/4] meson: Mingw64 gcc doesn't recognize system include_type for sdl2 luoyonggang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABgObfZ49Y2nJCx9jOdUsDe1SPGd5NBcSVOdxf5fpnWxSU15sA@mail.gmail.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=marcandre.lureau@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).