Re: [PATCH v3 00/14] hw/i2c/aspeed: I2C slave mode DMA RX w/ new regs

From: "Cédric Le Goater" <clg@kaod.org>
To: Peter Delevoryas <me@pjd.dev>
Cc: <peter.maydell@linaro.org>, <andrew@aj.id.au>, <joel@jms.id.au>,
	<cminyard@mvista.com>, <titusr@google.com>,
	<qemu-devel@nongnu.org>, <qemu-arm@nongnu.org>, <zhdaniel@fb.com>,
	<pdel@fb.com>
Subject: Re: [PATCH v3 00/14] hw/i2c/aspeed: I2C slave mode DMA RX w/ new regs
Date: Thu, 30 Jun 2022 08:13:11 +0200	[thread overview]
Message-ID: <115a8bb6-2e02-18da-4684-56660a8f65e6@kaod.org> (raw)
In-Reply-To: <20220630045133.32251-1-me@pjd.dev>

On 6/30/22 06:51, Peter Delevoryas wrote:
> From: Peter Delevoryas <pdel@fb.com>

It is good practice to keep the Reviewed/Tested/Acked tags sent on
the previous version of a patchset. I should have told you in v2.
For next time ! :)

Thanks,

C.

> v3:
> - hw/i2c/pmbus_device:
>    - Removed commit that resets the out buf.
>    - Removed IC_DEVICE_ID
>    - Added commit to allow devices to move to an idle state that
>      avoids enqueuing excess data into the out buf.
> - hw/sensor/isl_pmbus_vr:
>    - Added IC_DEVICE_ID commit just for voltage regulators.
>    - Added ISL69259 with an IC_DEVICE_ID.
> - hw/misc/aspeed_peci:
>    - Moved registers from .h to .c
>    - Replaced guest_error on interrupt disable case with trace
>      for all interrupts (not just when they're disabled).
>    - Removed leftover qemu_irq_raise
> 
> Thanks,
> Peter
> 
> Klaus Jensen (3):
>    hw/i2c: support multiple masters
>    hw/i2c: add asynchronous send
>    hw/i2c/aspeed: add slave device in old register mode
> 
> Peter Delevoryas (11):
>    hw/i2c/aspeed: Fix R_I2CD_FUN_CTRL reference
>    hw/i2c/aspeed: Fix DMA len write-enable bit handling
>    hw/i2c/aspeed: Fix MASTER_EN missing error message
>    hw/i2c/aspeed: Add new-registers DMA slave mode RX support
>    hw/i2c/pmbus: Add idle state to return 0xff's
>    hw/sensor: Add IC_DEVICE_ID to ISL voltage regulators
>    hw/sensor: Add Renesas ISL69259 device model
>    hw/misc/aspeed: Add PECI controller
>    hw/misc/aspeed: Add fby35-sb-cpld
>    hw/misc/aspeed: Add intel-me
>    hw/arm/aspeed: Add oby35-cl machine
> 
>   MAINTAINERS                      |   2 +
>   hw/arm/aspeed.c                  |  48 +++++++
>   hw/arm/aspeed_ast10x0.c          |  12 ++
>   hw/arm/aspeed_ast2600.c          |  12 ++
>   hw/arm/aspeed_soc.c              |  13 ++
>   hw/arm/pxa2xx.c                  |   2 +
>   hw/display/sii9022.c             |   2 +
>   hw/display/ssd0303.c             |   2 +
>   hw/i2c/aspeed_i2c.c              | 234 +++++++++++++++++++++++++++----
>   hw/i2c/core.c                    |  70 ++++++++-
>   hw/i2c/pmbus_device.c            |   9 ++
>   hw/i2c/smbus_slave.c             |   4 +
>   hw/i2c/trace-events              |   2 +
>   hw/misc/aspeed_peci.c            | 152 ++++++++++++++++++++
>   hw/misc/fby35_sb_cpld.c          | 128 +++++++++++++++++
>   hw/misc/intel_me.c               | 162 +++++++++++++++++++++
>   hw/misc/meson.build              |   5 +-
>   hw/misc/trace-events             |  13 ++
>   hw/nvram/eeprom_at24c.c          |   2 +
>   hw/sensor/isl_pmbus_vr.c         |  40 ++++++
>   hw/sensor/lsm303dlhc_mag.c       |   2 +
>   include/hw/arm/aspeed_soc.h      |   3 +
>   include/hw/i2c/aspeed_i2c.h      |  11 ++
>   include/hw/i2c/i2c.h             |  30 ++++
>   include/hw/i2c/pmbus_device.h    |   7 +
>   include/hw/misc/aspeed_peci.h    |  29 ++++
>   include/hw/sensor/isl_pmbus_vr.h |   5 +
>   27 files changed, 971 insertions(+), 30 deletions(-)
>   create mode 100644 hw/misc/aspeed_peci.c
>   create mode 100644 hw/misc/fby35_sb_cpld.c
>   create mode 100644 hw/misc/intel_me.c
>   create mode 100644 include/hw/misc/aspeed_peci.h
> 