* [PATCH] hw/scsi: Fix scsi_bus_init_named() docstring
@ 2021-11-22 10:47 Philippe Mathieu-Daudé
2021-11-22 10:49 ` Peter Maydell
2021-12-15 10:29 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-11-22 10:47 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Fam Zheng, Philippe Mathieu-Daudé,
Peter Maydell, Paolo Bonzini
Commit 739e95f5741 ("scsi: Replace scsi_bus_new() with
scsi_bus_init(), scsi_bus_init_named()") forgot to rename
scsi_bus_init() in the function documentation string.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
include/hw/scsi/scsi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h
index a567a5ed86b..2ef80af6dca 100644
--- a/include/hw/scsi/scsi.h
+++ b/include/hw/scsi/scsi.h
@@ -158,7 +158,7 @@ struct SCSIBus {
* provided by the caller. It is the caller's responsibility to make
* sure that name does not clash with the name of any other bus in the
* system. Unless you need the new bus to have a specific name, you
- * should use scsi_bus_new() instead.
+ * should use scsi_bus_init() instead.
*/
void scsi_bus_init_named(SCSIBus *bus, size_t bus_size, DeviceState *host,
const SCSIBusInfo *info, const char *bus_name);
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/scsi: Fix scsi_bus_init_named() docstring
2021-11-22 10:47 [PATCH] hw/scsi: Fix scsi_bus_init_named() docstring Philippe Mathieu-Daudé
@ 2021-11-22 10:49 ` Peter Maydell
2021-12-15 10:29 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2021-11-22 10:49 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-trivial, Fam Zheng, qemu-devel, Paolo Bonzini
On Mon, 22 Nov 2021 at 10:47, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Commit 739e95f5741 ("scsi: Replace scsi_bus_new() with
> scsi_bus_init(), scsi_bus_init_named()") forgot to rename
> scsi_bus_init() in the function documentation string.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/hw/scsi/scsi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h
> index a567a5ed86b..2ef80af6dca 100644
> --- a/include/hw/scsi/scsi.h
> +++ b/include/hw/scsi/scsi.h
> @@ -158,7 +158,7 @@ struct SCSIBus {
> * provided by the caller. It is the caller's responsibility to make
> * sure that name does not clash with the name of any other bus in the
> * system. Unless you need the new bus to have a specific name, you
> - * should use scsi_bus_new() instead.
> + * should use scsi_bus_init() instead.
> */
> void scsi_bus_init_named(SCSIBus *bus, size_t bus_size, DeviceState *host,
> const SCSIBusInfo *info, const char *bus_name);
> --
> 2.31.1
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/scsi: Fix scsi_bus_init_named() docstring
2021-11-22 10:47 [PATCH] hw/scsi: Fix scsi_bus_init_named() docstring Philippe Mathieu-Daudé
2021-11-22 10:49 ` Peter Maydell
@ 2021-12-15 10:29 ` Philippe Mathieu-Daudé
2021-12-17 9:20 ` Paolo Bonzini
1 sibling, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-12-15 10:29 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Fam Zheng, Paolo Bonzini, Peter Maydell
Hi Laurent,
This patch is reviewed, can it go via your trivial tree?
On 11/22/21 11:47, Philippe Mathieu-Daudé wrote:
> Commit 739e95f5741 ("scsi: Replace scsi_bus_new() with
> scsi_bus_init(), scsi_bus_init_named()") forgot to rename
> scsi_bus_init() in the function documentation string.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/hw/scsi/scsi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h
> index a567a5ed86b..2ef80af6dca 100644
> --- a/include/hw/scsi/scsi.h
> +++ b/include/hw/scsi/scsi.h
> @@ -158,7 +158,7 @@ struct SCSIBus {
> * provided by the caller. It is the caller's responsibility to make
> * sure that name does not clash with the name of any other bus in the
> * system. Unless you need the new bus to have a specific name, you
> - * should use scsi_bus_new() instead.
> + * should use scsi_bus_init() instead.
> */
> void scsi_bus_init_named(SCSIBus *bus, size_t bus_size, DeviceState *host,
> const SCSIBusInfo *info, const char *bus_name);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/scsi: Fix scsi_bus_init_named() docstring
2021-12-15 10:29 ` Philippe Mathieu-Daudé
@ 2021-12-17 9:20 ` Paolo Bonzini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2021-12-17 9:20 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, Fam Zheng, Peter Maydell
On 12/15/21 11:29, Philippe Mathieu-Daudé wrote:
> Hi Laurent,
>
> This patch is reviewed, can it go via your trivial tree?
Queued, thanks.
Paolo
> On 11/22/21 11:47, Philippe Mathieu-Daudé wrote:
>> Commit 739e95f5741 ("scsi: Replace scsi_bus_new() with
>> scsi_bus_init(), scsi_bus_init_named()") forgot to rename
>> scsi_bus_init() in the function documentation string.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> include/hw/scsi/scsi.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h
>> index a567a5ed86b..2ef80af6dca 100644
>> --- a/include/hw/scsi/scsi.h
>> +++ b/include/hw/scsi/scsi.h
>> @@ -158,7 +158,7 @@ struct SCSIBus {
>> * provided by the caller. It is the caller's responsibility to make
>> * sure that name does not clash with the name of any other bus in the
>> * system. Unless you need the new bus to have a specific name, you
>> - * should use scsi_bus_new() instead.
>> + * should use scsi_bus_init() instead.
>> */
>> void scsi_bus_init_named(SCSIBus *bus, size_t bus_size, DeviceState *host,
>> const SCSIBusInfo *info, const char *bus_name);
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-17 9:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-22 10:47 [PATCH] hw/scsi: Fix scsi_bus_init_named() docstring Philippe Mathieu-Daudé
2021-11-22 10:49 ` Peter Maydell
2021-12-15 10:29 ` Philippe Mathieu-Daudé
2021-12-17 9:20 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).