* io: Don't use '#' flag of printf format
@ 2020-10-19 12:12 AlexChen
2020-10-19 12:18 ` Daniel P. Berrangé
2020-10-19 12:55 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: AlexChen @ 2020-10-19 12:12 UTC (permalink / raw)
To: "Daniel P. Berrangé"
Cc: zhengchuan, qemu-devel, zhang.zhanghailiang
Signed-off-by: AlexChen <alex.chen@huawei.com>
---
io/channel-websock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/io/channel-websock.c b/io/channel-websock.c
index 47a0e941d9..e94a1fcf99 100644
--- a/io/channel-websock.c
+++ b/io/channel-websock.c
@@ -746,7 +746,7 @@ static int qio_channel_websock_decode_header(QIOChannelWebsock *ioc,
opcode != QIO_CHANNEL_WEBSOCK_OPCODE_CLOSE &&
opcode != QIO_CHANNEL_WEBSOCK_OPCODE_PING &&
opcode != QIO_CHANNEL_WEBSOCK_OPCODE_PONG) {
- error_setg(errp, "unsupported opcode: %#04x; only binary, close, "
+ error_setg(errp, "unsupported opcode: 0x%04x; only binary, close, "
"ping, and pong websocket frames are supported", opcode);
qio_channel_websock_write_close(
ioc, QIO_CHANNEL_WEBSOCK_STATUS_INVALID_DATA ,
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: io: Don't use '#' flag of printf format
2020-10-19 12:12 io: Don't use '#' flag of printf format AlexChen
@ 2020-10-19 12:18 ` Daniel P. Berrangé
2020-10-19 12:55 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2020-10-19 12:18 UTC (permalink / raw)
To: AlexChen; +Cc: zhengchuan, qemu-devel, zhang.zhanghailiang
On Mon, Oct 19, 2020 at 08:12:02PM +0800, AlexChen wrote:
> Signed-off-by: AlexChen <alex.chen@huawei.com>
> ---
> io/channel-websock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/io/channel-websock.c b/io/channel-websock.c
> index 47a0e941d9..e94a1fcf99 100644
> --- a/io/channel-websock.c
> +++ b/io/channel-websock.c
> @@ -746,7 +746,7 @@ static int qio_channel_websock_decode_header(QIOChannelWebsock *ioc,
> opcode != QIO_CHANNEL_WEBSOCK_OPCODE_CLOSE &&
> opcode != QIO_CHANNEL_WEBSOCK_OPCODE_PING &&
> opcode != QIO_CHANNEL_WEBSOCK_OPCODE_PONG) {
> - error_setg(errp, "unsupported opcode: %#04x; only binary, close, "
> + error_setg(errp, "unsupported opcode: 0x%04x; only binary, close, "
> "ping, and pong websocket frames are supported", opcode);
> qio_channel_websock_write_close(
> ioc, QIO_CHANNEL_WEBSOCK_STATUS_INVALID_DATA ,
Acked-by: Daniel P. Berrangé <berrange@redhat.com>
and added to my queue
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: io: Don't use '#' flag of printf format
2020-10-19 12:12 io: Don't use '#' flag of printf format AlexChen
2020-10-19 12:18 ` Daniel P. Berrangé
@ 2020-10-19 12:55 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-19 12:55 UTC (permalink / raw)
To: AlexChen, Daniel P. Berrangé
Cc: zhengchuan, qemu-devel, zhang.zhanghailiang
On 10/19/20 2:12 PM, AlexChen wrote:
> Signed-off-by: AlexChen <alex.chen@huawei.com>
> ---
> io/channel-websock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/io/channel-websock.c b/io/channel-websock.c
> index 47a0e941d9..e94a1fcf99 100644
> --- a/io/channel-websock.c
> +++ b/io/channel-websock.c
> @@ -746,7 +746,7 @@ static int qio_channel_websock_decode_header(QIOChannelWebsock *ioc,
> opcode != QIO_CHANNEL_WEBSOCK_OPCODE_CLOSE &&
> opcode != QIO_CHANNEL_WEBSOCK_OPCODE_PING &&
> opcode != QIO_CHANNEL_WEBSOCK_OPCODE_PONG) {
> - error_setg(errp, "unsupported opcode: %#04x; only binary, close, "
> + error_setg(errp, "unsupported opcode: 0x%04x; only binary, close, "
> "ping, and pong websocket frames are supported", opcode);
> qio_channel_websock_write_close(
> ioc, QIO_CHANNEL_WEBSOCK_STATUS_INVALID_DATA ,
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-19 12:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 12:12 io: Don't use '#' flag of printf format AlexChen
2020-10-19 12:18 ` Daniel P. Berrangé
2020-10-19 12:55 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).