Re: [PULL 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20191028163447.18541-1-philmd@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge
Type: series
Message-id: 20191028163447.18541-1-philmd@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
197f3c2 hw/pci-host/i440fx: Remove the last PIIX3 traces
1578c52 hw/pci-host: Rename incorrectly named 'piix' as 'i440fx'
0cf957a hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c
2bbf9c2 hw/pci-host/piix: Fix code style issues
304a402 hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h
893e79f hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers
8f3c905 hw/pci-host/piix: Move RCR_IOPORT register definition
799441b hw/pci-host/piix: Extract piix3_create()
741229b hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers
52dfc30 hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c
6478b21 hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create()
7ce078e hw/mips/mips_malta: Create IDE hard drive array dynamically
a20ffb1 piix4: Add a MC146818 RTC Controller as specified in datasheet
1faf74d piix4: Add an i8254 PIT Controller as specified in datasheet
5fa91a8 piix4: Add an i8257 DMA Controller as specified in datasheet
9f72841 piix4: Rename PIIX4 object to piix4-isa
b35c56d Revert "irq: introduce qemu_irq_proxy()"
e6a0756 piix4: Add an i8259 Interrupt Controller as specified in datasheet
1b38311 piix4: Add the Reset Control Register
b4bc66f MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets

=== OUTPUT BEGIN ===
1/20 Checking commit b4bc66f4da87 (MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets)
2/20 Checking commit 1b38311e3c79 (piix4: Add the Reset Control Register)
3/20 Checking commit e6a0756c9612 (piix4: Add an i8259 Interrupt Controller as specified in datasheet)
4/20 Checking commit b35c56d2afb5 (Revert "irq: introduce qemu_irq_proxy()")
5/20 Checking commit 9f72841bf6ba (piix4: Rename PIIX4 object to piix4-isa)
6/20 Checking commit 5fa91a8d2a28 (piix4: Add an i8257 DMA Controller as specified in datasheet)
7/20 Checking commit 1faf74dbd4fd (piix4: Add an i8254 PIT Controller as specified in datasheet)
8/20 Checking commit a20ffb119d09 (piix4: Add a MC146818 RTC Controller as specified in datasheet)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#193: 
deleted file mode 100644

total: 0 errors, 1 warnings, 166 lines checked

Patch 8/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/20 Checking commit 7ce078e38824 (hw/mips/mips_malta: Create IDE hard drive array dynamically)
10/20 Checking commit 6478b213ff27 (hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create())
11/20 Checking commit 52dfc30fcdaa (hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c)
12/20 Checking commit 741229b29fcb (hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers)
13/20 Checking commit 799441beda9f (hw/pci-host/piix: Extract piix3_create())
14/20 Checking commit 8f3c905eff45 (hw/pci-host/piix: Move RCR_IOPORT register definition)
15/20 Checking commit 893e79f2ea67 (hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers)
16/20 Checking commit 304a402b3d92 (hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#98: 
new file mode 100644

total: 0 errors, 1 warnings, 101 lines checked

Patch 16/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/20 Checking commit 2bbf9c2bde4b (hw/pci-host/piix: Fix code style issues)
18/20 Checking commit 0cf957a9a55b (hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#65: 
new file mode 100644

ERROR: spaces required around that '*' (ctx:VxV)
#314: FILE: hw/isa/piix3.c:245:
+    .subsections = (const VMStateDescription*[]) {
                                             ^

total: 1 errors, 1 warnings, 937 lines checked

Patch 18/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

19/20 Checking commit 1578c5216a29 (hw/pci-host: Rename incorrectly named 'piix' as 'i440fx')
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
rename from hw/pci-host/piix.c

total: 0 errors, 1 warnings, 32 lines checked

Patch 19/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/20 Checking commit 197f3c262a3a (hw/pci-host/i440fx: Remove the last PIIX3 traces)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20191028163447.18541-1-philmd@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com