* Re: [PATCH] global: Squash 'the the'
2019-11-04 18:52 [PATCH] global: Squash 'the the' Dr. David Alan Gilbert (git)
@ 2019-11-04 20:03 ` Alex Bennée
2019-11-04 20:27 ` Laurent Vivier
` (4 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Alex Bennée @ 2019-11-04 20:03 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, sstabellini, qemu-trivial, mjt, laurent,
marcandre.lureau, david
Dr. David Alan Gilbert (git) <dgilbert@redhat.com> writes:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> 'the' has a tendency to double up; squash them back down.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> disas/libvixl/vixl/invalset.h | 2 +-
> docs/interop/pr-helper.rst | 2 +-
> docs/specs/ppc-spapr-hotplug.txt | 2 +-
> docs/specs/ppc-xive.rst | 2 +-
> docs/specs/tpm.txt | 2 +-
> include/hw/xen/interface/io/blkif.h | 2 +-
> scripts/dump-guest-memory.py | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/disas/libvixl/vixl/invalset.h b/disas/libvixl/vixl/invalset.h
> index ffdc0237b4..ef5e49d6fe 100644
> --- a/disas/libvixl/vixl/invalset.h
> +++ b/disas/libvixl/vixl/invalset.h
> @@ -102,7 +102,7 @@ template<TEMPLATE_INVALSET_P_DECL> class InvalSet {
> size_t size() const;
>
> // Returns true if no elements are stored in the set.
> - // Note that this does not mean the the backing storage is empty: it can still
> + // Note that this does not mean the backing storage is empty: it can still
> // contain invalid elements.
> bool empty() const;
>
> diff --git a/docs/interop/pr-helper.rst b/docs/interop/pr-helper.rst
> index 9f76d5bcf9..e926f0a6c9 100644
> --- a/docs/interop/pr-helper.rst
> +++ b/docs/interop/pr-helper.rst
> @@ -10,7 +10,7 @@ can delegate implementation of persistent reservations to an external
> restricting access to block devices to specific initiators in a shared
> storage setup.
>
> -For a more detailed reference please refer the the SCSI Primary
> +For a more detailed reference please refer to the SCSI Primary
> Commands standard, specifically the section on Reservations and the
> "PERSISTENT RESERVE IN" and "PERSISTENT RESERVE OUT" commands.
>
> diff --git a/docs/specs/ppc-spapr-hotplug.txt b/docs/specs/ppc-spapr-hotplug.txt
> index cc7833108e..859d52cce6 100644
> --- a/docs/specs/ppc-spapr-hotplug.txt
> +++ b/docs/specs/ppc-spapr-hotplug.txt
> @@ -385,7 +385,7 @@ Each LMB list entry consists of the following elements:
> is used to retrieve the right associativity list to be used for this
> LMB.
> - A 32bit flags word. The bit at bit position 0x00000008 defines whether
> - the LMB is assigned to the the partition as of boot time.
> + the LMB is assigned to the partition as of boot time.
>
> ibm,dynamic-memory-v2
>
> diff --git a/docs/specs/ppc-xive.rst b/docs/specs/ppc-xive.rst
> index 148d57eb6a..83d43f658b 100644
> --- a/docs/specs/ppc-xive.rst
> +++ b/docs/specs/ppc-xive.rst
> @@ -163,7 +163,7 @@ Interrupt Priority Register (PIPR) is also updated using the IPB. This
> register represent the priority of the most favored pending
> notification.
>
> -The PIPR is then compared to the the Current Processor Priority
> +The PIPR is then compared to the Current Processor Priority
> Register (CPPR). If it is more favored (numerically less than), the
> CPU interrupt line is raised and the EO bit of the Notification Source
> Register (NSR) is updated to notify the presence of an exception for
> diff --git a/docs/specs/tpm.txt b/docs/specs/tpm.txt
> index 5d8c26b1ad..9c8cca042d 100644
> --- a/docs/specs/tpm.txt
> +++ b/docs/specs/tpm.txt
> @@ -89,7 +89,7 @@ TPM upon reboot. The PPI specification defines the operation requests and the
> actions the firmware has to take. The system administrator passes the operation
> request number to the firmware through an ACPI interface which writes this
> number to a memory location that the firmware knows. Upon reboot, the firmware
> -finds the number and sends commands to the the TPM. The firmware writes the TPM
> +finds the number and sends commands to the TPM. The firmware writes the TPM
> result code and the operation request number to a memory location that ACPI can
> read from and pass the result on to the administrator.
>
> diff --git a/include/hw/xen/interface/io/blkif.h b/include/hw/xen/interface/io/blkif.h
> index 8b1be50ce8..d07fa1e078 100644
> --- a/include/hw/xen/interface/io/blkif.h
> +++ b/include/hw/xen/interface/io/blkif.h
> @@ -341,7 +341,7 @@
> * access (even when it should be read-only). If the frontend hits the
> * maximum number of allowed persistently mapped grants, it can fallback
> * to non persistent mode. This will cause a performance degradation,
> - * since the the backend driver will still try to map those grants
> + * since the backend driver will still try to map those grants
> * persistently. Since the persistent grants protocol is compatible with
> * the previous protocol, a frontend driver can choose to work in
> * persistent mode even when the backend doesn't support it.
> diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py
> index 2c587cbefc..9371e45813 100644
> --- a/scripts/dump-guest-memory.py
> +++ b/scripts/dump-guest-memory.py
> @@ -170,7 +170,7 @@ class ELF(object):
> self.ehdr.e_phnum += 1
>
> def to_file(self, elf_file):
> - """Writes all ELF structures to the the passed file.
> + """Writes all ELF structures to the passed file.
>
> Structure:
> Ehdr
--
Alex Bennée
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] global: Squash 'the the'
2019-11-04 18:52 [PATCH] global: Squash 'the the' Dr. David Alan Gilbert (git)
2019-11-04 20:03 ` Alex Bennée
@ 2019-11-04 20:27 ` Laurent Vivier
2019-11-04 21:40 ` no-reply
` (3 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Laurent Vivier @ 2019-11-04 20:27 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git), qemu-devel, qemu-trivial, mjt
Cc: peter.maydell, sstabellini, marcandre.lureau, david
Le 04/11/2019 à 19:52, Dr. David Alan Gilbert (git) a écrit :
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> 'the' has a tendency to double up; squash them back down.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> disas/libvixl/vixl/invalset.h | 2 +-
> docs/interop/pr-helper.rst | 2 +-
> docs/specs/ppc-spapr-hotplug.txt | 2 +-
> docs/specs/ppc-xive.rst | 2 +-
> docs/specs/tpm.txt | 2 +-
> include/hw/xen/interface/io/blkif.h | 2 +-
> scripts/dump-guest-memory.py | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] global: Squash 'the the'
2019-11-04 18:52 [PATCH] global: Squash 'the the' Dr. David Alan Gilbert (git)
2019-11-04 20:03 ` Alex Bennée
2019-11-04 20:27 ` Laurent Vivier
@ 2019-11-04 21:40 ` no-reply
2019-11-04 21:54 ` Philippe Mathieu-Daudé
2019-11-05 8:16 ` Alex Bennée
2019-11-04 23:22 ` no-reply
` (2 subsequent siblings)
5 siblings, 2 replies; 12+ messages in thread
From: no-reply @ 2019-11-04 21:40 UTC (permalink / raw)
To: dgilbert
Cc: peter.maydell, sstabellini, qemu-trivial, mjt, qemu-devel,
laurent, marcandre.lureau, david
Patchew URL: https://patchew.org/QEMU/20191104185202.102504-1-dgilbert@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===
TEST iotest-qcow2: 009
TEST iotest-qcow2: 010
**
ERROR:/tmp/qemu-test/src/tests/migration-test.c:903:wait_for_migration_fail: assertion failed: (!strcmp(status, "setup") || !strcmp(status, "failed") || (allow_active && !strcmp(status, "active")))
ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/migration-test.c:903:wait_for_migration_fail: assertion failed: (!strcmp(status, "setup") || !strcmp(status, "failed") || (allow_active && !strcmp(status, "active")))
make: *** [check-qtest-aarch64] Error 1
make: *** Waiting for unfinished jobs....
TEST check-unit: tests/test-bdrv-drain
TEST iotest-qcow2: 011
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=acf3f0f780e741e6a5c367dda157d023', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-_ad8j8yg/src/docker-src.2019-11-04-16.29.40.7445:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=acf3f0f780e741e6a5c367dda157d023
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-_ad8j8yg/src'
make: *** [docker-run-test-quick@centos7] Error 2
real 10m19.416s
user 0m7.957s
The full log is available at
http://patchew.org/logs/20191104185202.102504-1-dgilbert@redhat.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] global: Squash 'the the'
2019-11-04 21:40 ` no-reply
@ 2019-11-04 21:54 ` Philippe Mathieu-Daudé
2019-11-05 8:16 ` Alex Bennée
1 sibling, 0 replies; 12+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-11-04 21:54 UTC (permalink / raw)
To: qemu-devel, no-reply, dgilbert
Cc: peter.maydell, sstabellini, qemu-trivial, mjt, laurent,
marcandre.lureau, david
On 11/4/19 10:40 PM, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20191104185202.102504-1-dgilbert@redhat.com/
>
> Hi,
>
> This series failed the docker-quick@centos7 build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce it
> locally.
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> make docker-image-centos7 V=1 NETWORK=1
> time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
> === TEST SCRIPT END ===
>
> TEST iotest-qcow2: 009
> TEST iotest-qcow2: 010
> **
> ERROR:/tmp/qemu-test/src/tests/migration-test.c:903:wait_for_migration_fail: assertion failed: (!strcmp(status, "setup") || !strcmp(status, "failed") || (allow_active && !strcmp(status, "active")))
> ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/migration-test.c:903:wait_for_migration_fail: assertion failed: (!strcmp(status, "setup") || !strcmp(status, "failed") || (allow_active && !strcmp(status, "active")))
> make: *** [check-qtest-aarch64] Error 1
> make: *** Waiting for unfinished jobs....
=)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] global: Squash 'the the'
2019-11-04 21:40 ` no-reply
2019-11-04 21:54 ` Philippe Mathieu-Daudé
@ 2019-11-05 8:16 ` Alex Bennée
2019-11-05 8:40 ` Laurent Vivier
2019-11-05 18:57 ` Dr. David Alan Gilbert
1 sibling, 2 replies; 12+ messages in thread
From: Alex Bennée @ 2019-11-05 8:16 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, sstabellini, qemu-trivial, mjt, dgilbert, laurent,
marcandre.lureau, david
no-reply@patchew.org writes:
> Patchew URL: https://patchew.org/QEMU/20191104185202.102504-1-dgilbert@redhat.com/
>
>
>
> Hi,
>
> This series failed the docker-quick@centos7 build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce it
> locally.
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> make docker-image-centos7 V=1 NETWORK=1
> time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
> === TEST SCRIPT END ===
>
> TEST iotest-qcow2: 009
> TEST iotest-qcow2: 010
> **
> ERROR:/tmp/qemu-test/src/tests/migration-test.c:903:wait_for_migration_fail: assertion failed: (!strcmp(status, "setup") || !strcmp(status, "failed") || (allow_active && !strcmp(status, "active")))
> ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/migration-test.c:903:wait_for_migration_fail: assertion failed: (!strcmp(status, "setup") || !strcmp(status, "failed") || (allow_active && !strcmp(status, "active")))
> make: *** [check-qtest-aarch64] Error 1
> make: *** Waiting for unfinished jobs....
That's one I've been seeing intermittently on Travis since the
softfreeze started. It was masked by the other regressions which are now
fixed.
> TEST check-unit: tests/test-bdrv-drain
> TEST iotest-qcow2: 011
> ---
> raise CalledProcessError(retcode, cmd)
> subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=acf3f0f780e741e6a5c367dda157d023', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-_ad8j8yg/src/docker-src.2019-11-04-16.29.40.7445:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
> filter=--filter=label=com.qemu.instance.uuid=acf3f0f780e741e6a5c367dda157d023
> make[1]: *** [docker-run] Error 1
> make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-_ad8j8yg/src'
> make: *** [docker-run-test-quick@centos7] Error 2
>
> real 10m19.416s
> user 0m7.957s
>
>
> The full log is available at
> http://patchew.org/logs/20191104185202.102504-1-dgilbert@redhat.com/testing.docker-quick@centos7/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com
--
Alex Bennée
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] global: Squash 'the the'
2019-11-05 8:16 ` Alex Bennée
@ 2019-11-05 8:40 ` Laurent Vivier
2019-11-05 12:13 ` Dr. David Alan Gilbert
2019-11-05 18:57 ` Dr. David Alan Gilbert
1 sibling, 1 reply; 12+ messages in thread
From: Laurent Vivier @ 2019-11-05 8:40 UTC (permalink / raw)
To: Alex Bennée, qemu-devel
Cc: peter.maydell, sstabellini, qemu-trivial, mjt, dgilbert, laurent,
marcandre.lureau, david
On 05/11/2019 09:16, Alex Bennée wrote:
>
> no-reply@patchew.org writes:
>
>> Patchew URL: https://patchew.org/QEMU/20191104185202.102504-1-dgilbert@redhat.com/
>>
>>
>>
>> Hi,
>>
>> This series failed the docker-quick@centos7 build test. Please find the testing commands and
>> their output below. If you have Docker installed, you can probably reproduce it
>> locally.
>>
>> === TEST SCRIPT BEGIN ===
>> #!/bin/bash
>> make docker-image-centos7 V=1 NETWORK=1
>> time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
>> === TEST SCRIPT END ===
>>
>> TEST iotest-qcow2: 009
>> TEST iotest-qcow2: 010
>> **
>> ERROR:/tmp/qemu-test/src/tests/migration-test.c:903:wait_for_migration_fail: assertion failed: (!strcmp(status, "setup") || !strcmp(status, "failed") || (allow_active && !strcmp(status, "active")))
>> ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/migration-test.c:903:wait_for_migration_fail: assertion failed: (!strcmp(status, "setup") || !strcmp(status, "failed") || (allow_active && !strcmp(status, "active")))
>> make: *** [check-qtest-aarch64] Error 1
>> make: *** Waiting for unfinished jobs....
>
> That's one I've been seeing intermittently on Travis since the
> softfreeze started. It was masked by the other regressions which are now
> fixed.
Could it be related with my patch?
1bd71dce4bf2 runstate: ignore exit request in finish migrate state
Thanks,
Laurent
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] global: Squash 'the the'
2019-11-05 8:40 ` Laurent Vivier
@ 2019-11-05 12:13 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 12+ messages in thread
From: Dr. David Alan Gilbert @ 2019-11-05 12:13 UTC (permalink / raw)
To: Laurent Vivier
Cc: peter.maydell, sstabellini, qemu-trivial, mjt, qemu-devel,
laurent, marcandre.lureau, Alex Bennée, david
* Laurent Vivier (lvivier@redhat.com) wrote:
> On 05/11/2019 09:16, Alex Bennée wrote:
> >
> > no-reply@patchew.org writes:
> >
> >> Patchew URL: https://patchew.org/QEMU/20191104185202.102504-1-dgilbert@redhat.com/
> >>
> >>
> >>
> >> Hi,
> >>
> >> This series failed the docker-quick@centos7 build test. Please find the testing commands and
> >> their output below. If you have Docker installed, you can probably reproduce it
> >> locally.
> >>
> >> === TEST SCRIPT BEGIN ===
> >> #!/bin/bash
> >> make docker-image-centos7 V=1 NETWORK=1
> >> time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
> >> === TEST SCRIPT END ===
> >>
> >> TEST iotest-qcow2: 009
> >> TEST iotest-qcow2: 010
> >> **
> >> ERROR:/tmp/qemu-test/src/tests/migration-test.c:903:wait_for_migration_fail: assertion failed: (!strcmp(status, "setup") || !strcmp(status, "failed") || (allow_active && !strcmp(status, "active")))
> >> ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/migration-test.c:903:wait_for_migration_fail: assertion failed: (!strcmp(status, "setup") || !strcmp(status, "failed") || (allow_active && !strcmp(status, "active")))
> >> make: *** [check-qtest-aarch64] Error 1
> >> make: *** Waiting for unfinished jobs....
> >
> > That's one I've been seeing intermittently on Travis since the
> > softfreeze started. It was masked by the other regressions which are now
> > fixed.
>
> Could it be related with my patch?
>
> 1bd71dce4bf2 runstate: ignore exit request in finish migrate state
Possible but unlikely I think; lets see if I can reproduce it and get a
backtrace; (It would be very nice if I could get that assertion to tell
me what 'status' is; we know it's not setup or failed, and it may or may
not be active; but what it is ....well that's anyones guess.
Dave
> Thanks,
> Laurent
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] global: Squash 'the the'
2019-11-05 8:16 ` Alex Bennée
2019-11-05 8:40 ` Laurent Vivier
@ 2019-11-05 18:57 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 12+ messages in thread
From: Dr. David Alan Gilbert @ 2019-11-05 18:57 UTC (permalink / raw)
To: Alex Bennée
Cc: peter.maydell, sstabellini, qemu-trivial, mjt, qemu-devel,
laurent, marcandre.lureau, david
* Alex Bennée (alex.bennee@linaro.org) wrote:
>
> no-reply@patchew.org writes:
>
> > Patchew URL: https://patchew.org/QEMU/20191104185202.102504-1-dgilbert@redhat.com/
> >
> >
> >
> > Hi,
> >
> > This series failed the docker-quick@centos7 build test. Please find the testing commands and
> > their output below. If you have Docker installed, you can probably reproduce it
> > locally.
> >
> > === TEST SCRIPT BEGIN ===
> > #!/bin/bash
> > make docker-image-centos7 V=1 NETWORK=1
> > time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
> > === TEST SCRIPT END ===
> >
> > TEST iotest-qcow2: 009
> > TEST iotest-qcow2: 010
> > **
> > ERROR:/tmp/qemu-test/src/tests/migration-test.c:903:wait_for_migration_fail: assertion failed: (!strcmp(status, "setup") || !strcmp(status, "failed") || (allow_active && !strcmp(status, "active")))
> > ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/migration-test.c:903:wait_for_migration_fail: assertion failed: (!strcmp(status, "setup") || !strcmp(status, "failed") || (allow_active && !strcmp(status, "active")))
> > make: *** [check-qtest-aarch64] Error 1
> > make: *** Waiting for unfinished jobs....
>
> That's one I've been seeing intermittently on Travis since the
> softfreeze started. It was masked by the other regressions which are now
> fixed.
If anyone hits this I'd be greatful for a backtrace and/or the value of
'status' at the point it fails.
Dave
>
> > TEST check-unit: tests/test-bdrv-drain
> > TEST iotest-qcow2: 011
> > ---
> > raise CalledProcessError(retcode, cmd)
> > subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=acf3f0f780e741e6a5c367dda157d023', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-_ad8j8yg/src/docker-src.2019-11-04-16.29.40.7445:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
> > filter=--filter=label=com.qemu.instance.uuid=acf3f0f780e741e6a5c367dda157d023
> > make[1]: *** [docker-run] Error 1
> > make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-_ad8j8yg/src'
> > make: *** [docker-run-test-quick@centos7] Error 2
> >
> > real 10m19.416s
> > user 0m7.957s
> >
> >
> > The full log is available at
> > http://patchew.org/logs/20191104185202.102504-1-dgilbert@redhat.com/testing.docker-quick@centos7/?type=message.
> > ---
> > Email generated automatically by Patchew [https://patchew.org/].
> > Please send your feedback to patchew-devel@redhat.com
>
>
> --
> Alex Bennée
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] global: Squash 'the the'
2019-11-04 18:52 [PATCH] global: Squash 'the the' Dr. David Alan Gilbert (git)
` (2 preceding siblings ...)
2019-11-04 21:40 ` no-reply
@ 2019-11-04 23:22 ` no-reply
2019-11-05 14:06 ` Laurent Vivier
2019-11-06 21:12 ` David Gibson
5 siblings, 0 replies; 12+ messages in thread
From: no-reply @ 2019-11-04 23:22 UTC (permalink / raw)
To: dgilbert
Cc: peter.maydell, sstabellini, qemu-trivial, mjt, qemu-devel,
laurent, marcandre.lureau, david
Patchew URL: https://patchew.org/QEMU/20191104185202.102504-1-dgilbert@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] global: Squash 'the the'
Type: series
Message-id: 20191104185202.102504-1-dgilbert@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
42a6850 global: Squash 'the the'
=== OUTPUT BEGIN ===
ERROR: do not use C99 // comments
#24: FILE: disas/libvixl/vixl/invalset.h:105:
+ // Note that this does not mean the backing storage is empty: it can still
total: 1 errors, 0 warnings, 56 lines checked
Commit 42a68503c11b (global: Squash 'the the') has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20191104185202.102504-1-dgilbert@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] global: Squash 'the the'
2019-11-04 18:52 [PATCH] global: Squash 'the the' Dr. David Alan Gilbert (git)
` (3 preceding siblings ...)
2019-11-04 23:22 ` no-reply
@ 2019-11-05 14:06 ` Laurent Vivier
2019-11-06 21:12 ` David Gibson
5 siblings, 0 replies; 12+ messages in thread
From: Laurent Vivier @ 2019-11-05 14:06 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git), qemu-devel, qemu-trivial, mjt
Cc: peter.maydell, sstabellini, david, marcandre.lureau
Le 04/11/2019 à 19:52, Dr. David Alan Gilbert (git) a écrit :
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> 'the' has a tendency to double up; squash them back down.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> disas/libvixl/vixl/invalset.h | 2 +-
> docs/interop/pr-helper.rst | 2 +-
> docs/specs/ppc-spapr-hotplug.txt | 2 +-
> docs/specs/ppc-xive.rst | 2 +-
> docs/specs/tpm.txt | 2 +-
> include/hw/xen/interface/io/blkif.h | 2 +-
> scripts/dump-guest-memory.py | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/disas/libvixl/vixl/invalset.h b/disas/libvixl/vixl/invalset.h
> index ffdc0237b4..ef5e49d6fe 100644
> --- a/disas/libvixl/vixl/invalset.h
> +++ b/disas/libvixl/vixl/invalset.h
> @@ -102,7 +102,7 @@ template<TEMPLATE_INVALSET_P_DECL> class InvalSet {
> size_t size() const;
>
> // Returns true if no elements are stored in the set.
> - // Note that this does not mean the the backing storage is empty: it can still
> + // Note that this does not mean the backing storage is empty: it can still
> // contain invalid elements.
> bool empty() const;
>
> diff --git a/docs/interop/pr-helper.rst b/docs/interop/pr-helper.rst
> index 9f76d5bcf9..e926f0a6c9 100644
> --- a/docs/interop/pr-helper.rst
> +++ b/docs/interop/pr-helper.rst
> @@ -10,7 +10,7 @@ can delegate implementation of persistent reservations to an external
> restricting access to block devices to specific initiators in a shared
> storage setup.
>
> -For a more detailed reference please refer the the SCSI Primary
> +For a more detailed reference please refer to the SCSI Primary
> Commands standard, specifically the section on Reservations and the
> "PERSISTENT RESERVE IN" and "PERSISTENT RESERVE OUT" commands.
>
> diff --git a/docs/specs/ppc-spapr-hotplug.txt b/docs/specs/ppc-spapr-hotplug.txt
> index cc7833108e..859d52cce6 100644
> --- a/docs/specs/ppc-spapr-hotplug.txt
> +++ b/docs/specs/ppc-spapr-hotplug.txt
> @@ -385,7 +385,7 @@ Each LMB list entry consists of the following elements:
> is used to retrieve the right associativity list to be used for this
> LMB.
> - A 32bit flags word. The bit at bit position 0x00000008 defines whether
> - the LMB is assigned to the the partition as of boot time.
> + the LMB is assigned to the partition as of boot time.
>
> ibm,dynamic-memory-v2
>
> diff --git a/docs/specs/ppc-xive.rst b/docs/specs/ppc-xive.rst
> index 148d57eb6a..83d43f658b 100644
> --- a/docs/specs/ppc-xive.rst
> +++ b/docs/specs/ppc-xive.rst
> @@ -163,7 +163,7 @@ Interrupt Priority Register (PIPR) is also updated using the IPB. This
> register represent the priority of the most favored pending
> notification.
>
> -The PIPR is then compared to the the Current Processor Priority
> +The PIPR is then compared to the Current Processor Priority
> Register (CPPR). If it is more favored (numerically less than), the
> CPU interrupt line is raised and the EO bit of the Notification Source
> Register (NSR) is updated to notify the presence of an exception for
> diff --git a/docs/specs/tpm.txt b/docs/specs/tpm.txt
> index 5d8c26b1ad..9c8cca042d 100644
> --- a/docs/specs/tpm.txt
> +++ b/docs/specs/tpm.txt
> @@ -89,7 +89,7 @@ TPM upon reboot. The PPI specification defines the operation requests and the
> actions the firmware has to take. The system administrator passes the operation
> request number to the firmware through an ACPI interface which writes this
> number to a memory location that the firmware knows. Upon reboot, the firmware
> -finds the number and sends commands to the the TPM. The firmware writes the TPM
> +finds the number and sends commands to the TPM. The firmware writes the TPM
> result code and the operation request number to a memory location that ACPI can
> read from and pass the result on to the administrator.
>
> diff --git a/include/hw/xen/interface/io/blkif.h b/include/hw/xen/interface/io/blkif.h
> index 8b1be50ce8..d07fa1e078 100644
> --- a/include/hw/xen/interface/io/blkif.h
> +++ b/include/hw/xen/interface/io/blkif.h
> @@ -341,7 +341,7 @@
> * access (even when it should be read-only). If the frontend hits the
> * maximum number of allowed persistently mapped grants, it can fallback
> * to non persistent mode. This will cause a performance degradation,
> - * since the the backend driver will still try to map those grants
> + * since the backend driver will still try to map those grants
> * persistently. Since the persistent grants protocol is compatible with
> * the previous protocol, a frontend driver can choose to work in
> * persistent mode even when the backend doesn't support it.
> diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py
> index 2c587cbefc..9371e45813 100644
> --- a/scripts/dump-guest-memory.py
> +++ b/scripts/dump-guest-memory.py
> @@ -170,7 +170,7 @@ class ELF(object):
> self.ehdr.e_phnum += 1
>
> def to_file(self, elf_file):
> - """Writes all ELF structures to the the passed file.
> + """Writes all ELF structures to the passed file.
>
> Structure:
> Ehdr
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] global: Squash 'the the'
2019-11-04 18:52 [PATCH] global: Squash 'the the' Dr. David Alan Gilbert (git)
` (4 preceding siblings ...)
2019-11-05 14:06 ` Laurent Vivier
@ 2019-11-06 21:12 ` David Gibson
5 siblings, 0 replies; 12+ messages in thread
From: David Gibson @ 2019-11-06 21:12 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git)
Cc: peter.maydell, sstabellini, qemu-trivial, mjt, qemu-devel,
laurent, marcandre.lureau
[-- Attachment #1: Type: text/plain, Size: 5640 bytes --]
On Mon, Nov 04, 2019 at 06:52:02PM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> 'the' has a tendency to double up; squash them back down.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> disas/libvixl/vixl/invalset.h | 2 +-
> docs/interop/pr-helper.rst | 2 +-
> docs/specs/ppc-spapr-hotplug.txt | 2 +-
> docs/specs/ppc-xive.rst | 2 +-
These two,
Acked-by: David Gibson <david@gibson.dropbear.id.au>
> docs/specs/tpm.txt | 2 +-
> include/hw/xen/interface/io/blkif.h | 2 +-
> scripts/dump-guest-memory.py | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/disas/libvixl/vixl/invalset.h b/disas/libvixl/vixl/invalset.h
> index ffdc0237b4..ef5e49d6fe 100644
> --- a/disas/libvixl/vixl/invalset.h
> +++ b/disas/libvixl/vixl/invalset.h
> @@ -102,7 +102,7 @@ template<TEMPLATE_INVALSET_P_DECL> class InvalSet {
> size_t size() const;
>
> // Returns true if no elements are stored in the set.
> - // Note that this does not mean the the backing storage is empty: it can still
> + // Note that this does not mean the backing storage is empty: it can still
> // contain invalid elements.
> bool empty() const;
>
> diff --git a/docs/interop/pr-helper.rst b/docs/interop/pr-helper.rst
> index 9f76d5bcf9..e926f0a6c9 100644
> --- a/docs/interop/pr-helper.rst
> +++ b/docs/interop/pr-helper.rst
> @@ -10,7 +10,7 @@ can delegate implementation of persistent reservations to an external
> restricting access to block devices to specific initiators in a shared
> storage setup.
>
> -For a more detailed reference please refer the the SCSI Primary
> +For a more detailed reference please refer to the SCSI Primary
> Commands standard, specifically the section on Reservations and the
> "PERSISTENT RESERVE IN" and "PERSISTENT RESERVE OUT" commands.
>
> diff --git a/docs/specs/ppc-spapr-hotplug.txt b/docs/specs/ppc-spapr-hotplug.txt
> index cc7833108e..859d52cce6 100644
> --- a/docs/specs/ppc-spapr-hotplug.txt
> +++ b/docs/specs/ppc-spapr-hotplug.txt
> @@ -385,7 +385,7 @@ Each LMB list entry consists of the following elements:
> is used to retrieve the right associativity list to be used for this
> LMB.
> - A 32bit flags word. The bit at bit position 0x00000008 defines whether
> - the LMB is assigned to the the partition as of boot time.
> + the LMB is assigned to the partition as of boot time.
>
> ibm,dynamic-memory-v2
>
> diff --git a/docs/specs/ppc-xive.rst b/docs/specs/ppc-xive.rst
> index 148d57eb6a..83d43f658b 100644
> --- a/docs/specs/ppc-xive.rst
> +++ b/docs/specs/ppc-xive.rst
> @@ -163,7 +163,7 @@ Interrupt Priority Register (PIPR) is also updated using the IPB. This
> register represent the priority of the most favored pending
> notification.
>
> -The PIPR is then compared to the the Current Processor Priority
> +The PIPR is then compared to the Current Processor Priority
> Register (CPPR). If it is more favored (numerically less than), the
> CPU interrupt line is raised and the EO bit of the Notification Source
> Register (NSR) is updated to notify the presence of an exception for
> diff --git a/docs/specs/tpm.txt b/docs/specs/tpm.txt
> index 5d8c26b1ad..9c8cca042d 100644
> --- a/docs/specs/tpm.txt
> +++ b/docs/specs/tpm.txt
> @@ -89,7 +89,7 @@ TPM upon reboot. The PPI specification defines the operation requests and the
> actions the firmware has to take. The system administrator passes the operation
> request number to the firmware through an ACPI interface which writes this
> number to a memory location that the firmware knows. Upon reboot, the firmware
> -finds the number and sends commands to the the TPM. The firmware writes the TPM
> +finds the number and sends commands to the TPM. The firmware writes the TPM
> result code and the operation request number to a memory location that ACPI can
> read from and pass the result on to the administrator.
>
> diff --git a/include/hw/xen/interface/io/blkif.h b/include/hw/xen/interface/io/blkif.h
> index 8b1be50ce8..d07fa1e078 100644
> --- a/include/hw/xen/interface/io/blkif.h
> +++ b/include/hw/xen/interface/io/blkif.h
> @@ -341,7 +341,7 @@
> * access (even when it should be read-only). If the frontend hits the
> * maximum number of allowed persistently mapped grants, it can fallback
> * to non persistent mode. This will cause a performance degradation,
> - * since the the backend driver will still try to map those grants
> + * since the backend driver will still try to map those grants
> * persistently. Since the persistent grants protocol is compatible with
> * the previous protocol, a frontend driver can choose to work in
> * persistent mode even when the backend doesn't support it.
> diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py
> index 2c587cbefc..9371e45813 100644
> --- a/scripts/dump-guest-memory.py
> +++ b/scripts/dump-guest-memory.py
> @@ -170,7 +170,7 @@ class ELF(object):
> self.ehdr.e_phnum += 1
>
> def to_file(self, elf_file):
> - """Writes all ELF structures to the the passed file.
> + """Writes all ELF structures to the passed file.
>
> Structure:
> Ehdr
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread