From: no-reply@patchew.org
To: hare@suse.de
Cc: kwolf@redhat.com, keith.busch@wdc.com, qemu-block@nongnu.org,
qemu-devel@nongnu.org, minwoo.im.dev@gmail.com, hare@suse.de
Subject: Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug
Date: Tue, 11 May 2021 00:45:46 -0700 (PDT) [thread overview]
Message-ID: <162071914531.13003.11125094093285682224@d887ba82c771> (raw)
In-Reply-To: <20210511073511.32511-1-hare@suse.de>
Patchew URL: https://patchew.org/QEMU/20210511073511.32511-1-hare@suse.de/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210511073511.32511-1-hare@suse.de
Subject: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
e58c7a3..e4f3ede master -> master
* [new tag] patchew/20210511073511.32511-1-hare@suse.de -> patchew/20210511073511.32511-1-hare@suse.de
Switched to a new branch 'test'
1d24622 hw/block/nvme: re-enable NVMe PCI hotplug
=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#101: FILE: hw/block/nvme-subsys.c:50:
+ if (!n->subsys)
[...]
total: 1 errors, 0 warnings, 182 lines checked
Commit 1d24622c5d19 (hw/block/nvme: re-enable NVMe PCI hotplug) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210511073511.32511-1-hare@suse.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
next prev parent reply other threads:[~2021-05-11 7:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 7:35 [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug Hannes Reinecke
2021-05-11 7:45 ` no-reply [this message]
2021-05-11 8:05 ` Philippe Mathieu-Daudé
2021-05-11 12:22 ` Klaus Jensen
2021-05-11 13:12 ` Hannes Reinecke
2021-05-11 13:37 ` Klaus Jensen
2021-05-11 14:54 ` Hannes Reinecke
2021-05-11 16:03 ` Klaus Jensen
2021-05-11 16:12 ` Hannes Reinecke
2022-10-10 17:01 ` Daniel Wagner
2022-10-10 17:15 ` Klaus Jensen
2022-10-18 8:15 ` Daniel Wagner
2022-10-21 12:59 ` Daniel Wagner
2022-10-31 7:30 ` Klaus Jensen
2022-10-12 6:24 ` Hannes Reinecke
2022-10-12 8:06 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162071914531.13003.11125094093285682224@d887ba82c771 \
--to=no-reply@patchew.org \
--cc=hare@suse.de \
--cc=keith.busch@wdc.com \
--cc=kwolf@redhat.com \
--cc=minwoo.im.dev@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).