qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Hannes Reinecke <hare@suse.de>, Keith Busch <keith.busch@wdc.com>,
	Klaus Jensen <its@irrelevant.dk>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Minwoo Im <minwoo.im.dev@gmail.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug
Date: Tue, 11 May 2021 10:05:00 +0200	[thread overview]
Message-ID: <da948c52-c183-4b3d-efcd-972d1e490e18@redhat.com> (raw)
In-Reply-To: <20210511073511.32511-1-hare@suse.de>

Cc'ing Klaus (maintainer)

On 5/11/21 9:35 AM, Hannes Reinecke wrote:
> Ever since commit e570768566 ("hw/block/nvme: support for shared
> namespace in subsystem") NVMe PCI hotplug is broken, as the PCI
> hotplug infrastructure will only work for the nvme devices (which
> are PCI devices), but not for any attached namespaces.
> So when re-adding the NVMe PCI device via 'device_add' the NVMe
> controller is added, but all namespaces are missing.
> This patch adds device hotplug hooks for NVMe namespaces, such that one
> can call 'device_add nvme-ns' to (re-)attach the namespaces after
> the PCI NVMe device 'device_add nvme' hotplug call.
> 
> Fixes: e570768566 ("hw/block/nvme: support for shared namespace in subsystem")
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
>  capstone               |  2 +-

>  roms/SLOF              |  2 +-
>  roms/openbios          |  2 +-
>  roms/u-boot            |  2 +-
>  9 files changed, 93 insertions(+), 20 deletions(-)
> 
> diff --git a/capstone b/capstone
> index f8b1b83301..22ead3e0bf 160000
> --- a/capstone
> +++ b/capstone
> @@ -1 +1 @@
> -Subproject commit f8b1b833015a4ae47110ed068e0deb7106ced66d
> +Subproject commit 22ead3e0bfdb87516656453336160e0a37b066bf

> index 33a7322de1..e18ddad851 160000
> --- a/roms/SLOF
> +++ b/roms/SLOF
> @@ -1 +1 @@
> -Subproject commit 33a7322de13e9dca4b38851a345a58d37e7a441d
> +Subproject commit e18ddad8516ff2cfe36ec130200318f7251aa78c
> diff --git a/roms/openbios b/roms/openbios
> index 4a0041107b..7f28286f5c 160000
> --- a/roms/openbios
> +++ b/roms/openbios
> @@ -1 +1 @@
> -Subproject commit 4a0041107b8ef77e0e8337bfcb5f8078887261a7
> +Subproject commit 7f28286f5cb1ca682e3ba0a8706d8884f12bc49e
> diff --git a/roms/u-boot b/roms/u-boot
> index b46dd116ce..d3689267f9 160000
> --- a/roms/u-boot
> +++ b/roms/u-boot
> @@ -1 +1 @@
> -Subproject commit b46dd116ce03e235f2a7d4843c6278e1da44b5e1
> +Subproject commit d3689267f92c5956e09cc7d1baa4700141662bff
> 

Submodule changes unlikely related.



  parent reply	other threads:[~2021-05-11  8:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11  7:35 [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug Hannes Reinecke
2021-05-11  7:45 ` no-reply
2021-05-11  8:05 ` Philippe Mathieu-Daudé [this message]
2021-05-11 12:22 ` Klaus Jensen
2021-05-11 13:12   ` Hannes Reinecke
2021-05-11 13:37     ` Klaus Jensen
2021-05-11 14:54       ` Hannes Reinecke
2021-05-11 16:03         ` Klaus Jensen
2021-05-11 16:12           ` Hannes Reinecke
2022-10-10 17:01             ` Daniel Wagner
2022-10-10 17:15               ` Klaus Jensen
2022-10-18  8:15                 ` Daniel Wagner
2022-10-21 12:59                   ` Daniel Wagner
2022-10-31  7:30                     ` Klaus Jensen
2022-10-12  6:24               ` Hannes Reinecke
2022-10-12  8:06                 ` Klaus Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da948c52-c183-4b3d-efcd-972d1e490e18@redhat.com \
    --to=philmd@redhat.com \
    --cc=hare@suse.de \
    --cc=its@irrelevant.dk \
    --cc=keith.busch@wdc.com \
    --cc=kwolf@redhat.com \
    --cc=minwoo.im.dev@gmail.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).