From: Klaus Jensen <its@irrelevant.dk>
To: Daniel Wagner <wagi@monom.org>
Cc: Hannes Reinecke <hare@suse.de>, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Keith Busch <keith.busch@wdc.com>
Subject: Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug
Date: Mon, 31 Oct 2022 08:30:36 +0100 [thread overview]
Message-ID: <Y195nENga028PvT9@cormorant.local> (raw)
In-Reply-To: <20221021125948.g2vuxkcvmflm3ruu@carbon.lan>
[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]
On Oct 21 14:59, Daniel Wagner wrote:
> On Tue, Oct 18, 2022 at 10:15:57AM +0200, Daniel Wagner wrote:
> > On Mon, Oct 10, 2022 at 07:15:08PM +0200, Klaus Jensen wrote:
> > > This is all upstream. Namespaces with 'shared=on' *should* all be
> > > automatically attached to any hotplugged controller devices.
> > >
> > > With what setup is this not working for you?
> >
> > Ah okay, I missed the 'shared=on' bit. Let me try again.
>
> Nope, that's not enough. Maybe my setup is not okay?
>
> <qemu:commandline>
> <qemu:arg value='-device'/>
> <qemu:arg value='pcie-root-port,id=root,slot=1'/>
> </qemu:commandline>
>
> qemu-monitor-command tw0 --hmp drive_add 0 if=none,file=/tmp/nvme1.qcow2,format=qcow2,id=nvme1
> qemu-monitor-command tw0 --hmp device_add nvme,id=nvme1,serial=nvme-1,bus=root
> qemu-monitor-command tw0 --hmp device_add nvme-ns,drive=nvme1,nsid=1,shared=on
> Error: Bus 'nvme1' does not support hotplugging
>
> With the patch below the hotplugging works.
>
Looks like you are not configuring a subsystem device (nvme-subsys) and
attaching the nvme controller to it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-10-31 7:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 7:35 [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug Hannes Reinecke
2021-05-11 7:45 ` no-reply
2021-05-11 8:05 ` Philippe Mathieu-Daudé
2021-05-11 12:22 ` Klaus Jensen
2021-05-11 13:12 ` Hannes Reinecke
2021-05-11 13:37 ` Klaus Jensen
2021-05-11 14:54 ` Hannes Reinecke
2021-05-11 16:03 ` Klaus Jensen
2021-05-11 16:12 ` Hannes Reinecke
2022-10-10 17:01 ` Daniel Wagner
2022-10-10 17:15 ` Klaus Jensen
2022-10-18 8:15 ` Daniel Wagner
2022-10-21 12:59 ` Daniel Wagner
2022-10-31 7:30 ` Klaus Jensen [this message]
2022-10-12 6:24 ` Hannes Reinecke
2022-10-12 8:06 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y195nENga028PvT9@cormorant.local \
--to=its@irrelevant.dk \
--cc=hare@suse.de \
--cc=keith.busch@wdc.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).