From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, shorne@gmail.com, proljc@gmail.com
Subject: Re: [PATCH] or1k: Fix compilation hiccup
Date: Tue, 26 May 2020 21:58:11 -0500 [thread overview]
Message-ID: <196f3bd3-b1e2-972c-7c74-281b3bf0d155@redhat.com> (raw)
In-Reply-To: <159053530937.12401.10203156196787167758@45ef0f9c86ae>
On 5/26/20 6:21 PM, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20200526185132.1652355-1-eblake@redhat.com/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> === OUTPUT BEGIN ===
> ERROR: spaces required around that '*' (ctx:WxV)
> #33: FILE: hw/openrisc/openrisc_sim.c:132:
> + qemu_irq *cpu_irqs[2] = {};
> ^
>
> total: 1 errors, 0 warnings, 8 lines checked
>
> Commit d96d2fbbc5db (or1k: Fix compilation hiccup) has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
False positive, due to 'qemu_irq' not following the normal naming
conventions for typedefs.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-05-27 2:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 18:51 [PATCH] or1k: Fix compilation hiccup Eric Blake
2020-05-26 23:21 ` no-reply
2020-05-27 2:58 ` Eric Blake [this message]
2020-05-27 5:29 ` Thomas Huth
2020-05-27 7:27 ` Philippe Mathieu-Daudé
2020-05-27 7:27 ` [Bug 1874073] " Philippe Mathieu-Daudé
2020-05-29 16:21 ` Christophe de Dinechin
2020-05-29 16:40 ` Peter Maydell
2020-06-02 7:43 ` Markus Armbruster
2020-06-08 6:03 ` Markus Armbruster
2020-06-08 6:22 ` Philippe Mathieu-Daudé
2020-06-08 9:15 ` Markus Armbruster
2020-06-08 15:43 ` Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2020-04-21 13:16 [Bug 1874073] [NEW] openrisc_sim.c:87:42: error: 'cpu_irqs[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized] Martin Liska
2020-04-21 13:25 ` [Bug 1874073] " Martin Liska
2020-04-21 13:37 ` Peter Maydell
2020-04-21 14:08 ` Martin Liska
2020-04-21 14:36 ` Peter Maydell
2020-04-21 15:08 ` Philippe Mathieu-Daudé
2020-05-27 7:54 ` Martin Liska
2020-06-08 6:25 ` Philippe Mathieu-Daudé
2020-06-08 7:14 ` [PATCH] hw/openrisc/openrisc_sim: Add assertion to silent GCC warning Philippe Mathieu-Daudé
2020-06-08 7:14 ` [Bug 1874073] " Philippe Mathieu-Daudé
2020-06-08 7:16 ` Thomas Huth
2020-06-08 15:33 ` Eric Blake
2020-06-08 15:33 ` [Bug 1874073] " Eric Blake
2020-06-09 20:42 ` Stafford Horne
2020-06-09 20:49 ` Stafford Horne
2020-06-09 20:49 ` Eric Blake
2020-06-09 20:49 ` [Bug 1874073] " Eric Blake
2020-06-08 16:06 ` [PATCH v2] hw/openrisc/openrisc_sim: Add assertion to silence " Philippe Mathieu-Daudé
2020-06-08 16:06 ` [Bug 1874073] " Philippe Mathieu-Daudé
2020-06-08 19:42 ` Richard Henderson
2020-06-09 17:44 ` [Bug 1874073] " Laurent Vivier
2020-06-09 17:44 ` Laurent Vivier
2020-07-02 8:50 ` [Bug 1874073] Re: openrisc_sim.c:87:42: error: 'cpu_irqs[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized] Philippe Mathieu-Daudé
2020-08-20 14:39 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=196f3bd3-b1e2-972c-7c74-281b3bf0d155@redhat.com \
--to=eblake@redhat.com \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).