From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Stafford Horne <shorne@gmail.com>,
Jia Liu <proljc@gmail.com>
Subject: [PATCH] or1k: Fix compilation hiccup
Date: Tue, 26 May 2020 13:51:32 -0500 [thread overview]
Message-ID: <20200526185132.1652355-1-eblake@redhat.com> (raw)
On my Fedora 32 machine, gcc 10.1.1 at -O2 (the default for a bare
'./configure') has a false-positive complaint:
CC or1k-softmmu/hw/openrisc/openrisc_sim.o
/home/eblake/qemu/hw/openrisc/openrisc_sim.c: In function ‘openrisc_sim_init’:
/home/eblake/qemu/hw/openrisc/openrisc_sim.c:87:42: error: ‘cpu_irqs[0]’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
87 | sysbus_connect_irq(s, i, cpu_irqs[i][irq_pin]);
| ~~~~~~~~^~~
Initializing both pointers of cpu_irqs[] to NULL is sufficient to shut
up the compiler, even though they are definitely assigned in
openrisc_sim_init() prior to the inlined call to
openrisc_sim_ompic_init() containing the line in question.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
hw/openrisc/openrisc_sim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c
index d08ce6181199..95011a8015b4 100644
--- a/hw/openrisc/openrisc_sim.c
+++ b/hw/openrisc/openrisc_sim.c
@@ -129,7 +129,7 @@ static void openrisc_sim_init(MachineState *machine)
const char *kernel_filename = machine->kernel_filename;
OpenRISCCPU *cpu = NULL;
MemoryRegion *ram;
- qemu_irq *cpu_irqs[2];
+ qemu_irq *cpu_irqs[2] = {};
qemu_irq serial_irq;
int n;
unsigned int smp_cpus = machine->smp.cpus;
--
2.26.2
next reply other threads:[~2020-05-26 18:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 18:51 Eric Blake [this message]
2020-05-26 23:21 ` [PATCH] or1k: Fix compilation hiccup no-reply
2020-05-27 2:58 ` Eric Blake
2020-05-27 5:29 ` Thomas Huth
2020-05-27 7:27 ` Philippe Mathieu-Daudé
2020-05-27 7:27 ` [Bug 1874073] " Philippe Mathieu-Daudé
2020-05-29 16:21 ` Christophe de Dinechin
2020-05-29 16:40 ` Peter Maydell
2020-06-02 7:43 ` Markus Armbruster
2020-06-08 6:03 ` Markus Armbruster
2020-06-08 6:22 ` Philippe Mathieu-Daudé
2020-06-08 9:15 ` Markus Armbruster
2020-06-08 15:43 ` Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2020-04-21 13:16 [Bug 1874073] [NEW] openrisc_sim.c:87:42: error: 'cpu_irqs[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized] Martin Liska
2020-04-21 13:25 ` [Bug 1874073] " Martin Liska
2020-04-21 13:37 ` Peter Maydell
2020-04-21 14:08 ` Martin Liska
2020-04-21 14:36 ` Peter Maydell
2020-04-21 15:08 ` Philippe Mathieu-Daudé
2020-05-27 7:54 ` Martin Liska
2020-06-08 6:25 ` Philippe Mathieu-Daudé
2020-06-08 7:14 ` [PATCH] hw/openrisc/openrisc_sim: Add assertion to silent GCC warning Philippe Mathieu-Daudé
2020-06-08 7:14 ` [Bug 1874073] " Philippe Mathieu-Daudé
2020-06-08 7:16 ` Thomas Huth
2020-06-08 15:33 ` Eric Blake
2020-06-08 15:33 ` [Bug 1874073] " Eric Blake
2020-06-09 20:42 ` Stafford Horne
2020-06-09 20:49 ` Stafford Horne
2020-06-09 20:49 ` Eric Blake
2020-06-09 20:49 ` [Bug 1874073] " Eric Blake
2020-06-08 16:06 ` [PATCH v2] hw/openrisc/openrisc_sim: Add assertion to silence " Philippe Mathieu-Daudé
2020-06-08 16:06 ` [Bug 1874073] " Philippe Mathieu-Daudé
2020-06-08 19:42 ` Richard Henderson
2020-06-09 17:44 ` [Bug 1874073] " Laurent Vivier
2020-06-09 17:44 ` Laurent Vivier
2020-07-02 8:50 ` [Bug 1874073] Re: openrisc_sim.c:87:42: error: 'cpu_irqs[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized] Philippe Mathieu-Daudé
2020-08-20 14:39 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526185132.1652355-1-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).