From: Eduardo Habkost <ehabkost@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, cornelia.huck@de.ibm.com,
"Michael S. Tsirkin" <mst@redhat.com>,
ghammer@redhat.com, agraf@suse.de,
Markus Armbruster <armbru@redhat.com>,
borntraeger@de.ibm.com, qemu-ppc@nongnu.org,
Gerd Hoffmann <kraxel@redhat.com>,
david@gibson.dropbear.id.au, Igor Mammedov <imammedo@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
lcapitulino@redhat.com, lersek@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] qdev & hw/core owner? (was Re: [PATCH v19 7/9] machine: add properties to compat_props incrementaly)
Date: Fri, 12 Feb 2016 16:17:54 -0200 [thread overview]
Message-ID: <20160212181754.GI6239@thinpad.lan.raisama.net> (raw)
In-Reply-To: <56BDC081.60402@suse.de>
On Fri, Feb 12, 2016 at 12:22:41PM +0100, Andreas Färber wrote:
> Am 12.02.2016 um 10:17 schrieb Marcel Apfelbaum:
> > On 02/11/2016 09:41 PM, Eduardo Habkost wrote:
> >> On Fri, Feb 05, 2016 at 09:51:07AM +0200, Marcel Apfelbaum wrote:
> >>> On 02/05/2016 09:49 AM, Markus Armbruster wrote:
> >>>> "Michael S. Tsirkin" <mst@redhat.com> writes:
> >>>>
> >>>>> On Thu, Feb 04, 2016 at 12:55:22PM +0100, Paolo Bonzini wrote:
> >>>>>>
> >>>>>>
> >>>>>> On 04/02/2016 12:41, Andreas Färber wrote:
> >>>>>>> You're talking about machine, right? Some time ago I had proposed
> >>>>>>> Marcel
> >>>>>>> who initially worked on it, but I'm fine with anyone taking it.
> >>>>>>
> >>>>>> Yes.
> >>>>>>
> >>>>>>> For some (but not all) core qdev parts related to the (stalled) QOM
> >>>>>>> migration I've been taking care of via qom-next. Last time this
> >>>>>>> came up
> >>>>>>> you didn't want anyone to be M: for qdev, so maybe we can use R:
> >>>>>>> so that
> >>>>>>> at least people automatically get CC'ed and we avoid this recurring
> >>>>>>> discussion?
> >>>>>>
> >>>>>> I might have changed my mind on that. You definitely should be M:
> >>>>>> for qdev.
> >>>>>>
> >>>>>> Paolo
> >>>>>
> >>>>> If Andreas wants to, that's also fine. Several maintainers are
> >>>>> better than one.
> >>>>
> >>>> *If* the maintainers are all willing and able to work together.
> >>>>
> >>>
> >>> No problem here from my point of view :)
> >>
> >> No problem to me, too. :)
> >>
> >> I am going to be away from work for 15 days starting on Tuesday
> >> Feb 16th. So if Marcel wants to start queueing patches already,
> >> please be my guest. I will be able to help on that after I'm
> >> back.
> >>
> >
> > Hi,
> >
> > If there are only a few patches on the mailing list, they can wait.
> > If the number will grow I'll send a pull request.
> >
> > So the MAINTAINER file should look like this, right?
> >
> > Regarding qdev, Andreas, I also think you are the most qualified
> > to take it, will you?
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 2d6ee17..a86491a 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1200,6 +1200,13 @@ F: docs/*qmp-*
> > F: scripts/qmp/
> > T: git git://repo.or.cz/qemu/armbru.git qapi-next
> >
> > +Machine
> > +M: Eduardo Habkost <ehabkost@redhat.com>
> > +M: Marcel Apfelbaum <marcel@redhat.com>
> > +S: Supported
> > +F: hw/core/machine.c
> > +F: include/hw/boards.h
> > +
>
> Fine with me, ack.
>
> For qdev.c itself I prefer not to create a misleading "QDev" section but
> rather just proposed a first step to split up qdev.c not just into
> common vs. system-only code but also in better maintainable subareas.
> That's targeted at having a section like "Core device API" covering a
> to-be-created device.c with myself plus some backup as maintainer, then
> Igor/mst/whomever for "Device hotplug interface" or the like.
> qdev-system.c we could consider to split up so that the block/net/char
> specific parts can be assigned clear maintainers - haven't investigated
> that part yet. In the meantime we could simply create multiple sections
> covering different aspects of qdev* files.
Related question: is it OK to have files appearing in multiple
sections? It would be useful for qdev*.c and vl.c. I would like
to be CCed in any vl.c patch affecting machine initialization,
for example.
--
Eduardo
next prev parent reply other threads:[~2016-02-12 18:18 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 10:54 [Qemu-devel] [PATCH v19 0/9] Virtual Machine Generation ID Igor Mammedov
2016-01-28 10:54 ` [Qemu-devel] [PATCH v19 1/9] acpi: extend ACPI interface to provide access to ACPI registers and SCI irq Igor Mammedov
2016-01-28 10:54 ` [Qemu-devel] [PATCH v19 2/9] docs: vm generation id device's description Igor Mammedov
2016-01-28 10:54 ` [Qemu-devel] [PATCH v19 3/9] pc: add a Virtual Machine Generation ID device Igor Mammedov
2016-01-28 11:13 ` Michael S. Tsirkin
2016-01-28 12:03 ` Igor Mammedov
2016-01-28 12:59 ` Michael S. Tsirkin
2016-01-29 11:13 ` Igor Mammedov
2016-01-31 16:22 ` Michael S. Tsirkin
2016-02-02 9:59 ` Igor Mammedov
2016-02-02 11:16 ` Michael S. Tsirkin
2016-02-09 10:46 ` Igor Mammedov
2016-02-09 12:17 ` Michael S. Tsirkin
2016-02-11 15:16 ` Igor Mammedov
2016-02-11 16:30 ` Michael S. Tsirkin
2016-02-11 17:34 ` Marcel Apfelbaum
2016-02-12 6:15 ` Michael S. Tsirkin
2016-02-15 10:30 ` Igor Mammedov
2016-02-15 11:26 ` Michael S. Tsirkin
2016-02-15 13:56 ` Igor Mammedov
2016-02-16 10:05 ` Marcel Apfelbaum
2016-02-16 12:17 ` Igor Mammedov
2016-02-16 12:36 ` Marcel Apfelbaum
2016-02-16 13:51 ` Igor Mammedov
2016-02-16 14:53 ` Michael S. Tsirkin
2016-02-16 15:10 ` Michael S. Tsirkin
2016-02-10 8:51 ` Michael S. Tsirkin
2016-02-10 9:28 ` Michael S. Tsirkin
2016-02-10 10:00 ` Laszlo Ersek
2016-01-28 13:48 ` Laszlo Ersek
2016-01-28 10:54 ` [Qemu-devel] [PATCH v19 4/9] tests: add a unit test for the vmgenid device Igor Mammedov
2016-01-28 10:54 ` [Qemu-devel] [PATCH v19 5/9] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands Igor Mammedov
2016-02-09 17:31 ` Eric Blake
2016-01-28 10:54 ` [Qemu-devel] [PATCH v19 6/9] qmp/hmp: add set-vm-generation-id commands Igor Mammedov
2016-02-09 17:33 ` Eric Blake
2016-01-28 10:54 ` [Qemu-devel] [PATCH v19 8/9] pc: put PIIX3 in slot 1 explicitly and cleanup functions assignment Igor Mammedov
2016-01-28 10:54 ` [Qemu-devel] [PATCH v19 9/9] pc/q53: by default put vmgenid device as an function of ISA bridge Igor Mammedov
2016-01-28 10:58 ` [Qemu-devel] [PATCH v19 7/9] machine: add properties to compat_props incrementaly Igor Mammedov
2016-01-28 14:02 ` Eduardo Habkost
2016-01-28 17:00 ` Igor Mammedov
2016-02-03 17:55 ` [Qemu-devel] qdev & hw/core owner? (was Re: [PATCH v19 7/9] machine: add properties to compat_props incrementaly) Eduardo Habkost
2016-02-03 18:46 ` Laszlo Ersek
2016-02-03 19:06 ` Michael S. Tsirkin
2016-02-04 11:31 ` Paolo Bonzini
2016-02-04 11:41 ` Andreas Färber
2016-02-04 11:55 ` Paolo Bonzini
2016-02-04 12:06 ` Michael S. Tsirkin
2016-02-05 7:49 ` Markus Armbruster
2016-02-05 7:51 ` Marcel Apfelbaum
2016-02-11 19:41 ` Eduardo Habkost
2016-02-12 9:17 ` Marcel Apfelbaum
2016-02-12 11:22 ` Andreas Färber
2016-02-12 18:17 ` Eduardo Habkost [this message]
2016-02-12 22:30 ` Paolo Bonzini
2016-02-12 18:09 ` Eduardo Habkost
2016-02-05 7:52 ` Markus Armbruster
2016-02-04 12:03 ` Michael S. Tsirkin
2016-02-04 12:12 ` Marcel Apfelbaum
2016-01-29 12:51 ` [Qemu-devel] [PATCH v19 7/9] machine: add properties to compat_props incrementaly Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212181754.GI6239@thinpad.lan.raisama.net \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=ghammer@redhat.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).