From: Eduardo Habkost <ehabkost@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: agraf@suse.de, mst@redhat.com, ghammer@redhat.com,
lersek@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com,
borntraeger@de.ibm.com, qemu-ppc@nongnu.org,
cornelia.huck@de.ibm.com, pbonzini@redhat.com, rth@twiddle.net,
david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH v19 7/9] machine: add properties to compat_props incrementaly
Date: Thu, 28 Jan 2016 12:02:12 -0200 [thread overview]
Message-ID: <20160128140212.GS3869@thinpad.lan.raisama.net> (raw)
In-Reply-To: <1453978688-222752-1-git-send-email-imammedo@redhat.com>
On Thu, Jan 28, 2016 at 11:58:08AM +0100, Igor Mammedov wrote:
> Switch to adding compat properties incrementaly instead of
> completly overwriting compat_props per machine type.
> That removes data duplication which we have due to nested
> [PC|SPAPR]_COMPAT_* macros.
>
> It also allows to set default device properties from
> default foo_machine_options() hook, which will be used
> in following patch for putting VMGENID device as
> a function if ISA bridge on pc/q35 machines.
>
> Suggested-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>
Very nice. The only suggestion I have is to use the simpler GList
type, instead of GArray.
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
> compat_props GArray
I assume this line was left here by mistake?
> ---
> hw/core/machine.c | 10 ++++++++++
> hw/ppc/spapr.c | 3 ---
> hw/s390x/s390-virtio-ccw.c | 12 ++----------
> include/hw/boards.h | 11 +++++++++--
> include/hw/i386/pc.h | 9 ---------
> vl.c | 6 +++++-
> 6 files changed, 26 insertions(+), 25 deletions(-)
[...]
--
Eduardo
next prev parent reply other threads:[~2016-01-28 14:02 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 10:54 [Qemu-devel] [PATCH v19 0/9] Virtual Machine Generation ID Igor Mammedov
2016-01-28 10:54 ` [Qemu-devel] [PATCH v19 1/9] acpi: extend ACPI interface to provide access to ACPI registers and SCI irq Igor Mammedov
2016-01-28 10:54 ` [Qemu-devel] [PATCH v19 2/9] docs: vm generation id device's description Igor Mammedov
2016-01-28 10:54 ` [Qemu-devel] [PATCH v19 3/9] pc: add a Virtual Machine Generation ID device Igor Mammedov
2016-01-28 11:13 ` Michael S. Tsirkin
2016-01-28 12:03 ` Igor Mammedov
2016-01-28 12:59 ` Michael S. Tsirkin
2016-01-29 11:13 ` Igor Mammedov
2016-01-31 16:22 ` Michael S. Tsirkin
2016-02-02 9:59 ` Igor Mammedov
2016-02-02 11:16 ` Michael S. Tsirkin
2016-02-09 10:46 ` Igor Mammedov
2016-02-09 12:17 ` Michael S. Tsirkin
2016-02-11 15:16 ` Igor Mammedov
2016-02-11 16:30 ` Michael S. Tsirkin
2016-02-11 17:34 ` Marcel Apfelbaum
2016-02-12 6:15 ` Michael S. Tsirkin
2016-02-15 10:30 ` Igor Mammedov
2016-02-15 11:26 ` Michael S. Tsirkin
2016-02-15 13:56 ` Igor Mammedov
2016-02-16 10:05 ` Marcel Apfelbaum
2016-02-16 12:17 ` Igor Mammedov
2016-02-16 12:36 ` Marcel Apfelbaum
2016-02-16 13:51 ` Igor Mammedov
2016-02-16 14:53 ` Michael S. Tsirkin
2016-02-16 15:10 ` Michael S. Tsirkin
2016-02-10 8:51 ` Michael S. Tsirkin
2016-02-10 9:28 ` Michael S. Tsirkin
2016-02-10 10:00 ` Laszlo Ersek
2016-01-28 13:48 ` Laszlo Ersek
2016-01-28 10:54 ` [Qemu-devel] [PATCH v19 4/9] tests: add a unit test for the vmgenid device Igor Mammedov
2016-01-28 10:54 ` [Qemu-devel] [PATCH v19 5/9] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands Igor Mammedov
2016-02-09 17:31 ` Eric Blake
2016-01-28 10:54 ` [Qemu-devel] [PATCH v19 6/9] qmp/hmp: add set-vm-generation-id commands Igor Mammedov
2016-02-09 17:33 ` Eric Blake
2016-01-28 10:54 ` [Qemu-devel] [PATCH v19 8/9] pc: put PIIX3 in slot 1 explicitly and cleanup functions assignment Igor Mammedov
2016-01-28 10:54 ` [Qemu-devel] [PATCH v19 9/9] pc/q53: by default put vmgenid device as an function of ISA bridge Igor Mammedov
2016-01-28 10:58 ` [Qemu-devel] [PATCH v19 7/9] machine: add properties to compat_props incrementaly Igor Mammedov
2016-01-28 14:02 ` Eduardo Habkost [this message]
2016-01-28 17:00 ` Igor Mammedov
2016-02-03 17:55 ` [Qemu-devel] qdev & hw/core owner? (was Re: [PATCH v19 7/9] machine: add properties to compat_props incrementaly) Eduardo Habkost
2016-02-03 18:46 ` Laszlo Ersek
2016-02-03 19:06 ` Michael S. Tsirkin
2016-02-04 11:31 ` Paolo Bonzini
2016-02-04 11:41 ` Andreas Färber
2016-02-04 11:55 ` Paolo Bonzini
2016-02-04 12:06 ` Michael S. Tsirkin
2016-02-05 7:49 ` Markus Armbruster
2016-02-05 7:51 ` Marcel Apfelbaum
2016-02-11 19:41 ` Eduardo Habkost
2016-02-12 9:17 ` Marcel Apfelbaum
2016-02-12 11:22 ` Andreas Färber
2016-02-12 18:17 ` Eduardo Habkost
2016-02-12 22:30 ` Paolo Bonzini
2016-02-12 18:09 ` Eduardo Habkost
2016-02-05 7:52 ` Markus Armbruster
2016-02-04 12:03 ` Michael S. Tsirkin
2016-02-04 12:12 ` Marcel Apfelbaum
2016-01-29 12:51 ` [Qemu-devel] [PATCH v19 7/9] machine: add properties to compat_props incrementaly Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128140212.GS3869@thinpad.lan.raisama.net \
--to=ehabkost@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=ghammer@redhat.com \
--cc=imammedo@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).