Re: [Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup from RngEgd to RngBackend

[Amit Shah <amit.shah@redhat.com>]

On (Wed) 02 Mar 2016 [09:32:48], Ladi Prosek wrote:
> On Wed, Mar 2, 2016 at 8:15 AM, Amit Shah <amit.shah@redhat.com> wrote:
> > On (Wed) 10 Feb 2016 [16:53:24], Ladi Prosek wrote:
> >> RngBackend is now in charge of cleaning up the linked list on
> >> instance finalization. It also exposes a function to finalize
> >> individual RngRequest instances, called by its child classes.
> >>
> >> Signed-off-by: Ladi Prosek <lprosek@redhat.com>
> >
> >> @@ -183,8 +162,6 @@ static void rng_egd_finalize(Object *obj)
> >>      }
> >>
> >>      g_free(s->chr_name);
> >> -
> >> -    rng_egd_free_requests(s);
> >
> > Missing call to rng_backend_free_requests()?
> 
> Not needed here, this is handled by the parent class. Its
> instance_finalize callback calls rng_backend_free_requests.

OK.

> >> diff --git a/include/sysemu/rng.h b/include/sysemu/rng.h
> >> index 084164c..c2c9035 100644
> >> --- a/include/sysemu/rng.h
> >> +++ b/include/sysemu/rng.h
> >> @@ -61,6 +61,7 @@ struct RngBackend
> >>      GSList *requests;
> >>  };
> >>
> >> +
> >>  /**
> >
> > Extra whitespace?
> 
> This was intentional to separate internal declarations and public
> entry points. Same thing exists for example in tpm_backend.h in the
> same directory. I can certainly delete the empty line if you'd prefer
> that.

No, this is fine, and I agree with the separation.

		Amit