From: Paolo Bonzini <pbonzini@redhat.com>
To: Ladi Prosek <lprosek@redhat.com>
Cc: amit shah <amit.shah@redhat.com>,
pagupta@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 4/4] rng: add request queue support to rng-random
Date: Wed, 10 Feb 2016 17:40:43 +0100 [thread overview]
Message-ID: <56BB680B.7050304@redhat.com> (raw)
In-Reply-To: <51909770.35566233.1455122403597.JavaMail.zimbra@redhat.com>
On 10/02/2016 17:40, Ladi Prosek wrote:
>>
>>
>> On 10/02/2016 16:53, Ladi Prosek wrote:
>>> + req->size = size;
>>> + req->receive_entropy = receive_entropy;
>>> + req->opaque = opaque;
>>> + req->data = g_malloc(req->size);
>>> +
>>> + k->request_entropy(s, req);
>>> +
>>> + s->requests = g_slist_append(s->requests, req);
>>> }
>>
>> g_slist_append has to traverse the entire list to find the place to add
>> the node. You probably are better off using QSIMPLEQ (which is an
>> intrusive list unlike GSList).
>
> This is what rng-egd does today and I would argue that since the expected
> length of the list is very small - it's going to be longer than 1 only
> very rarely - a simple lightweight data structure is a better choice than
> trying to be O(1) in the worst case.
>
> I'll be happy to switch to QSIMPLEQ if you want though. Your call.
Ok, it can be done on top I guess. I'll let others review the patches
more closely!
Paolo
next prev parent reply other threads:[~2016-02-10 16:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 15:53 [Qemu-devel] [PATCH v2 0/4] rng-random: implement request queue Ladi Prosek
2016-02-10 15:53 ` [Qemu-devel] [PATCH v2 1/4] rng: remove the unused request cancellation code Ladi Prosek
2016-02-10 15:53 ` [Qemu-devel] [PATCH v2 2/4] rng: move request queue from RngEgd to RngBackend Ladi Prosek
2016-02-10 15:53 ` [Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup " Ladi Prosek
2016-03-02 7:15 ` Amit Shah
2016-03-02 8:32 ` Ladi Prosek
2016-03-02 9:56 ` Amit Shah
2016-02-10 15:53 ` [Qemu-devel] [PATCH v2 4/4] rng: add request queue support to rng-random Ladi Prosek
2016-02-10 16:23 ` Paolo Bonzini
2016-02-10 16:40 ` Ladi Prosek
2016-02-10 16:40 ` Paolo Bonzini [this message]
2016-03-02 9:56 ` Amit Shah
2016-03-02 10:07 ` Ladi Prosek
2016-02-15 13:36 ` [Qemu-devel] [PATCH v2 0/4] rng-random: implement request queue Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BB680B.7050304@redhat.com \
--to=pbonzini@redhat.com \
--cc=amit.shah@redhat.com \
--cc=lprosek@redhat.com \
--cc=pagupta@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).