Re: [Qemu-devel] [PATCH v2 4/4] rng: add request queue support to rng-random

[Paolo Bonzini <pbonzini@redhat.com>]

On 10/02/2016 16:53, Ladi Prosek wrote:
> +        req->size = size;
> +        req->receive_entropy = receive_entropy;
> +        req->opaque = opaque;
> +        req->data = g_malloc(req->size);
> +
> +        k->request_entropy(s, req);
> +
> +        s->requests = g_slist_append(s->requests, req);
>      }

g_slist_append has to traverse the entire list to find the place to add
the node.  You probably are better off using QSIMPLEQ (which is an
intrusive list unlike GSList).

Thanks,

Paolo