* [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c
@ 2019-06-24 12:38 Alex Bennée
2019-06-24 12:51 ` Vitaly Kuznetsov
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Alex Bennée @ 2019-06-24 12:38 UTC (permalink / raw)
To: peter.maydell
Cc: Eduardo Habkost, qemu-devel, Roman Kagan, Paolo Bonzini,
Vitaly Kuznetsov, Alex Bennée, Richard Henderson
Commit 2d384d7c8 broken the build when built with:
configure --without-default-devices --disable-user
The reason was the conversion of cpu->hyperv_synic to
cpu->hyperv_synic_kvm_only although the rest of the patch introduces a
feature checking mechanism. So I've fixed the KVM_EXIT_HYPERV_SYNIC in
hyperv-stub to do the same feature check as in the real hyperv.c
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Roman Kagan <rkagan@virtuozzo.com>
---
target/i386/hyperv-stub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/hyperv-stub.c b/target/i386/hyperv-stub.c
index fe548cbae2..0028527e79 100644
--- a/target/i386/hyperv-stub.c
+++ b/target/i386/hyperv-stub.c
@@ -15,7 +15,7 @@ int kvm_hv_handle_exit(X86CPU *cpu, struct kvm_hyperv_exit *exit)
{
switch (exit->type) {
case KVM_EXIT_HYPERV_SYNIC:
- if (!cpu->hyperv_synic) {
+ if (!hyperv_feat_enabled(cpu, HYPERV_FEAT_SYNIC)) {
return -1;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c
2019-06-24 12:38 [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c Alex Bennée
@ 2019-06-24 12:51 ` Vitaly Kuznetsov
2019-06-24 13:22 ` Paolo Bonzini
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Vitaly Kuznetsov @ 2019-06-24 12:51 UTC (permalink / raw)
To: Alex Bennée
Cc: peter.maydell, Eduardo Habkost, qemu-devel, Roman Kagan,
Paolo Bonzini, Alex Bennée, Richard Henderson
Alex Bennée <alex.bennee@linaro.org> writes:
> Commit 2d384d7c8 broken the build when built with:
>
> configure --without-default-devices --disable-user
>
> The reason was the conversion of cpu->hyperv_synic to
> cpu->hyperv_synic_kvm_only although the rest of the patch introduces a
> feature checking mechanism. So I've fixed the KVM_EXIT_HYPERV_SYNIC in
> hyperv-stub to do the same feature check as in the real hyperv.c
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Roman Kagan <rkagan@virtuozzo.com>
> ---
> target/i386/hyperv-stub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/hyperv-stub.c b/target/i386/hyperv-stub.c
> index fe548cbae2..0028527e79 100644
> --- a/target/i386/hyperv-stub.c
> +++ b/target/i386/hyperv-stub.c
> @@ -15,7 +15,7 @@ int kvm_hv_handle_exit(X86CPU *cpu, struct kvm_hyperv_exit *exit)
> {
> switch (exit->type) {
> case KVM_EXIT_HYPERV_SYNIC:
> - if (!cpu->hyperv_synic) {
> + if (!hyperv_feat_enabled(cpu, HYPERV_FEAT_SYNIC)) {
> return -1;
> }
As I just sent out exactly the same patch, this probably means the fix
is uncontroversial :-)
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c
2019-06-24 12:38 [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c Alex Bennée
2019-06-24 12:51 ` Vitaly Kuznetsov
@ 2019-06-24 13:22 ` Paolo Bonzini
2019-06-24 13:37 ` Paolo Bonzini
2019-06-24 13:56 ` Roman Kagan
2019-06-26 15:30 ` Christophe de Dinechin
3 siblings, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2019-06-24 13:22 UTC (permalink / raw)
To: Alex Bennée, peter.maydell
Cc: Vitaly Kuznetsov, Richard Henderson, qemu-devel, Eduardo Habkost,
Roman Kagan
On 24/06/19 14:38, Alex Bennée wrote:
> Commit 2d384d7c8 broken the build when built with:
>
> configure --without-default-devices --disable-user
>
> The reason was the conversion of cpu->hyperv_synic to
> cpu->hyperv_synic_kvm_only although the rest of the patch introduces a
> feature checking mechanism. So I've fixed the KVM_EXIT_HYPERV_SYNIC in
> hyperv-stub to do the same feature check as in the real hyperv.c
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Roman Kagan <rkagan@virtuozzo.com>
> ---
> target/i386/hyperv-stub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/hyperv-stub.c b/target/i386/hyperv-stub.c
> index fe548cbae2..0028527e79 100644
> --- a/target/i386/hyperv-stub.c
> +++ b/target/i386/hyperv-stub.c
> @@ -15,7 +15,7 @@ int kvm_hv_handle_exit(X86CPU *cpu, struct kvm_hyperv_exit *exit)
> {
> switch (exit->type) {
> case KVM_EXIT_HYPERV_SYNIC:
> - if (!cpu->hyperv_synic) {
> + if (!hyperv_feat_enabled(cpu, HYPERV_FEAT_SYNIC)) {
> return -1;
> }
>
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c
2019-06-24 13:22 ` Paolo Bonzini
@ 2019-06-24 13:37 ` Paolo Bonzini
2019-06-25 18:41 ` Eduardo Habkost
0 siblings, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2019-06-24 13:37 UTC (permalink / raw)
To: Alex Bennée, peter.maydell
Cc: Vitaly Kuznetsov, Richard Henderson, qemu-devel, Eduardo Habkost,
Roman Kagan
On 24/06/19 15:22, Paolo Bonzini wrote:
> On 24/06/19 14:38, Alex Bennée wrote:
>> Commit 2d384d7c8 broken the build when built with:
>>
>> configure --without-default-devices --disable-user
>>
>> The reason was the conversion of cpu->hyperv_synic to
>> cpu->hyperv_synic_kvm_only although the rest of the patch introduces a
>> feature checking mechanism. So I've fixed the KVM_EXIT_HYPERV_SYNIC in
>> hyperv-stub to do the same feature check as in the real hyperv.c
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Roman Kagan <rkagan@virtuozzo.com>
>> ---
>> target/i386/hyperv-stub.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/i386/hyperv-stub.c b/target/i386/hyperv-stub.c
>> index fe548cbae2..0028527e79 100644
>> --- a/target/i386/hyperv-stub.c
>> +++ b/target/i386/hyperv-stub.c
>> @@ -15,7 +15,7 @@ int kvm_hv_handle_exit(X86CPU *cpu, struct kvm_hyperv_exit *exit)
>> {
>> switch (exit->type) {
>> case KVM_EXIT_HYPERV_SYNIC:
>> - if (!cpu->hyperv_synic) {
>> + if (!hyperv_feat_enabled(cpu, HYPERV_FEAT_SYNIC)) {
>> return -1;
>> }
>>
>>
>
> Queued, thanks.
Alex will queue it instead, so
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c
2019-06-24 12:38 [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c Alex Bennée
2019-06-24 12:51 ` Vitaly Kuznetsov
2019-06-24 13:22 ` Paolo Bonzini
@ 2019-06-24 13:56 ` Roman Kagan
2019-06-26 15:30 ` Christophe de Dinechin
3 siblings, 0 replies; 7+ messages in thread
From: Roman Kagan @ 2019-06-24 13:56 UTC (permalink / raw)
To: Alex Bennée
Cc: peter.maydell, Eduardo Habkost, qemu-devel, Paolo Bonzini,
Vitaly Kuznetsov, Richard Henderson
On Mon, Jun 24, 2019 at 01:38:35PM +0100, Alex Bennée wrote:
> Commit 2d384d7c8 broken the build when built with:
>
> configure --without-default-devices --disable-user
>
> The reason was the conversion of cpu->hyperv_synic to
> cpu->hyperv_synic_kvm_only although the rest of the patch introduces a
> feature checking mechanism. So I've fixed the KVM_EXIT_HYPERV_SYNIC in
> hyperv-stub to do the same feature check as in the real hyperv.c
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Roman Kagan <rkagan@virtuozzo.com>
> ---
> target/i386/hyperv-stub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Roman Kagan <rkagan@virtuozzo.com>
>
> diff --git a/target/i386/hyperv-stub.c b/target/i386/hyperv-stub.c
> index fe548cbae2..0028527e79 100644
> --- a/target/i386/hyperv-stub.c
> +++ b/target/i386/hyperv-stub.c
> @@ -15,7 +15,7 @@ int kvm_hv_handle_exit(X86CPU *cpu, struct kvm_hyperv_exit *exit)
> {
> switch (exit->type) {
> case KVM_EXIT_HYPERV_SYNIC:
> - if (!cpu->hyperv_synic) {
> + if (!hyperv_feat_enabled(cpu, HYPERV_FEAT_SYNIC)) {
> return -1;
> }
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c
2019-06-24 13:37 ` Paolo Bonzini
@ 2019-06-25 18:41 ` Eduardo Habkost
0 siblings, 0 replies; 7+ messages in thread
From: Eduardo Habkost @ 2019-06-25 18:41 UTC (permalink / raw)
To: Paolo Bonzini
Cc: peter.maydell, qemu-devel, Roman Kagan, Vitaly Kuznetsov,
Alex Bennée, Richard Henderson
On Mon, Jun 24, 2019 at 03:37:24PM +0200, Paolo Bonzini wrote:
> On 24/06/19 15:22, Paolo Bonzini wrote:
> > On 24/06/19 14:38, Alex Bennée wrote:
> >> Commit 2d384d7c8 broken the build when built with:
> >>
> >> configure --without-default-devices --disable-user
> >>
> >> The reason was the conversion of cpu->hyperv_synic to
> >> cpu->hyperv_synic_kvm_only although the rest of the patch introduces a
> >> feature checking mechanism. So I've fixed the KVM_EXIT_HYPERV_SYNIC in
> >> hyperv-stub to do the same feature check as in the real hyperv.c
> >>
> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> >> Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
> >> Cc: Paolo Bonzini <pbonzini@redhat.com>
> >> Cc: Roman Kagan <rkagan@virtuozzo.com>
> >> ---
> >> target/i386/hyperv-stub.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/target/i386/hyperv-stub.c b/target/i386/hyperv-stub.c
> >> index fe548cbae2..0028527e79 100644
> >> --- a/target/i386/hyperv-stub.c
> >> +++ b/target/i386/hyperv-stub.c
> >> @@ -15,7 +15,7 @@ int kvm_hv_handle_exit(X86CPU *cpu, struct kvm_hyperv_exit *exit)
> >> {
> >> switch (exit->type) {
> >> case KVM_EXIT_HYPERV_SYNIC:
> >> - if (!cpu->hyperv_synic) {
> >> + if (!hyperv_feat_enabled(cpu, HYPERV_FEAT_SYNIC)) {
> >> return -1;
> >> }
> >>
> >>
> >
> > Queued, thanks.
>
> Alex will queue it instead, so
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
I was planning to send a machine + x86 pull request today, and
I'll have to include to make sure builds won't fail. I don't
think this should prevent the patch from being applied to other
trees, though.
--
Eduardo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c
2019-06-24 12:38 [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c Alex Bennée
` (2 preceding siblings ...)
2019-06-24 13:56 ` Roman Kagan
@ 2019-06-26 15:30 ` Christophe de Dinechin
3 siblings, 0 replies; 7+ messages in thread
From: Christophe de Dinechin @ 2019-06-26 15:30 UTC (permalink / raw)
To: Alex Bennée
Cc: Peter Maydell, Eduardo Habkost, qemu-devel, Roman Kagan,
Paolo Bonzini, Vitaly Kuznetsov, Richard Henderson
> On 24 Jun 2019, at 14:38, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Commit 2d384d7c8 broken the build when built with:
>
> configure --without-default-devices --disable-user
>
> The reason was the conversion of cpu->hyperv_synic to
> cpu->hyperv_synic_kvm_only although the rest of the patch introduces a
> feature checking mechanism. So I've fixed the KVM_EXIT_HYPERV_SYNIC in
> hyperv-stub to do the same feature check as in the real hyperv.c
Sorry, I failed to check on the mailing list before sending an exact
duplicate of this patch…
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Roman Kagan <rkagan@virtuozzo.com>
> ---
> target/i386/hyperv-stub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/hyperv-stub.c b/target/i386/hyperv-stub.c
> index fe548cbae2..0028527e79 100644
> --- a/target/i386/hyperv-stub.c
> +++ b/target/i386/hyperv-stub.c
> @@ -15,7 +15,7 @@ int kvm_hv_handle_exit(X86CPU *cpu, struct kvm_hyperv_exit *exit)
> {
> switch (exit->type) {
> case KVM_EXIT_HYPERV_SYNIC:
> - if (!cpu->hyperv_synic) {
> + if (!hyperv_feat_enabled(cpu, HYPERV_FEAT_SYNIC)) {
> return -1;
> }
>
> --
> 2.20.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-06-26 15:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-24 12:38 [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c Alex Bennée
2019-06-24 12:51 ` Vitaly Kuznetsov
2019-06-24 13:22 ` Paolo Bonzini
2019-06-24 13:37 ` Paolo Bonzini
2019-06-25 18:41 ` Eduardo Habkost
2019-06-24 13:56 ` Roman Kagan
2019-06-26 15:30 ` Christophe de Dinechin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).