* [Qemu-devel] [PATCH] hw/net/e1000: Fix erroneous comment
@ 2019-07-15 10:22 Philippe Mathieu-Daudé
2019-07-15 11:01 ` Markus Armbruster
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-07-15 10:22 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Jason Wang, Philippe Mathieu-Daudé, Markus Armbruster
Missed during the QOM convertion in 9af21dbee14.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/net/e1000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/e1000.c b/hw/net/e1000.c
index 1dc1466332..ec8ded7252 100644
--- a/hw/net/e1000.c
+++ b/hw/net/e1000.c
@@ -1611,7 +1611,7 @@ static const VMStateDescription vmstate_e1000 = {
/*
* EEPROM contents documented in Tables 5-2 and 5-3, pp. 98-102.
- * Note: A valid DevId will be inserted during pci_e1000_init().
+ * Note: A valid DevId will be inserted during pci_e1000_realize().
*/
static const uint16_t e1000_eeprom_template[64] = {
0x0000, 0x0000, 0x0000, 0x0000, 0xffff, 0x0000, 0x0000, 0x0000,
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/net/e1000: Fix erroneous comment
2019-07-15 10:22 [Qemu-devel] [PATCH] hw/net/e1000: Fix erroneous comment Philippe Mathieu-Daudé
@ 2019-07-15 11:01 ` Markus Armbruster
2019-07-15 11:19 ` Stefano Garzarella
2019-08-21 8:42 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Markus Armbruster @ 2019-07-15 11:01 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: qemu-trivial, Jason Wang, qemu-devel
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> Missed during the QOM convertion in 9af21dbee14.
Ooops.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/net/e1000.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/e1000.c b/hw/net/e1000.c
> index 1dc1466332..ec8ded7252 100644
> --- a/hw/net/e1000.c
> +++ b/hw/net/e1000.c
> @@ -1611,7 +1611,7 @@ static const VMStateDescription vmstate_e1000 = {
>
> /*
> * EEPROM contents documented in Tables 5-2 and 5-3, pp. 98-102.
> - * Note: A valid DevId will be inserted during pci_e1000_init().
> + * Note: A valid DevId will be inserted during pci_e1000_realize().
> */
> static const uint16_t e1000_eeprom_template[64] = {
> 0x0000, 0x0000, 0x0000, 0x0000, 0xffff, 0x0000, 0x0000, 0x0000,
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/net/e1000: Fix erroneous comment
2019-07-15 10:22 [Qemu-devel] [PATCH] hw/net/e1000: Fix erroneous comment Philippe Mathieu-Daudé
2019-07-15 11:01 ` Markus Armbruster
@ 2019-07-15 11:19 ` Stefano Garzarella
2019-08-21 8:42 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Stefano Garzarella @ 2019-07-15 11:19 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-trivial, Jason Wang, qemu-devel, Markus Armbruster
On Mon, Jul 15, 2019 at 12:22:10PM +0200, Philippe Mathieu-Daudé wrote:
> Missed during the QOM convertion in 9af21dbee14.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/net/e1000.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/e1000.c b/hw/net/e1000.c
> index 1dc1466332..ec8ded7252 100644
> --- a/hw/net/e1000.c
> +++ b/hw/net/e1000.c
> @@ -1611,7 +1611,7 @@ static const VMStateDescription vmstate_e1000 = {
>
> /*
> * EEPROM contents documented in Tables 5-2 and 5-3, pp. 98-102.
> - * Note: A valid DevId will be inserted during pci_e1000_init().
> + * Note: A valid DevId will be inserted during pci_e1000_realize().
> */
> static const uint16_t e1000_eeprom_template[64] = {
> 0x0000, 0x0000, 0x0000, 0x0000, 0xffff, 0x0000, 0x0000, 0x0000,
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/net/e1000: Fix erroneous comment
2019-07-15 10:22 [Qemu-devel] [PATCH] hw/net/e1000: Fix erroneous comment Philippe Mathieu-Daudé
2019-07-15 11:01 ` Markus Armbruster
2019-07-15 11:19 ` Stefano Garzarella
@ 2019-08-21 8:42 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2019-08-21 8:42 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, Jason Wang, Markus Armbruster
Le 15/07/2019 à 12:22, Philippe Mathieu-Daudé a écrit :
> Missed during the QOM convertion in 9af21dbee14.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/net/e1000.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/e1000.c b/hw/net/e1000.c
> index 1dc1466332..ec8ded7252 100644
> --- a/hw/net/e1000.c
> +++ b/hw/net/e1000.c
> @@ -1611,7 +1611,7 @@ static const VMStateDescription vmstate_e1000 = {
>
> /*
> * EEPROM contents documented in Tables 5-2 and 5-3, pp. 98-102.
> - * Note: A valid DevId will be inserted during pci_e1000_init().
> + * Note: A valid DevId will be inserted during pci_e1000_realize().
> */
> static const uint16_t e1000_eeprom_template[64] = {
> 0x0000, 0x0000, 0x0000, 0x0000, 0xffff, 0x0000, 0x0000, 0x0000,
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-21 9:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-15 10:22 [Qemu-devel] [PATCH] hw/net/e1000: Fix erroneous comment Philippe Mathieu-Daudé
2019-07-15 11:01 ` Markus Armbruster
2019-07-15 11:19 ` Stefano Garzarella
2019-08-21 8:42 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).