[Qemu-devel] [PATCH] hw/net/e1000: Fix erroneous comment

[Qemu-devel] [PATCH] hw/net/e1000: Fix erroneous comment

[Philippe Mathieu-Daudé]

Missed during the QOM convertion in 9af21dbee14.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/net/e1000.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/e1000.c b/hw/net/e1000.c
index 1dc1466332..ec8ded7252 100644
--- a/hw/net/e1000.c
+++ b/hw/net/e1000.c
@@ -1611,7 +1611,7 @@ static const VMStateDescription vmstate_e1000 = {
 
 /*
  * EEPROM contents documented in Tables 5-2 and 5-3, pp. 98-102.
- * Note: A valid DevId will be inserted during pci_e1000_init().
+ * Note: A valid DevId will be inserted during pci_e1000_realize().
  */
 static const uint16_t e1000_eeprom_template[64] = {
     0x0000, 0x0000, 0x0000, 0x0000,      0xffff, 0x0000,      0x0000, 0x0000,
-- 
2.20.1

Re: [Qemu-devel] [PATCH] hw/net/e1000: Fix erroneous comment

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> Missed during the QOM convertion in 9af21dbee14.

Ooops.

>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/net/e1000.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/e1000.c b/hw/net/e1000.c
> index 1dc1466332..ec8ded7252 100644
> --- a/hw/net/e1000.c
> +++ b/hw/net/e1000.c
> @@ -1611,7 +1611,7 @@ static const VMStateDescription vmstate_e1000 = {
>  
>  /*
>   * EEPROM contents documented in Tables 5-2 and 5-3, pp. 98-102.
> - * Note: A valid DevId will be inserted during pci_e1000_init().
> + * Note: A valid DevId will be inserted during pci_e1000_realize().
>   */
>  static const uint16_t e1000_eeprom_template[64] = {
>      0x0000, 0x0000, 0x0000, 0x0000,      0xffff, 0x0000,      0x0000, 0x0000,

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Re: [Qemu-devel] [PATCH] hw/net/e1000: Fix erroneous comment

[Stefano Garzarella]

On Mon, Jul 15, 2019 at 12:22:10PM +0200, Philippe Mathieu-Daudé wrote:
> Missed during the QOM convertion in 9af21dbee14.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/net/e1000.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/net/e1000.c b/hw/net/e1000.c
> index 1dc1466332..ec8ded7252 100644
> --- a/hw/net/e1000.c
> +++ b/hw/net/e1000.c
> @@ -1611,7 +1611,7 @@ static const VMStateDescription vmstate_e1000 = {
>  
>  /*
>   * EEPROM contents documented in Tables 5-2 and 5-3, pp. 98-102.
> - * Note: A valid DevId will be inserted during pci_e1000_init().
> + * Note: A valid DevId will be inserted during pci_e1000_realize().
>   */
>  static const uint16_t e1000_eeprom_template[64] = {
>      0x0000, 0x0000, 0x0000, 0x0000,      0xffff, 0x0000,      0x0000, 0x0000,

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/net/e1000: Fix erroneous comment

[Laurent Vivier]

Le 15/07/2019 à 12:22, Philippe Mathieu-Daudé a écrit :
> Missed during the QOM convertion in 9af21dbee14.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/net/e1000.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/net/e1000.c b/hw/net/e1000.c
> index 1dc1466332..ec8ded7252 100644
> --- a/hw/net/e1000.c
> +++ b/hw/net/e1000.c
> @@ -1611,7 +1611,7 @@ static const VMStateDescription vmstate_e1000 = {
>  
>  /*
>   * EEPROM contents documented in Tables 5-2 and 5-3, pp. 98-102.
> - * Note: A valid DevId will be inserted during pci_e1000_init().
> + * Note: A valid DevId will be inserted during pci_e1000_realize().
>   */
>  static const uint16_t e1000_eeprom_template[64] = {
>      0x0000, 0x0000, 0x0000, 0x0000,      0xffff, 0x0000,      0x0000, 0x0000,
> 

Applied to my trivial-patches branch.

Thanks,
Laurent