From: Andrew Jones <drjones@redhat.com>
To: Dave Martin <Dave.Martin@arm.com>
Cc: "peter.maydell@linaro.org" <peter.maydell@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"armbru@redhat.com" <armbru@redhat.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"imammedo@redhat.com" <imammedo@redhat.com>,
"alex.bennee@linaro.org" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2 10/14] target/arm/kvm64: Add kvm_arch_get/put_sve
Date: Wed, 17 Jul 2019 11:25:42 +0200 [thread overview]
Message-ID: <20190717092542.hkzcukvc3bwgvvk5@kamzik.brq.redhat.com> (raw)
In-Reply-To: <20190627150224.GH2790@e103592.cambridge.arm.com>
On Thu, Jun 27, 2019 at 04:02:24PM +0100, Dave Martin wrote:
> Either way, it's entirely reasonable for userspace not to try to support
> additional slices for now. We'll have plenty of time to plan away
> across that bridge when we spot it on the horizon...
Which makes me inclined to keep the get/put register code the way it is
in this patch, at least with regards to the hard coded number of slices
and the build-bug. The way it's written (to me) serves to document the
state of things, rather than truly implement anything, but also (to me)
it's easier to understand that code than would be a couple of paragraphs
of actual documentation trying to explain it.
> > Within QEMU, it has so far made sense to keep the data in 64-bit hunks in
> > host-endian order. That's how the AdvSIMD code was written originally, and it
> > turned out to be easy enough to continue that for SVE.
>
> Fair enough. It's entirely up to QEMU to decide -- I just wanted to
> check that there was no misunderstanding about this issue in the ABI.
We do need to use/swap-to host-endian when we implement the monitor's
dump-guest-memory command, at it also creates ELF notes for the general
and VFP (and, coming soon, SVE) registers. Implementing those ELF notes
for SVE is on my TODO, right after this series.
Thanks,
drew
next prev parent reply other threads:[~2019-07-17 9:26 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 16:34 [Qemu-devel] [PATCH v2 00/14] target/arm/kvm: enable SVE in guests Andrew Jones
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 01/14] target/arm/cpu64: Ensure kvm really supports aarch64=off Andrew Jones
2019-06-25 9:35 ` Auger Eric
2019-06-25 13:34 ` Andrew Jones
2019-07-24 12:51 ` Auger Eric
2019-07-24 13:52 ` Andrew Jones
2019-07-24 14:19 ` Auger Eric
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 02/14] target/arm/cpu: Ensure we can use the pmu with kvm Andrew Jones
2019-06-25 9:35 ` Auger Eric
2019-06-26 9:49 ` Richard Henderson
2019-06-26 13:11 ` Andrew Jones
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 03/14] target/arm/monitor: Introduce qmp_query_cpu_model_expansion Andrew Jones
2019-06-26 7:43 ` Auger Eric
2019-06-26 13:26 ` Andrew Jones
2019-07-24 12:51 ` Auger Eric
2019-07-24 14:05 ` Andrew Jones
2019-07-24 14:25 ` Auger Eric
2019-07-24 14:44 ` Andrew Jones
2019-07-24 12:55 ` Auger Eric
2019-07-24 14:13 ` Andrew Jones
2019-07-25 8:04 ` Auger Eric
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 04/14] tests: arm: Introduce cpu feature tests Andrew Jones
2019-07-25 7:54 ` Auger Eric
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 05/14] target/arm/helper: zcr: Add build bug next to value range assumption Andrew Jones
2019-06-24 11:05 ` Dave Martin
2019-06-24 11:30 ` Andrew Jones
2019-06-24 16:03 ` Dave Martin
2019-06-25 6:11 ` Andrew Jones
2019-06-25 6:14 ` Andrew Jones
2019-06-26 10:01 ` Auger Eric
2019-06-26 13:28 ` Andrew Jones
2019-06-26 13:40 ` Auger Eric
2019-06-26 13:58 ` Andrew Jones
2019-06-26 14:06 ` Auger Eric
2019-06-26 10:07 ` Richard Henderson
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 06/14] target/arm: Allow SVE to be disabled via a CPU property Andrew Jones
2019-06-21 16:55 ` Philippe Mathieu-Daudé
2019-06-21 17:11 ` Andrew Jones
2019-06-26 10:00 ` Auger Eric
2019-06-26 13:38 ` Andrew Jones
2019-06-26 10:20 ` Richard Henderson
2019-06-26 13:52 ` Andrew Jones
2019-07-17 15:43 ` Andrew Jones
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 07/14] target/arm/cpu64: max cpu: Introduce sve<vl-bits> properties Andrew Jones
2019-06-24 11:05 ` Dave Martin
2019-06-24 11:49 ` Andrew Jones
2019-06-24 12:10 ` Andrew Jones
2019-06-24 16:06 ` Dave Martin
2019-06-26 14:58 ` Auger Eric
2019-06-27 9:40 ` Andrew Jones
2019-06-27 10:51 ` Auger Eric
2019-06-27 11:43 ` Andrew Jones
2019-06-26 16:56 ` Auger Eric
2019-06-27 10:46 ` Andrew Jones
2019-06-27 11:00 ` Auger Eric
2019-06-27 11:47 ` Andrew Jones
2019-06-27 15:16 ` Dave Martin
2019-06-27 16:19 ` Richard Henderson
2019-06-27 16:49 ` Richard Henderson
2019-06-28 7:27 ` Andrew Jones
2019-06-28 8:31 ` Andrew Jones
2019-06-29 0:10 ` Richard Henderson
2019-07-17 8:13 ` Andrew Jones
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 08/14] target/arm/kvm64: Fix error returns Andrew Jones
2019-06-26 10:53 ` Richard Henderson
2019-06-26 11:50 ` Richard Henderson
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 09/14] target/arm/kvm64: Move the get/put of fpsimd registers out Andrew Jones
2019-06-26 10:35 ` Richard Henderson
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 10/14] target/arm/kvm64: Add kvm_arch_get/put_sve Andrew Jones
2019-06-24 11:05 ` Dave Martin
2019-06-24 11:55 ` Andrew Jones
2019-06-24 16:09 ` Dave Martin
2019-06-26 15:22 ` Richard Henderson
2019-06-27 10:59 ` Dave Martin
2019-06-27 11:26 ` Richard Henderson
2019-06-27 15:02 ` Dave Martin
2019-07-17 9:25 ` Andrew Jones [this message]
2019-07-17 9:35 ` Andrew Jones
2019-06-27 6:56 ` Auger Eric
2019-06-27 10:59 ` Andrew Jones
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 11/14] target/arm/kvm64: max cpu: Enable SVE when available Andrew Jones
2019-06-26 11:09 ` Richard Henderson
2019-06-27 11:56 ` Andrew Jones
2019-06-28 16:14 ` Auger Eric
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 12/14] target/arm/kvm: scratch vcpu: Preserve input kvm_vcpu_init features Andrew Jones
2019-06-26 11:11 ` Richard Henderson
2019-06-27 7:30 ` Auger Eric
2019-06-27 10:53 ` Andrew Jones
2019-06-27 11:01 ` Dave Martin
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 13/14] target/arm/cpu64: max cpu: Support sve properties with KVM Andrew Jones
2019-06-28 15:55 ` Auger Eric
2019-07-17 8:41 ` Andrew Jones
2019-06-21 16:34 ` [Qemu-devel] [PATCH v2 14/14] target/arm/kvm: host cpu: Add support for sve<vl-bits> properties Andrew Jones
2019-06-27 17:15 ` Auger Eric
2019-06-28 7:05 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717092542.hkzcukvc3bwgvvk5@kamzik.brq.redhat.com \
--to=drjones@redhat.com \
--cc=Dave.Martin@arm.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=eric.auger@redhat.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).