From: Eduardo Habkost <ehabkost@redhat.com>
To: Like Xu <like.xu@linux.intel.com>
Cc: Peter Krempa <pkrempa@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 1/3] pc: Fix error message on die-id validation
Date: Fri, 16 Aug 2019 10:49:46 -0300 [thread overview]
Message-ID: <20190816134946.GZ3908@habkost.net> (raw)
In-Reply-To: <107f312a-15cd-da33-f0d6-5777bbb53150@linux.intel.com>
On Fri, Aug 16, 2019 at 09:04:16AM +0800, Like Xu wrote:
> Hi,
>
> On 2019/8/16 2:38, Eduardo Habkost wrote:
> > The error message for die-id range validation is incorrect. Example:
> >
> > $ qemu-system-x86_64 -smp 1,sockets=6,maxcpus=6 \
> > -device qemu64-x86_64-cpu,socket-id=1,die-id=1,core-id=0,thread-id=0
> > qemu-system-x86_64: -device qemu64-x86_64-cpu,socket-id=1,die-id=1,core-id=0,thread-id=0: \
> > Invalid CPU die-id: 1 must be in range 0:5
> >
> > The actual range for die-id in this example is 0:0.
>
> There is one die per socket by default.
>
> The case sockets=6 means there are 6 dies by default
> and the range for die-id is 0:5.
>
I don't understand why you say that. die-id supposed to identify
a die inside a socket. The code below is already checking for
(cpu->die_id > pcms->smp_dies - 1) because of that.
> >
> > Fix the error message to use smp_dies and print the correct range.
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> > hw/i386/pc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> > index 549c437050..24b03bb49c 100644
> > --- a/hw/i386/pc.c
> > +++ b/hw/i386/pc.c
> > @@ -2412,7 +2412,7 @@ static void pc_cpu_pre_plug(HotplugHandler *hotplug_dev,
> > return;
> > } else if (cpu->die_id > pcms->smp_dies - 1) {
> > error_setg(errp, "Invalid CPU die-id: %u must be in range 0:%u",
> > - cpu->die_id, max_socket);
> > + cpu->die_id, pcms->smp_dies - 1);
> > return;
> > }
> > if (cpu->core_id < 0) {
> >
>
--
Eduardo
next prev parent reply other threads:[~2019-08-16 13:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 18:38 [Qemu-devel] [PATCH 0/3] pc: Fix die-id validation and compatibility with libvirt Eduardo Habkost
2019-08-15 18:38 ` [Qemu-devel] [PATCH 1/3] pc: Fix error message on die-id validation Eduardo Habkost
2019-08-15 20:04 ` Vanderson Martins do Rosario
2019-08-16 1:04 ` Like Xu
2019-08-16 13:49 ` Eduardo Habkost [this message]
2019-08-19 0:53 ` Like Xu
2019-08-16 6:06 ` Markus Armbruster
2019-08-16 14:04 ` Igor Mammedov
2019-08-15 18:38 ` [Qemu-devel] [PATCH 2/3] pc: Improve error message when die-id is omitted Eduardo Habkost
2019-08-15 20:11 ` Vanderson Martins do Rosario
2019-08-16 14:06 ` Igor Mammedov
2019-08-15 18:38 ` [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary Eduardo Habkost
2019-08-16 6:10 ` Markus Armbruster
2019-08-16 7:49 ` Erik Skultety
2019-08-16 12:22 ` Markus Armbruster
2019-08-16 17:42 ` Eduardo Habkost
2019-08-16 21:07 ` Yash Mankad
2019-08-20 21:06 ` Eduardo Habkost
2019-08-17 5:34 ` Markus Armbruster
2019-08-16 16:49 ` Eduardo Habkost
2019-08-16 13:20 ` Igor Mammedov
2019-08-16 16:56 ` Eduardo Habkost
2019-08-17 6:17 ` Markus Armbruster
2019-08-26 14:51 ` Igor Mammedov
2019-08-27 16:15 ` Markus Armbruster
2019-08-28 15:27 ` Igor Mammedov
2019-08-19 19:19 ` [Qemu-devel] [PATCH 0/3] pc: Fix die-id validation and compatibility with libvirt Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816134946.GZ3908@habkost.net \
--to=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=like.xu@linux.intel.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).