From: Eduardo Habkost <ehabkost@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Peter Krempa <pkrempa@redhat.com>,
Like Xu <like.xu@linux.intel.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary
Date: Fri, 16 Aug 2019 13:56:35 -0300 [thread overview]
Message-ID: <20190816165635.GC3908@habkost.net> (raw)
In-Reply-To: <20190816152011.0c673027@redhat.com>
On Fri, Aug 16, 2019 at 03:20:11PM +0200, Igor Mammedov wrote:
> On Thu, 15 Aug 2019 15:38:03 -0300
> Eduardo Habkost <ehabkost@redhat.com> wrote:
>
> > We have this issue reported when using libvirt to hotplug CPUs:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1741451
> >
> > Basically, libvirt is not copying die-id from
> > query-hotpluggable-cpus, but die-id is now mandatory.
>
> this should have been gated on compat property and affect
> only new machine types.
> Maybe we should do just that instead of fixup so libvirt
> would finally make proper handling of query-hotpluggable-cpus.
>
>
> > We could blame libvirt and say it is not following the documented
> > interface, because we have this buried in the QAPI schema
> > documentation:
>
> I wouldn't say buried, if I understand it right QAPI schema
> should be the authoritative source of interface description.
>
> If I recall it's not the first time, there was similar issue
> for exactly the same reason (libvirt not passing through
> all properties from query-hotpluggable-cpus).
>
> And we had to fix it up on QEMU side (numa_cpu_pre_plug),
> but it seems 2 years later libvirt is still broken the same way :(
>
> Should we really do fixups or finaly fix it on libvirt side?
Is it truly a bug in libvirt? Making QEMU behave differently
when getting exactly the same input sounds like a bad idea, even
if we documented that at the QAPI documentation.
My suggestion is to instead drop the comment below from the QAPI
documentation. New properties shouldn't become mandatory.
>
> > > Note: currently there are 5 properties that could be present
> > > but management should be prepared to pass through other
> > > properties with device_add command to allow for future
> > > interface extension. This also requires the filed names to be kept in
> > > sync with the properties passed to -device/device_add.
> >
> > But I don't think this would be reasonable from us. We can just
> > make QEMU more flexible and let CPU properties to be omitted when
> > there's no ambiguity. This will allow us to keep compatibility
> > with existing libvirt versions.
>
> I don't really like making rule from exceptions so I'd suggest doing
> it only for die_id if we have to do fix it up (with fat comment
> like in numa_cpu_pre_plug).
> The rest are working fine as is.
I will insist we make it consistent for all properties, but I
don't want this discussion to hold the bug fix. So I'll do this:
I will submit a new patch that makes only die-id optional, and CC
qemu-stable.
After that, i will submit this patch again, and we can discuss
whether we should make all properties optional.
--
Eduardo
next prev parent reply other threads:[~2019-08-16 16:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 18:38 [Qemu-devel] [PATCH 0/3] pc: Fix die-id validation and compatibility with libvirt Eduardo Habkost
2019-08-15 18:38 ` [Qemu-devel] [PATCH 1/3] pc: Fix error message on die-id validation Eduardo Habkost
2019-08-15 20:04 ` Vanderson Martins do Rosario
2019-08-16 1:04 ` Like Xu
2019-08-16 13:49 ` Eduardo Habkost
2019-08-19 0:53 ` Like Xu
2019-08-16 6:06 ` Markus Armbruster
2019-08-16 14:04 ` Igor Mammedov
2019-08-15 18:38 ` [Qemu-devel] [PATCH 2/3] pc: Improve error message when die-id is omitted Eduardo Habkost
2019-08-15 20:11 ` Vanderson Martins do Rosario
2019-08-16 14:06 ` Igor Mammedov
2019-08-15 18:38 ` [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary Eduardo Habkost
2019-08-16 6:10 ` Markus Armbruster
2019-08-16 7:49 ` Erik Skultety
2019-08-16 12:22 ` Markus Armbruster
2019-08-16 17:42 ` Eduardo Habkost
2019-08-16 21:07 ` Yash Mankad
2019-08-20 21:06 ` Eduardo Habkost
2019-08-17 5:34 ` Markus Armbruster
2019-08-16 16:49 ` Eduardo Habkost
2019-08-16 13:20 ` Igor Mammedov
2019-08-16 16:56 ` Eduardo Habkost [this message]
2019-08-17 6:17 ` Markus Armbruster
2019-08-26 14:51 ` Igor Mammedov
2019-08-27 16:15 ` Markus Armbruster
2019-08-28 15:27 ` Igor Mammedov
2019-08-19 19:19 ` [Qemu-devel] [PATCH 0/3] pc: Fix die-id validation and compatibility with libvirt Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816165635.GC3908@habkost.net \
--to=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=like.xu@linux.intel.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).