* [Qemu-devel] [PATCH] hw/ppc/spapr: Use the proper include that defines 'target_ulong'
@ 2019-08-19 14:49 Philippe Mathieu-Daudé
2019-08-20 7:32 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-08-19 14:49 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé, qemu-ppc, Markus Armbruster, David Gibson
As its name implies, the Option/Architecture Vector is not target
(per cpu) specific but arch-related.
Use the proper arch-related header, allowing to use this header
with non cpu-specific objects.
This fixes this error when using this header with $common-obj:
include/hw/ppc/spapr_ovec.h:76:44: error: unknown type name ‘target_ulong’; did you mean ‘gulong’?
SpaprOptionVector *spapr_ovec_parse_vector(target_ulong table_addr, int vector);
^~~~~~~~~~~~
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/hw/ppc/spapr_ovec.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/ppc/spapr_ovec.h b/include/hw/ppc/spapr_ovec.h
index 7891e9caac..b6b8811998 100644
--- a/include/hw/ppc/spapr_ovec.h
+++ b/include/hw/ppc/spapr_ovec.h
@@ -37,7 +37,7 @@
#ifndef SPAPR_OVEC_H
#define SPAPR_OVEC_H
-#include "cpu.h"
+#include "exec/cpu-defs.h"
typedef struct SpaprOptionVector SpaprOptionVector;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Use the proper include that defines 'target_ulong'
2019-08-19 14:49 [Qemu-devel] [PATCH] hw/ppc/spapr: Use the proper include that defines 'target_ulong' Philippe Mathieu-Daudé
@ 2019-08-20 7:32 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2019-08-20 7:32 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: qemu-ppc, qemu-devel, Markus Armbruster
[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]
On Mon, Aug 19, 2019 at 04:49:26PM +0200, Philippe Mathieu-Daudé wrote:
> As its name implies, the Option/Architecture Vector is not target
> (per cpu) specific but arch-related.
> Use the proper arch-related header, allowing to use this header
> with non cpu-specific objects.
>
> This fixes this error when using this header with $common-obj:
>
> include/hw/ppc/spapr_ovec.h:76:44: error: unknown type name ‘target_ulong’; did you mean ‘gulong’?
> SpaprOptionVector *spapr_ovec_parse_vector(target_ulong table_addr, int vector);
> ^~~~~~~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
So, the change here seems sane, but the commit message totally
confuses me. Where does the term "Option/Architecture Vector" come
from? What distinction are you drawing between per-target and
per-arch? What's the symptom if this patch is not applied?
> ---
> include/hw/ppc/spapr_ovec.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/ppc/spapr_ovec.h b/include/hw/ppc/spapr_ovec.h
> index 7891e9caac..b6b8811998 100644
> --- a/include/hw/ppc/spapr_ovec.h
> +++ b/include/hw/ppc/spapr_ovec.h
> @@ -37,7 +37,7 @@
> #ifndef SPAPR_OVEC_H
> #define SPAPR_OVEC_H
>
> -#include "cpu.h"
> +#include "exec/cpu-defs.h"
>
> typedef struct SpaprOptionVector SpaprOptionVector;
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-20 7:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 14:49 [Qemu-devel] [PATCH] hw/ppc/spapr: Use the proper include that defines 'target_ulong' Philippe Mathieu-Daudé
2019-08-20 7:32 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).